[jira] [Commented] (PHOENIX-3050) Handle DESC columns in child/parent join optimization
[ https://issues.apache.org/jira/browse/PHOENIX-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398598#comment-16398598 ] Hudson commented on PHOENIX-3050: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1833 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1833/]) PHOENIX-3050 Handle DESC columns in child/parent join optimization (maryannxue: rev 977699afe0d66f1434b8bc1c5a751767e563d6ce) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/join/HashJoinMoreIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java > Handle DESC columns in child/parent join optimization > - > > Key: PHOENIX-3050 > URL: https://issues.apache.org/jira/browse/PHOENIX-3050 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.8.0 >Reporter: Maryann Xue >Assignee: Maryann Xue >Priority: Minor > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-3050.patch > > > We found that child/parent join optimization would not work with DESC pk > columns. So as a quick fix for PHOENIX-3029, we simply avoid DESC columns > when optimizing, which would have no impact on the overall approach and no > impact on ASC columns. > > But eventually we need to make the optimization work with DESC columns too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-3050) Handle DESC columns in child/parent join optimization
[ https://issues.apache.org/jira/browse/PHOENIX-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369775#comment-16369775 ] Maryann Xue commented on PHOENIX-3050: -- Thank you, [~rajeshbabu], for reminding me! 5.x branch has now caught up with all my recent check-ins. > Handle DESC columns in child/parent join optimization > - > > Key: PHOENIX-3050 > URL: https://issues.apache.org/jira/browse/PHOENIX-3050 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.8.0 >Reporter: Maryann Xue >Assignee: Maryann Xue >Priority: Minor > Fix For: 4.14.0 > > Attachments: PHOENIX-3050.patch > > > We found that child/parent join optimization would not work with DESC pk > columns. So as a quick fix for PHOENIX-3029, we simply avoid DESC columns > when optimizing, which would have no impact on the overall approach and no > impact on ASC columns. > > But eventually we need to make the optimization work with DESC columns too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-3050) Handle DESC columns in child/parent join optimization
[ https://issues.apache.org/jira/browse/PHOENIX-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369032#comment-16369032 ] Rajeshbabu Chintaguntla commented on PHOENIX-3050: -- [~maryannxue] This is missing in 5.x branch. Can you please commit it to the branch as well. Thanks. > Handle DESC columns in child/parent join optimization > - > > Key: PHOENIX-3050 > URL: https://issues.apache.org/jira/browse/PHOENIX-3050 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.8.0 >Reporter: Maryann Xue >Assignee: Maryann Xue >Priority: Minor > Fix For: 4.14.0 > > Attachments: PHOENIX-3050.patch > > > We found that child/parent join optimization would not work with DESC pk > columns. So as a quick fix for PHOENIX-3029, we simply avoid DESC columns > when optimizing, which would have no impact on the overall approach and no > impact on ASC columns. > > But eventually we need to make the optimization work with DESC columns too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-3050) Handle DESC columns in child/parent join optimization
[ https://issues.apache.org/jira/browse/PHOENIX-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280987#comment-16280987 ] Hudson commented on PHOENIX-3050: - SUCCESS: Integrated in Jenkins build Phoenix-master #1886 (See [https://builds.apache.org/job/Phoenix-master/1886/]) PHOENIX-3050 Handle DESC columns in child/parent join optimization (maryannxue: rev 071fbce499c5303ffdcd4bbe25c1cda788aced0c) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/join/HashJoinMoreIT.java > Handle DESC columns in child/parent join optimization > - > > Key: PHOENIX-3050 > URL: https://issues.apache.org/jira/browse/PHOENIX-3050 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.8.0 >Reporter: Maryann Xue >Assignee: Maryann Xue >Priority: Minor > Fix For: 4.14.0 > > Attachments: PHOENIX-3050.patch > > > We found that child/parent join optimization would not work with DESC pk > columns. So as a quick fix for PHOENIX-3029, we simply avoid DESC columns > when optimizing, which would have no impact on the overall approach and no > impact on ASC columns. > > But eventually we need to make the optimization work with DESC columns too. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-3050) Handle DESC columns in child/parent join optimization
[
https://issues.apache.org/jira/browse/PHOENIX-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279258#comment-16279258
]
Hadoop QA commented on PHOENIX-3050:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12894919/PHOENIX-3050.patch
against master branch at commit d77c237b560900671c3a9c58f6f2398342655e8a.
ATTACHMENT ID: 12894919
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+public Pair
compileJoinConditions(StatementContext lhsCtx, StatementContext rhsCtx,
Strategy strategy) throws SQLException {
+SortOrder toSortOrder = strategy == Strategy.SORT_MERGE ?
SortOrder.ASC : (strategy == Strategy.HASH_BUILD_LEFT ? right.getSortOrder() :
left.getSortOrder());
+right = CoerceExpression.create(right, toType,
toSortOrder, right.getMaxLength());
+Pair joinConditions =
joinSpec.compileJoinConditions(context, subContexts[i],
JoinCompiler.Strategy.HASH_BUILD_RIGHT);
+Pair joinConditions =
lastJoinSpec.compileJoinConditions(lhsCtx, context,
JoinCompiler.Strategy.HASH_BUILD_LEFT);
+Pair joinConditions =
lastJoinSpec.compileJoinConditions(type == JoinType.Right ? rhsCtx : lhsCtx,
type == JoinType.Right ? lhsCtx : rhsCtx, JoinCompiler.Strategy.SORT_MERGE);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1652//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1652//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1652//console
This message is automatically generated.
> Handle DESC columns in child/parent join optimization
> -
>
> Key: PHOENIX-3050
> URL: https://issues.apache.org/jira/browse/PHOENIX-3050
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.8.0
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>Priority: Minor
> Attachments: PHOENIX-3050.patch
>
>
> We found that child/parent join optimization would not work with DESC pk
> columns. So as a quick fix for PHOENIX-3029, we simply avoid DESC columns
> when optimizing, which would have no impact on the overall approach and no
> impact on ASC columns.
>
> But eventually we need to make the optimization work with DESC columns too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-3050) Handle DESC columns in child/parent join optimization
[ https://issues.apache.org/jira/browse/PHOENIX-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221363#comment-16221363 ] Maryann Xue commented on PHOENIX-3050: -- [~jamestaylor], it turns out to be a bug in skip-scan rather than the join optimization. So could you please take a look at PHOENIX-4322? As soon as that gets fixed, I can enable this optimization on DESC columns right away. > Handle DESC columns in child/parent join optimization > - > > Key: PHOENIX-3050 > URL: https://issues.apache.org/jira/browse/PHOENIX-3050 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.8.0 >Reporter: Maryann Xue >Assignee: Maryann Xue >Priority: Minor > > We found that child/parent join optimization would not work with DESC pk > columns. So as a quick fix for PHOENIX-3029, we simply avoid DESC columns > when optimizing, which would have no impact on the overall approach and no > impact on ASC columns. > > But eventually we need to make the optimization work with DESC columns too. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-3050) Handle DESC columns in child/parent join optimization
[ https://issues.apache.org/jira/browse/PHOENIX-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213210#comment-16213210 ] James Taylor commented on PHOENIX-3050: --- Would be great to get back to this one, [~maryannxue] if you have some spare cycles. > Handle DESC columns in child/parent join optimization > - > > Key: PHOENIX-3050 > URL: https://issues.apache.org/jira/browse/PHOENIX-3050 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.8.0 >Reporter: Maryann Xue >Assignee: Maryann Xue >Priority: Minor > > We found that child/parent join optimization would not work with DESC pk > columns. So as a quick fix for PHOENIX-3029, we simply avoid DESC columns > when optimizing, which would have no impact on the overall approach and no > impact on ASC columns. > > But eventually we need to make the optimization work with DESC columns too. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
