[jira] [Commented] (PHOENIX-3241) Convert_tz doesn't allow timestamp data type
[ https://issues.apache.org/jira/browse/PHOENIX-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664597#comment-15664597 ] Josh Elser commented on PHOENIX-3241: - Thanks, [~an...@apache.org]! [~jamestaylor], unless I hear otherwise from you, I will wait for 4.9.0 to finish before landing this. [~lhofhansl] ditto for 4.8.2 > Convert_tz doesn't allow timestamp data type > > > Key: PHOENIX-3241 > URL: https://issues.apache.org/jira/browse/PHOENIX-3241 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Josh Elser > Fix For: 4.10.0 > > Attachments: PHOENIX-3241.002.patch, PHOENIX-3241.003.patch, > PHOENIX-3241.patch > > > As per documentation, we allow timestamp data type of convert_tz but as per > code only DATE dataype is allowed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3241) Convert_tz doesn't allow timestamp data type
[ https://issues.apache.org/jira/browse/PHOENIX-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663426#comment-15663426 ] Ankit Singhal commented on PHOENIX-3241: [~elserj], +1 , Adding a test case is always better. > Convert_tz doesn't allow timestamp data type > > > Key: PHOENIX-3241 > URL: https://issues.apache.org/jira/browse/PHOENIX-3241 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal > Fix For: 4.10.0 > > Attachments: PHOENIX-3241.002.patch, PHOENIX-3241.003.patch, > PHOENIX-3241.patch > > > As per documentation, we allow timestamp data type of convert_tz but as per > code only DATE dataype is allowed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3241) Convert_tz doesn't allow timestamp data type
[ https://issues.apache.org/jira/browse/PHOENIX-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657163#comment-15657163 ] Josh Elser commented on PHOENIX-3241: - Ahh, I missed that, Ankit (and didn't explicitly try this out). The unit test just looked funny to me :). Let me try having a test case for both date and timestamp on your initial patch. > Convert_tz doesn't allow timestamp data type > > > Key: PHOENIX-3241 > URL: https://issues.apache.org/jira/browse/PHOENIX-3241 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal > Fix For: 4.10.0 > > Attachments: PHOENIX-3241.002.patch, PHOENIX-3241.patch > > > As per documentation, we allow timestamp data type of convert_tz but as per > code only DATE dataype is allowed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3241) Convert_tz doesn't allow timestamp data type
[ https://issues.apache.org/jira/browse/PHOENIX-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656210#comment-15656210 ] Ankit Singhal commented on PHOENIX-3241: Thanks [~elserj] for looking into this. But I think we don't need to specify DATE datatype explicitly in allowed types for the argument as PTimestamp datatype should also accept DATE argument. Have you tried running other test in Convert_tz which accept date argument with original patch? > Convert_tz doesn't allow timestamp data type > > > Key: PHOENIX-3241 > URL: https://issues.apache.org/jira/browse/PHOENIX-3241 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal > Fix For: 4.10.0 > > Attachments: PHOENIX-3241.002.patch, PHOENIX-3241.patch > > > As per documentation, we allow timestamp data type of convert_tz but as per > code only DATE dataype is allowed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3241) Convert_tz doesn't allow timestamp data type
[ https://issues.apache.org/jira/browse/PHOENIX-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651509#comment-15651509 ] Josh Elser commented on PHOENIX-3241: - Hey [~an...@apache.org], why the removal of the PDate type as an argument? Wouldn't that break existing functionality, whereas we would just want to add support for PTimestamp instead? > Convert_tz doesn't allow timestamp data type > > > Key: PHOENIX-3241 > URL: https://issues.apache.org/jira/browse/PHOENIX-3241 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal > Fix For: 4.10.0 > > Attachments: PHOENIX-3241.patch > > > As per documentation, we allow timestamp data type of convert_tz but as per > code only DATE dataype is allowed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PHOENIX-3241) Convert_tz doesn't allow timestamp data type
[
https://issues.apache.org/jira/browse/PHOENIX-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502502#comment-15502502
]
Hadoop QA commented on PHOENIX-3241:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12826821/PHOENIX-3241.patch
against master branch at commit 14d16c8534f8807680b345bcb1b47fa4d03e522c.
ATTACHMENT ID: 12826821
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
34 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.jdbc.SecureUserConnectionsTest
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/584//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/584//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/584//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/584//console
This message is automatically generated.
> Convert_tz doesn't allow timestamp data type
>
>
> Key: PHOENIX-3241
> URL: https://issues.apache.org/jira/browse/PHOENIX-3241
> Project: Phoenix
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3241.patch
>
>
> As per documentation, we allow timestamp data type of convert_tz but as per
> code only DATE dataype is allowed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PHOENIX-3241) Convert_tz doesn't allow timestamp data type
[ https://issues.apache.org/jira/browse/PHOENIX-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458501#comment-15458501 ] Ankit Singhal commented on PHOENIX-3241: [~jamestaylor], please review. > Convert_tz doesn't allow timestamp data type > > > Key: PHOENIX-3241 > URL: https://issues.apache.org/jira/browse/PHOENIX-3241 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal > Attachments: PHOENIX-3241.patch > > > As per documentation, we allow timestamp data type of convert_tz but as per > code only DATE dataype is allowed -- This message was sent by Atlassian JIRA (v6.3.4#6332)
