[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[ https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356651#comment-16356651 ] Hudson commented on PHOENIX-4546: - FAILURE: Integrated in Jenkins build Phoenix-master #1928 (See [https://builds.apache.org/job/Phoenix-master/1928/]) PHOENIX-4546 Projected table cannot be read through (ankitsinghal59: rev d5a74df8cc0b68af31eaccafee57e23b042f2b04) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/TupleProjectionCompiler.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java > Projected table cannot be read through ProjectedColumnExpression > > > Key: PHOENIX-4546 > URL: https://issues.apache.org/jira/browse/PHOENIX-4546 > Project: Phoenix > Issue Type: Bug >Reporter: Romil Choksi >Assignee: Ankit Singhal >Priority: Major > Fix For: 5.0.0, 4.14.0 > > Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch, > PHOENIX-4546_v2.patch, PHOENIX-4546_v3.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[ https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356580#comment-16356580 ] Ankit Singhal commented on PHOENIX-4546: Thanks, [~jamestaylor] and [~sergey.soldatov] for the review. Committed in 5.x, master and 4.x branches. > Projected table cannot be read through ProjectedColumnExpression > > > Key: PHOENIX-4546 > URL: https://issues.apache.org/jira/browse/PHOENIX-4546 > Project: Phoenix > Issue Type: Bug >Reporter: Romil Choksi >Assignee: Ankit Singhal >Priority: Major > Fix For: 5.0.0, 4.14.0 > > Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch, > PHOENIX-4546_v2.patch, PHOENIX-4546_v3.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[ https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355680#comment-16355680 ] James Taylor commented on PHOENIX-4546: --- +1 on the patch. Great work, [~an...@apache.org] and good find, [~sergey.soldatov]. > Projected table cannot be read through ProjectedColumnExpression > > > Key: PHOENIX-4546 > URL: https://issues.apache.org/jira/browse/PHOENIX-4546 > Project: Phoenix > Issue Type: Bug >Reporter: Romil Choksi >Assignee: Ankit Singhal >Priority: Major > Fix For: 5.0.0, 4.14.0 > > Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch, > PHOENIX-4546_v2.patch, PHOENIX-4546_v3.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[
https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355304#comment-16355304
]
Ankit Singhal commented on PHOENIX-4546:
{quote}Is this an issue for 4.x too?
{quote}
yes, this is an issue with 4.x too
{quote}Is it specific to local indexes?
{quote}
No, it is not specific to local indexes, this is observed when deleting data
from an Immutable table having multiple immutable indexes.
During delete, maintenance of immutable indexes at client executes a select
query by adding all columns involved in all immutable indexes and projected
table is created out of it, KeyValue schema will be built considering the order
of columns in projected table but TupleProjectorCompiler doesn't maintain the
order as per the SELECT projection, result in wrong ProjectedColumnExpression
used in IndexMaintainers to read the value of the columns.
This is observed in this case only because others use RowProjector which take
care of indexes of the columns correctly and use the right
ProjectedColumnExpression.
> Projected table cannot be read through ProjectedColumnExpression
>
>
> Key: PHOENIX-4546
> URL: https://issues.apache.org/jira/browse/PHOENIX-4546
> Project: Phoenix
> Issue Type: Bug
>Reporter: Romil Choksi
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 5.0.0, 4.14.0
>
> Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch,
> PHOENIX-4546_v2.patch, PHOENIX-4546_v3.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[ https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350553#comment-16350553 ] James Taylor commented on PHOENIX-4546: --- Is this an issue for 4.x too? Not sure I understand the problem, though. Is it specific to local indexes? > Projected table cannot be read through ProjectedColumnExpression > > > Key: PHOENIX-4546 > URL: https://issues.apache.org/jira/browse/PHOENIX-4546 > Project: Phoenix > Issue Type: Bug >Reporter: Romil Choksi >Assignee: Ankit Singhal >Priority: Major > Fix For: 5.0.0, 4.14.0 > > Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch, > PHOENIX-4546_v2.patch, PHOENIX-4546_v3.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[
https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350238#comment-16350238
]
Ankit Singhal commented on PHOENIX-4546:
Thanks [~sergey.soldatov], The root cause of above test failure is different
except for the one.
{code}
[ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.514 s
<<< FAILURE! - in org.apache.phoenix.end2end.DynamicFamilyIT
{code}
I have fixed the same, now should it be good to go?
> Projected table cannot be read through ProjectedColumnExpression
>
>
> Key: PHOENIX-4546
> URL: https://issues.apache.org/jira/browse/PHOENIX-4546
> Project: Phoenix
> Issue Type: Bug
>Reporter: Romil Choksi
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 5.0.0, 4.14.0
>
> Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch,
> PHOENIX-4546_v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[
https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344783#comment-16344783
]
Sergey Soldatov commented on PHOENIX-4546:
--
Tests are still in progress with the new patch, but I already see a number of
failures. Not sure whether the patch is the root cause:
{noformat}
[ERROR] Tests run: 15, Failures: 1, Errors: 0, Skipped: 1, Time elapsed:
142.623 s <<< FAILURE! - in org.apache.phoenix.end2end.ConcurrentMutationsIT
[ERROR]
testConcurrentDeletesAndUpsertValues(org.apache.phoenix.end2end.ConcurrentMutationsIT)
Time elapsed: 7.462 s <<< FAILURE!
[ERROR] Tests run: 24, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 76.128
s <<< FAILURE! - in org.apache.phoenix.end2end.DefaultColumnValueIT
[ERROR] testDefaultIndexed(org.apache.phoenix.end2end.DefaultColumnValueIT)
Time elapsed: 4.554 s <<< FAILURE!
[ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.514 s
<<< FAILURE! - in org.apache.phoenix.end2end.DynamicFamilyIT
[ERROR] Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
378.549 s <<< FAILURE! - in org.apache.phoenix.end2end.OrderByIT
[ERROR] Tests run: 46, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 119.24
s <<< FAILURE! - in org.apache.phoenix.end2end.RowValueConstructorIT
[ERROR]
testRVCLastPkIsTable1stPkIndex(org.apache.phoenix.end2end.RowValueConstructorIT)
Time elapsed: 4.492 s <<< FAILURE!
{noformat}
> Projected table cannot be read through ProjectedColumnExpression
>
>
> Key: PHOENIX-4546
> URL: https://issues.apache.org/jira/browse/PHOENIX-4546
> Project: Phoenix
> Issue Type: Bug
>Reporter: Romil Choksi
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 5.0.0, 4.14.0
>
> Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch,
> PHOENIX-4546_v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[ https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344698#comment-16344698 ] Ankit Singhal commented on PHOENIX-4546: Thanks [~sergey.soldatov] for reporting the failures. A new patch should fix these as well. > Projected table cannot be read through ProjectedColumnExpression > > > Key: PHOENIX-4546 > URL: https://issues.apache.org/jira/browse/PHOENIX-4546 > Project: Phoenix > Issue Type: Bug >Reporter: Romil Choksi >Assignee: Ankit Singhal >Priority: Major > Fix For: 5.0.0, 4.14.0 > > Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[
https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344462#comment-16344462
]
Sergey Soldatov commented on PHOENIX-4546:
--
one more:
{noformat}
[ERROR]
testConcurrentDeletesAndUpsertValues(org.apache.phoenix.end2end.ConcurrentMutationsIT)
Time elapsed: 7.458 s <<< FAILURE!
java.lang.AssertionError: Expected to find PK in data table: (0,0)
at
org.apache.phoenix.end2end.ConcurrentMutationsIT.testConcurrentDeletesAndUpsertValues(ConcurrentMutationsIT.java:214)
{noformat}
> Projected table cannot be read through ProjectedColumnExpression
>
>
> Key: PHOENIX-4546
> URL: https://issues.apache.org/jira/browse/PHOENIX-4546
> Project: Phoenix
> Issue Type: Bug
>Reporter: Romil Choksi
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 5.0.0, 4.14.0
>
> Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[
https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344454#comment-16344454
]
Sergey Soldatov commented on PHOENIX-4546:
--
[~an...@apache.org] I see some failures with patch applied:
{noformat}
[ERROR] Tests run: 24, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 64.561
s <<< FAILURE! - in org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT
[ERROR]
testIndexesUseStatsIfOnForParentTable(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT)
Time elapsed: 13.622 s <<< ERROR!
java.lang.NullPointerException: at index 4
at
org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testIndexesInheritUseStatsPropFromParentTable(ExplainPlanWithStatsEnabledIT.java:1032)
at
org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testIndexesUseStatsIfOnForParentTable(ExplainPlanWithStatsEnabledIT.java:951)
[ERROR]
testIndexesDontUseStatsIfOffForParentTable(org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT)
Time elapsed: 13.507 s <<< ERROR!
java.lang.NullPointerException: at index 4
at
org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testIndexesInheritUseStatsPropFromParentTable(ExplainPlanWithStatsEnabledIT.java:1032)
at
org.apache.phoenix.end2end.ExplainPlanWithStatsEnabledIT.testIndexesDontUseStatsIfOffForParentTable(ExplainPlanWithStatsEnabledIT.java:956)
{noformat}
> Projected table cannot be read through ProjectedColumnExpression
>
>
> Key: PHOENIX-4546
> URL: https://issues.apache.org/jira/browse/PHOENIX-4546
> Project: Phoenix
> Issue Type: Bug
>Reporter: Romil Choksi
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 5.0.0, 4.14.0
>
> Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4546) Projected table cannot be read through ProjectedColumnExpression
[ https://issues.apache.org/jira/browse/PHOENIX-4546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342948#comment-16342948 ] Ankit Singhal commented on PHOENIX-4546: [~sergey.soldatov], Actually the order of expression for the Projected table is not maintained as per the projected columns resulting in the wrong expression to read the column value from the projected tuple. can you please review the attached patch for the fix. > Projected table cannot be read through ProjectedColumnExpression > > > Key: PHOENIX-4546 > URL: https://issues.apache.org/jira/browse/PHOENIX-4546 > Project: Phoenix > Issue Type: Bug >Reporter: Romil Choksi >Assignee: Ankit Singhal >Priority: Major > Fix For: 5.0.0, 4.14.0 > > Attachments: PHOENIX-4546.patch, PHOENIX-4546_v1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
