[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[
https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407331#comment-16407331
]
Josh Elser commented on PHOENIX-4576:
-
{quote}a week ago, I shared my feedback on the patch with [~rajeshbabu] and he
has been working on fixing the same.
{quote}
Also, sorry, guys, for getting in the way of this work. My apologies.
> Fix LocalIndexSplitMergeIT tests failing in master branch
> -
>
> Key: PHOENIX-4576
> URL: https://issues.apache.org/jira/browse/PHOENIX-4576
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 4.14.0
>
> Attachments: PHOENIX-4576.patch, PHOENIX-4576_addendum.patch,
> PHOENIX-4576_v2.patch
>
>
> Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is
> failing in master branch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407166#comment-16407166 ] Josh Elser commented on PHOENIX-4576: - [~rajeshbabu], still needs to go to 5.x? > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_addendum.patch, > PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406732#comment-16406732 ] Hudson commented on PHOENIX-4576: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1838 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1838/]) PHOENIX-4576 Fix LocalIndexSplitMergeIT tests failing in master branch - (rajeshbabu: rev 37b1e11626e5399093447144c53edbbd860df1fc) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/LocalIndexSplitMergeIT.java * (edit) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_addendum.patch, > PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406590#comment-16406590 ] Hudson commented on PHOENIX-4576: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1814 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1814/]) PHOENIX-4576 Fix LocalIndexSplitMergeIT tests failing in master branch - (rajeshbabu: rev b6e33f30e2084879feeb3240444806b1e7069135) * (edit) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/LocalIndexSplitMergeIT.java > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_addendum.patch, > PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406588#comment-16406588 ] Hudson commented on PHOENIX-4576: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #66 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/66/]) PHOENIX-4576 Fix LocalIndexSplitMergeIT tests failing in master branch - (rajeshbabu: rev eaa6cdd2dc6f1102f6e7e6943b8a4420c2efc6d8) * (edit) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/LocalIndexSplitMergeIT.java > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_addendum.patch, > PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406295#comment-16406295 ] Rajeshbabu Chintaguntla commented on PHOENIX-4576: -- Uploaded addendum to fix the case mentioned by Ankit along with the test case. Going to commit it. > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_addendum.patch, > PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[
https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405832#comment-16405832
]
Ankit Singhal commented on PHOENIX-4576:
[~elserj] , a week ago, I shared my feedback on the patch with [~rajeshbabu]
and he has been working on fixing the same.
As discussed with him, Following case will fail with the above fix:-
There are two region r1(a.. aaad) and r2(aaad ... def) which are getting
merged, if in this case, let's say the startrow of the scan is "a" , then scan
will match with both the region even if r2 needs to be skipped here.
{code:java}
+ if (Bytes.compareTo(scan.getStartRow(), 0, startKey.length == 0 ?
endKey.length
+ : startKey.length, startKey.length == 0 ? new
byte[endKey.length] : startKey, 0,
+ startKey.length == 0 ? endKey.length : startKey.length) !=
0) {
+ return keyValueScanners;
+ }{code}
> Fix LocalIndexSplitMergeIT tests failing in master branch
> -
>
> Key: PHOENIX-4576
> URL: https://issues.apache.org/jira/browse/PHOENIX-4576
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 4.14.0
>
> Attachments: PHOENIX-4576.patch, PHOENIX-4576_v2.patch
>
>
> Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is
> failing in master branch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405738#comment-16405738 ] Hudson commented on PHOENIX-4576: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1810 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1810/]) PHOENIX-4576 Correct local index wrongly using child region scanners (elserj: rev 204d4aa08193a9ed845742d8923b323faf6f4f0e) * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java * (edit) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405307#comment-16405307 ] Hudson commented on PHOENIX-4576: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #65 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/65/]) PHOENIX-4576 Correct local index wrongly using child region scanners (elserj: rev ee948f0f1aab4d9d965ebd9f8fc3100789379b6a) * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java * (edit) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405293#comment-16405293 ] Hudson commented on PHOENIX-4576: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1837 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1837/]) PHOENIX-4576 Correct local index wrongly using child region scanners (elserj: rev 9e936094cd782e6f3a9b6f9c895951eb9a962e0f) * (edit) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405080#comment-16405080 ] Josh Elser commented on PHOENIX-4576: - Just ran a loop of this test 5x and it's passing consistently. Going to commit for Rajeshbabu. Can re-visit if James has more feedback :) > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397658#comment-16397658 ] Sergey Soldatov commented on PHOENIX-4576: -- Looks good to me. > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391153#comment-16391153 ] Rajeshbabu Chintaguntla commented on PHOENIX-4576: -- [~jamestaylor] [~an...@apache.org] Here is the patch works even with the hbase changes. Please review. > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch, PHOENIX-4576_v2.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366142#comment-16366142 ] Andrew Purtell commented on PHOENIX-4576: - I don't remember the exact Jira but remember a change like this otherwise the store file locking changes introduced after 1.3 might lead to a FNFE and regionserver abort. The call to next is needed to initialize something. I don't know Phoenix's needs well enough to suggest a workaround. > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365210#comment-16365210 ] James Taylor commented on PHOENIX-4576: --- Thanks so much for tracking this down, [~rajeshbabu]. Some kind of subtle difference in 1.4, [~apurtell]. Any ideas on a workaround? > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365175#comment-16365175 ] Rajeshbabu Chintaguntla commented on PHOENIX-4576: -- Ping [~jamestaylor] Before 1.4 we have special method to create scanner in HBase client scanner so that we used to get exception directly to BaseResultIterators.getIterators which we are handling properly but now scanner creation itself to next call that's why we are getting this issue. > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4576) Fix LocalIndexSplitMergeIT tests failing in master branch
[ https://issues.apache.org/jira/browse/PHOENIX-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356515#comment-16356515 ] Rajeshbabu Chintaguntla commented on PHOENIX-4576: -- [~jamestaylor] Patch fixes the Local index merge failure test case. I have enabled the test cases disabled PHOENIX-4273 passing locally. Next time will take look at them if they failed as currently not able to get full info whats happening. Please review. > Fix LocalIndexSplitMergeIT tests failing in master branch > - > > Key: PHOENIX-4576 > URL: https://issues.apache.org/jira/browse/PHOENIX-4576 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 4.14.0 > > Attachments: PHOENIX-4576.patch > > > Currenty LocalIndexSplitMergeIT#testLocalIndexScanAfterRegionsMerge is > failing in master branch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
