[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.
[ https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428914#comment-16428914 ] Josh Elser commented on PHOENIX-4677: - [~vincentpoon], yeah, annoyingly :). To keep building against the latest HBase 2.0 build, that's the version in use. Should really be 2.0.0-SNAPSHOT. > Commons-cli needs to be listed as dependency. > - > > Key: PHOENIX-4677 > URL: https://issues.apache.org/jira/browse/PHOENIX-4677 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4677.001.patch > > > After HBase upgraded to hbase-thirdparty 2.1.0 via HBASE-20223, it shaded its > dependency on commons-cli. Phoenix has apparently be transitively using this > dependency without explicitly declaring it. > We need to own the dependencies that we require. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.
[ https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425986#comment-16425986 ] Vincent Poon commented on PHOENIX-4677: --- [~elserj] I see the commit for this in 5.x-HBase-2.0 branch changed the pom.xml hbase.version from 2.0.0-beta-2 to 2.0.0 , was that intended? > Commons-cli needs to be listed as dependency. > - > > Key: PHOENIX-4677 > URL: https://issues.apache.org/jira/browse/PHOENIX-4677 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4677.001.patch > > > After HBase upgraded to hbase-thirdparty 2.1.0 via HBASE-20223, it shaded its > dependency on commons-cli. Phoenix has apparently be transitively using this > dependency without explicitly declaring it. > We need to own the dependencies that we require. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.
[ https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423666#comment-16423666 ] Hudson commented on PHOENIX-4677: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1822 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/1822/]) PHOENIX-4677 Add explicit commons-cli dependency (elserj: rev 815026ad4148d9c500f90e6a41a9df6f09e3ce8d) * (edit) phoenix-pig/pom.xml * (edit) pom.xml * (edit) phoenix-core/pom.xml * (edit) phoenix-pherf/pom.xml * (edit) phoenix-kafka/pom.xml > Commons-cli needs to be listed as dependency. > - > > Key: PHOENIX-4677 > URL: https://issues.apache.org/jira/browse/PHOENIX-4677 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4677.001.patch > > > After HBase upgraded to hbase-thirdparty 2.1.0 via HBASE-20223, it shaded its > dependency on commons-cli. Phoenix has apparently be transitively using this > dependency without explicitly declaring it. > We need to own the dependencies that we require. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.
[ https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419646#comment-16419646 ] Hudson commented on PHOENIX-4677: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #77 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/77/]) PHOENIX-4677 Add explicit commons-cli dependency (elserj: rev d911dd337d0882ec0a032163e914bde0c5a51fd9) * (edit) phoenix-kafka/pom.xml * (edit) phoenix-pig/pom.xml * (edit) phoenix-core/pom.xml * (edit) pom.xml * (edit) phoenix-pherf/pom.xml > Commons-cli needs to be listed as dependency. > - > > Key: PHOENIX-4677 > URL: https://issues.apache.org/jira/browse/PHOENIX-4677 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4677.001.patch > > > After HBase upgraded to hbase-thirdparty 2.1.0 via HBASE-20223, it shaded its > dependency on commons-cli. Phoenix has apparently be transitively using this > dependency without explicitly declaring it. > We need to own the dependencies that we require. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.
[ https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419627#comment-16419627 ] Hudson commented on PHOENIX-4677: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1844 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1844/]) PHOENIX-4677 Add explicit commons-cli dependency (elserj: rev f2f81af59ff04d9f2fc1ed441c1f7aa352b91243) * (edit) phoenix-kafka/pom.xml * (edit) phoenix-core/pom.xml * (edit) pom.xml * (edit) phoenix-pig/pom.xml * (edit) phoenix-pherf/pom.xml > Commons-cli needs to be listed as dependency. > - > > Key: PHOENIX-4677 > URL: https://issues.apache.org/jira/browse/PHOENIX-4677 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4677.001.patch > > > After HBase upgraded to hbase-thirdparty 2.1.0 via HBASE-20223, it shaded its > dependency on commons-cli. Phoenix has apparently be transitively using this > dependency without explicitly declaring it. > We need to own the dependencies that we require. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.
[ https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419192#comment-16419192 ] Josh Elser commented on PHOENIX-4677: - Realized after I pushed that I didn't actually list the commons-cli dependency in phoenix-core. Doesn't actually break anything not having that, but still isnt' correct. Pushing a fix. > Commons-cli needs to be listed as dependency. > - > > Key: PHOENIX-4677 > URL: https://issues.apache.org/jira/browse/PHOENIX-4677 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4677.001.patch > > > After HBase upgraded to hbase-thirdparty 2.1.0 via HBASE-20223, it shaded its > dependency on commons-cli. Phoenix has apparently be transitively using this > dependency without explicitly declaring it. > We need to own the dependencies that we require. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.
[ https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418104#comment-16418104 ] Sergey Soldatov commented on PHOENIX-4677: -- +1 LGTM > Commons-cli needs to be listed as dependency. > - > > Key: PHOENIX-4677 > URL: https://issues.apache.org/jira/browse/PHOENIX-4677 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4677.001.patch > > > After HBase upgraded to hbase-thirdparty 2.1.0 via HBASE-20223, it shaded its > dependency on commons-cli. Phoenix has apparently be transitively using this > dependency without explicitly declaring it. > We need to own the dependencies that we require. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.
[ https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417974#comment-16417974 ] Josh Elser commented on PHOENIX-4677: - .001 is only for the 5.x branch at this point. After commons-cli was moved into hbase-thirdparty, we need to update our use of AbstractHBaseTool to account for this. Additionally, we should have an explicit dependency on commons-cli as we use it for other (Hadoop) Tool implementations in our codebase. The Phoenix-client jar shading prevents us from hitting the same problem which HBase did with conflicting commons-cli jars on Hadoop 3 (see HBASE-20201 for more details on that "conflict"). > Commons-cli needs to be listed as dependency. > - > > Key: PHOENIX-4677 > URL: https://issues.apache.org/jira/browse/PHOENIX-4677 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.14.0, 5.0.0 > > Attachments: PHOENIX-4677.001.patch > > > After HBase upgraded to hbase-thirdparty 2.1.0 via HBASE-20223, it shaded its > dependency on commons-cli. Phoenix has apparently be transitively using this > dependency without explicitly declaring it. > We need to own the dependencies that we require. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
