[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-07-06 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535209#comment-16535209 ] Karan Mehta commented on PHOENIX-4755: -- Thanks [~elserj]. Filed PHOENIX-4805 for bumping up the

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-07-06 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535008#comment-16535008 ] Josh Elser commented on PHOENIX-4755: - +1 thanks for adding the test, Karan! No objections in

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-07-05 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534314#comment-16534314 ] Karan Mehta commented on PHOENIX-4755: -- [~elserj] Please review.  Added a test that verifies that 

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-06-29 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528374#comment-16528374 ] Karan Mehta commented on PHOENIX-4755: -- Thanks [~elserj] Sure. Will add a test as well. Just

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-06-29 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528150#comment-16528150 ] Josh Elser commented on PHOENIX-4755: - Patch looks good to me. Any chance you can write a simple

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-06-29 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527885#comment-16527885 ] Josh Elser commented on PHOENIX-4755: - Sorry for the delay, Karan! Will look at this today. >

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-06-14 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513322#comment-16513322 ] Karan Mehta commented on PHOENIX-4755: -- [~elserj] The complete patch would look something like

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-06-14 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513078#comment-16513078 ] Karan Mehta commented on PHOENIX-4755: -- Yes, I want to do the refactoring, but I don't have

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-06-12 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510265#comment-16510265 ] Josh Elser commented on PHOENIX-4755: - Ok at a glance, [~karanmehta93]. My only suggestion would

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-06-12 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510031#comment-16510031 ] Karan Mehta commented on PHOENIX-4755: -- [~alexaraujo] [~elserj] Thoughts on this patch? >

[jira] [Commented] (PHOENIX-4755) Provide an option to plugin custom avatica server config in PQS

2018-05-25 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491462#comment-16491462 ] Karan Mehta commented on PHOENIX-4755: -- Placeholder until Avatica 1.12 is released. FYI [~elserj]