[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535209#comment-16535209
]
Karan Mehta commented on PHOENIX-4755:
--
Thanks [~elserj]. Filed PHOENIX-4805 for bumping up the
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535008#comment-16535008
]
Josh Elser commented on PHOENIX-4755:
-
+1 thanks for adding the test, Karan! No objections in
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534314#comment-16534314
]
Karan Mehta commented on PHOENIX-4755:
--
[~elserj] Please review.
Added a test that verifies that
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528374#comment-16528374
]
Karan Mehta commented on PHOENIX-4755:
--
Thanks [~elserj] Sure. Will add a test as well. Just
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16528150#comment-16528150
]
Josh Elser commented on PHOENIX-4755:
-
Patch looks good to me.
Any chance you can write a simple
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527885#comment-16527885
]
Josh Elser commented on PHOENIX-4755:
-
Sorry for the delay, Karan! Will look at this today.
>
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513322#comment-16513322
]
Karan Mehta commented on PHOENIX-4755:
--
[~elserj]
The complete patch would look something like
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513078#comment-16513078
]
Karan Mehta commented on PHOENIX-4755:
--
Yes, I want to do the refactoring, but I don't have
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510265#comment-16510265
]
Josh Elser commented on PHOENIX-4755:
-
Ok at a glance, [~karanmehta93].
My only suggestion would
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510031#comment-16510031
]
Karan Mehta commented on PHOENIX-4755:
--
[~alexaraujo] [~elserj]
Thoughts on this patch?
>
[
https://issues.apache.org/jira/browse/PHOENIX-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491462#comment-16491462
]
Karan Mehta commented on PHOENIX-4755:
--
Placeholder until Avatica 1.12 is released. FYI [~elserj]
11 matches
Mail list logo