[jira] [Updated] (PHOENIX-3291) Do not throw return value of Throwables#propagate call
[ https://issues.apache.org/jira/browse/PHOENIX-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-3291: -- Attachment: PHOENIX-3291.patch > Do not throw return value of Throwables#propagate call > -- > > Key: PHOENIX-3291 > URL: https://issues.apache.org/jira/browse/PHOENIX-3291 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 4.9.0, 4.8.1 > > Attachments: PHOENIX-3291.patch > > > Several places in the code are doing the following which is wrong: > {code} > throw Throwables.propagate(e); > {code} > This seems to get rid of any stack trace. Instead, it should be: > {code} > Throwables.propagate(e); > throw new IllegalStateException(); // won't happen as above call throws > {code} > This preserves the stack trace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-3291) Do not throw return value of Throwables#propagate call
[ https://issues.apache.org/jira/browse/PHOENIX-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-3291: -- Summary: Do not throw return value of Throwables#propagate call (was: Do not throw return value of Throwables#propagate calls) > Do not throw return value of Throwables#propagate call > -- > > Key: PHOENIX-3291 > URL: https://issues.apache.org/jira/browse/PHOENIX-3291 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 4.9.0, 4.8.1 > > > Several places in the code are doing the following which is wrong: > {code} > throw Throwables.propagate(e); > {code} > This seems to get rid of any stack trace. Instead, it should be: > {code} > Throwables.propagate(e); > throw new IllegalStateException(); // won't happen as above call throws > {code} > This preserves the stack trace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)