[jira] [Updated] (PHOENIX-4996) Refactor PTableImpl to use Builder Pattern
[ https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Kulkarni updated PHOENIX-4996: -- Attachment: PHOENIX-4996-4.x-HBase-1.3.patch > Refactor PTableImpl to use Builder Pattern > -- > > Key: PHOENIX-4996 > URL: https://issues.apache.org/jira/browse/PHOENIX-4996 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4996-4.x-HBase-1.3.patch, PHOENIX-4996-v1.patch, > PHOENIX-4996.patch > > > Currently _PTableImpl_ has many constructor parameters, overloaded > constructors as well as overloaded versions of _makePTable_ which basically > creates a new PTable itself. Because of this, constructing new PTable > instances is becoming very difficult and error-prone. We should refactor this > to use the builder pattern. This will improve usability and readability of > the code at the cost of some amount of code repetition due to limitations of > the builder pattern itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4996) Refactor PTableImpl to use Builder Pattern
[ https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Kulkarni updated PHOENIX-4996: -- Attachment: PHOENIX-4996-v1.patch > Refactor PTableImpl to use Builder Pattern > -- > > Key: PHOENIX-4996 > URL: https://issues.apache.org/jira/browse/PHOENIX-4996 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4996-v1.patch, PHOENIX-4996.patch > > > Currently _PTableImpl_ has many constructor parameters, overloaded > constructors as well as overloaded versions of _makePTable_ which basically > creates a new PTable itself. Because of this, constructing new PTable > instances is becoming very difficult and error-prone. We should refactor this > to use the builder pattern. This will improve usability and readability of > the code at the cost of some amount of code repetition due to limitations of > the builder pattern itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4996) Refactor PTableImpl to use Builder Pattern
[ https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Kulkarni updated PHOENIX-4996: -- Attachment: (was: PHOENIX-4996.patch) > Refactor PTableImpl to use Builder Pattern > -- > > Key: PHOENIX-4996 > URL: https://issues.apache.org/jira/browse/PHOENIX-4996 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4996.patch > > > Currently _PTableImpl_ has many constructor parameters, overloaded > constructors as well as overloaded versions of _makePTable_ which basically > creates a new PTable itself. Because of this, constructing new PTable > instances is becoming very difficult and error-prone. We should refactor this > to use the builder pattern. This will improve usability and readability of > the code at the cost of some amount of code repetition due to limitations of > the builder pattern itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PHOENIX-4996) Refactor PTableImpl to use Builder Pattern
[ https://issues.apache.org/jira/browse/PHOENIX-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Kulkarni updated PHOENIX-4996: -- Attachment: PHOENIX-4996.patch > Refactor PTableImpl to use Builder Pattern > -- > > Key: PHOENIX-4996 > URL: https://issues.apache.org/jira/browse/PHOENIX-4996 > Project: Phoenix > Issue Type: Improvement >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Attachments: PHOENIX-4996.patch > > > Currently _PTableImpl_ has many constructor parameters, overloaded > constructors as well as overloaded versions of _makePTable_ which basically > creates a new PTable itself. Because of this, constructing new PTable > instances is becoming very difficult and error-prone. We should refactor this > to use the builder pattern. This will improve usability and readability of > the code at the cost of some amount of code repetition due to limitations of > the builder pattern itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
