Re: [Discuss] Twill removal and Guava update plan

2020-06-10 Thread Istvan Toth
Thanks for the feedback, Ankit. Yes, we could skip creating the shaded guava artifact. However, creating an explicit shaded guava for phoenix has the following advantages: 1. It saves space (we have one set of shaded guava classes, instead of three (one for tephra, omid, and phoenix each) 2. If

Re: [Discuss] Twill removal and Guava update plan

2020-06-09 Thread Ankit Singhal
Thanks, Istvan for putting up a detailed plan +1 for removing twill(as I can see it is recently moved to Attic) and adding whatever convenience it's bringing in Omid/tephra project itself. Instead of creating a shaded artifact of Guava and then refer it in Omid and Tephra, can't we just

Re: [Discuss] Twill removal and Guava update plan

2020-06-02 Thread Josh Elser
Sounds like a well-thought-out plan to me. If we're going through and changing Guava, it may also be worthwhile to try to eliminate the use of Guava in our "public API". While the shaded guava eliminates classpath compatibility issues, Guava could (at any point) drop a class that we're using