[jira] [Commented] (PIG-5256) Bytecode generation for POFilter and POForeach
[ https://issues.apache.org/jira/browse/PIG-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416100#comment-17416100 ] Koji Noguchi commented on PIG-5256: --- bq. Rohini, can you update the patch and document the current limitation? Pinging [~rohini]. Let's get this in for 0.18. > Bytecode generation for POFilter and POForeach > -- > > Key: PIG-5256 > URL: https://issues.apache.org/jira/browse/PIG-5256 > Project: Pig > Issue Type: Sub-task > Components: impl >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy >Priority: Major > Fix For: 0.18.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PIG-5256) Bytecode generation for POFilter and POForeach
[ https://issues.apache.org/jira/browse/PIG-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012258#comment-17012258 ] Koji Noguchi commented on PIG-5256: --- +1 We have been using this patch (with slight bug fix) for months now. Let's commit it to trunk (0.18) and make it optional. (default: off) Rohini, can you update the patch and document the current limitation? > Bytecode generation for POFilter and POForeach > -- > > Key: PIG-5256 > URL: https://issues.apache.org/jira/browse/PIG-5256 > Project: Pig > Issue Type: Sub-task > Components: impl >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy >Priority: Major > Fix For: 0.18.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PIG-5256) Bytecode generation for POFilter and POForeach
[ https://issues.apache.org/jira/browse/PIG-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168175#comment-16168175 ] Rohini Palaniswamy commented on PIG-5256: - Reminder to review - [~daijy], [~knoguchi] and [~szita] > Bytecode generation for POFilter and POForeach > -- > > Key: PIG-5256 > URL: https://issues.apache.org/jira/browse/PIG-5256 > Project: Pig > Issue Type: Sub-task > Components: impl >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5256) Bytecode generation for POFilter and POForeach
[ https://issues.apache.org/jira/browse/PIG-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121068#comment-16121068 ] Daniel Dai commented on PIG-5256: - Haven't checked the code line by line, but the overall approach looks good to me. The patch flattened expression tree and nested plan, so we can avoid virtual function call, and have a cleaner solution for multi-time evaluation issue. This can be extended to flatten the whole operator tree in the future (whole stage codegen). > Bytecode generation for POFilter and POForeach > -- > > Key: PIG-5256 > URL: https://issues.apache.org/jira/browse/PIG-5256 > Project: Pig > Issue Type: Sub-task > Components: impl >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5256) Bytecode generation for POFilter and POForeach
[ https://issues.apache.org/jira/browse/PIG-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117265#comment-16117265 ] Rohini Palaniswamy commented on PIG-5256: - bq. Do we need to add this to ./license dir? Not sure. Most projects are not there. But I guess there is no harm in adding it. Will do in the next revision of the patch. > Bytecode generation for POFilter and POForeach > -- > > Key: PIG-5256 > URL: https://issues.apache.org/jira/browse/PIG-5256 > Project: Pig > Issue Type: Sub-task > Components: impl >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5256) Bytecode generation for POFilter and POForeach
[ https://issues.apache.org/jira/browse/PIG-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117257#comment-16117257 ] Koji Noguchi commented on PIG-5256: --- bq. License: The newly added fernflower.jar used for decompilation is from IntelliJ Do we need to add this to ./license dir? > Bytecode generation for POFilter and POForeach > -- > > Key: PIG-5256 > URL: https://issues.apache.org/jira/browse/PIG-5256 > Project: Pig > Issue Type: Sub-task > Components: impl >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
