[jira] [Updated] (PIG-5067) Revisit union on numeric type and chararray to bytearray

2016-12-02 Thread Koji Noguchi (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Koji Noguchi updated PIG-5067:
--
Hadoop Flags: Incompatible change,Reviewed  (was: Incompatible change)

> Revisit union on numeric type and chararray to bytearray
> 
>
> Key: PIG-5067
> URL: https://issues.apache.org/jira/browse/PIG-5067
> Project: Pig
>  Issue Type: Bug
>Reporter: Koji Noguchi
>Assignee: Koji Noguchi
> Fix For: 0.17.0
>
> Attachments: pig-5067-v01.patch, pig-5067-v02.patch
>
>
> In PIG-2071, we changed the behavior of union on numeric and chararray to 
> bytearray.
> This itself was always failing at runtime until we changed to skip the 
> bytearray typecast for union-onschema in PIG-3270.
> (For union, it still fails with typecast to bytearray error. )
> Now, seeing users getting inconsistent results due to this union-ed bytearray.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (PIG-5067) Revisit union on numeric type and chararray to bytearray

2016-12-02 Thread Koji Noguchi (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Koji Noguchi updated PIG-5067:
--
Attachment: pig-5067-v02.patch

Thanks for the review Daniel.

Tests passed, committing shortly.  
Found one typo in my error message.  

{noformat}
< String msg = "Union of incompatible types now allowed. "
> String msg = "Union of incompatible types not allowed. "
{noformat}
Obviously, it should be "NOT" allowed.  Updating the patch and committing this 
one.

> Revisit union on numeric type and chararray to bytearray
> 
>
> Key: PIG-5067
> URL: https://issues.apache.org/jira/browse/PIG-5067
> Project: Pig
>  Issue Type: Bug
>Reporter: Koji Noguchi
>Assignee: Koji Noguchi
> Attachments: pig-5067-v01.patch, pig-5067-v02.patch
>
>
> In PIG-2071, we changed the behavior of union on numeric and chararray to 
> bytearray.
> This itself was always failing at runtime until we changed to skip the 
> bytearray typecast for union-onschema in PIG-3270.
> (For union, it still fails with typecast to bytearray error. )
> Now, seeing users getting inconsistent results due to this union-ed bytearray.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (PIG-5067) Revisit union on numeric type and chararray to bytearray

2016-12-01 Thread Koji Noguchi (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Koji Noguchi updated PIG-5067:
--
Attachment: pig-5067-v01.patch

Attaching {{pig-5067-v01.patch}} that would 
* Fail for incompatible union with "onschema". Regular union has been failing 
already.
* union with different internal column types for tuples or bags are still 
allowed (with empty schema)
* Add line-number for "union" failures.

> Revisit union on numeric type and chararray to bytearray
> 
>
> Key: PIG-5067
> URL: https://issues.apache.org/jira/browse/PIG-5067
> Project: Pig
>  Issue Type: Bug
>Reporter: Koji Noguchi
>Assignee: Koji Noguchi
> Attachments: pig-5067-v01.patch
>
>
> In PIG-2071, we changed the behavior of union on numeric and chararray to 
> bytearray.
> This itself was always failing at runtime until we changed to skip the 
> bytearray typecast for union-onschema in PIG-3270.
> (For union, it still fails with typecast to bytearray error. )
> Now, seeing users getting inconsistent results due to this union-ed bytearray.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)