Re: [jira] [Created] (PIRK-73) Change All Properties in ResponderProps to be public

2016-10-06 Thread Walter Ray-Dulany
+1 lgtm On Thu, Oct 6, 2016 at 9:17 AM, Ellison Anne Williams (JIRA) < j...@apache.org> wrote: > Ellison Anne Williams created PIRK-73: > - > > Summary: Change All Properties in ResponderProps to be public > Key: PIRK-73 >

Re: [jira] [Created] (PIRK-73) Change All Properties in ResponderProps to be public

2016-10-06 Thread Walter Ray-Dulany
I think that making these public should be fine. On Thu, Oct 6, 2016 at 10:10 AM, Walter Ray-Dulany wrote: > +1 lgtm > > On Thu, Oct 6, 2016 at 9:17 AM, Ellison Anne Williams (JIRA) < > j...@apache.org> wrote: > >> Ellison Anne Williams created PIRK-73: >>

[GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...

2016-10-06 Thread ellisonanne
GitHub user ellisonanne opened a pull request: https://github.com/apache/incubator-pirk/pull/106 [PIRK-73] - Change All Properties in ResponderProps to be public You can merge this pull request into a Git repository by running: $ git pull

Re: [VOTE] Apache Pirk 0.2.0-incubating Release

2016-10-06 Thread Tim Ellison
On 06/10/16 05:02, Josh Elser wrote: > +1 (binding) > > * L good > * xsums/sigs OK > * mvn apache-rat:check passes > * can build from source > > Things to look into for next release: > > * apache-pirk-0.2.0-incubating.jar appears to have way too many LICENSE > entries (the MIT/BSD licensed

[GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-pirk/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [VOTE] Apache Pirk 0.2.0-incubating Release

2016-10-06 Thread Ellison Anne Williams
Hi Guys, The vote passes with five +1 binding votes and no -1 votes. I will now call a vote on general@. Thanks! Ellison Anne On Thu, Oct 6, 2016 at 8:53 AM, Tim Ellison wrote: > On 06/10/16 05:02, Josh Elser wrote: > > +1 (binding) > > > > * L good > > * xsums/sigs OK

[VOTE] Apache Pirk 0.2.0-incubating Release

2016-10-06 Thread Ellison Anne Williams
Hi Guys, The PPMC vote for the Apache Pirk 0.2.0-incubating release has passed. We kindly request that the IMPC now vote on the release.. The PPMC vote thread is located here: https://lists.apache.org/thread.html/eeef01a2ed65e1c0919e08830d91279f40c94690fb76bc86ddc48c3d@%3Cdev.pirk.apache.org%3E

Re: Distributed tests take a long time, and that's ok.

2016-10-06 Thread Darin Johnson
Being pretty familiar with that section of the code base right now. I think a few things could be done. Regardless I'm refactoring it for submodules do it'll be easier to iterate these. The main place I'd start is currently each platform test creates a new input, which means the querier logic is

Re: [GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...

2016-10-06 Thread Darin Johnson
Being pretty familiar with that section of the code base right now. I think a few things could be done. Regardless I'm refactoring it for submodules do it'll be easier to iterate these. The main place I'd start is currently each platform test creates a new input, which means the querier logic is

Re: [GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...

2016-10-06 Thread Darin Johnson
Sorry wrong thread disregard. On Oct 6, 2016 6:37 PM, "Darin Johnson" wrote: > Being pretty familiar with that section of the code base right now. I > think a few things could be done. Regardless I'm refactoring it for > submodules do it'll be easier to iterate these.