[GitHub] incubator-pirk pull request #108: WIP: Submodule Refactor Phase 1

2016-10-16 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/108#discussion_r83564967 --- Diff: pirk-spark/src/main/java/org/apache/pirk/responder/wideskies/spark/streaming/SparkStreamingResponder.java --- @@ -0,0 +1,232 @@

[GitHub] incubator-pirk pull request #108: WIP: Submodule Refactor Phase 1

2016-10-16 Thread ellisonanne
Github user ellisonanne commented on a diff in the pull request: https://github.com/apache/incubator-pirk/pull/108#discussion_r83564697 --- Diff: pirk-core/src/main/java/org/apache/pirk/test/distributed/DistributedTestCLI.java --- @@ -18,12 +18,7 @@ */ package

[GitHub] incubator-pirk issue #108: WIP: Submodule Refactor Phase 1

2016-10-16 Thread ellisonanne
Github user ellisonanne commented on the issue: https://github.com/apache/incubator-pirk/pull/108 Looks like it's headed in the right direction - a few minor comments inline. I did not run the tests. Before the PR is completed, the LICENSE and NOTICE files need to be