[GitHub] incubator-pirk pull request #118: Correct the .travis.yml

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-pirk/pull/118


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-pirk pull request #118: Correct the .travis.yml

2016-11-29 Thread jacobwil
GitHub user jacobwil opened a pull request:

https://github.com/apache/incubator-pirk/pull/118

Correct the .travis.yml

The step that builds pirk is incorrectly in the install phase (which 
[Travis CI 
documentation](https://docs.travis-ci.com/user/customizing-the-build) says is 
to "install any dependencies required"). The script phase is to "run the build 
script" which is what was happening in the install phase. 

Right now the same tests run twice which increases build time for no 
benefit. To verify this, look at [this build 
log](https://s3.amazonaws.com/archive.travis-ci.org/jobs/174076031/log.txt) and 
search for `T E S T S`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jacobwil/incubator-pirk patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-pirk/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #118


commit 736801765dd6353d8b5f71da59fbb16476a29491
Author: Jacob Wilder 
Date:   2016-11-29T15:55:21Z

Correct the .travis.yml

The step that builds pirk is incorrectly in the install phase (which 
[Travis CI 
documentation](https://docs.travis-ci.com/user/customizing-the-build) says is 
to "install any dependencies required"). The script phase is to "run the build 
script" which is what was happening in the install phase. 

Right now the same tests run twice which increases build time for no 
benefit. To verify this, look at [this build 
log](https://s3.amazonaws.com/archive.travis-ci.org/jobs/174076031/log.txt) and 
search for `T E S T S`.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---