[GitHub] [plc4x] hutcheb opened a new pull request #172: Feature/modbus add additional address formats and change lowest register to 1.

2020-07-16 Thread GitBox
hutcheb opened a new pull request #172: URL: https://github.com/apache/plc4x/pull/172 - Address formats similar to 41, 01 were added - Address formats similar to 4x1, 0x01 were added. - Changed the lowest address the user can reference to 1 instead of 0.

Re: [jira] [Created] (PLC4X-214) [Modbus] Holding register addresses have an offset of 1 (Not reading the correct address)

2020-07-16 Thread Ben Hutcheson
Hi, Sure I'll give it a shot, I have created a pull request to be able to use the (01, 0x1, 11, etc..) address formats as well as to change the minimum address to 1. Corresponding to 01 or the first coil. Please don't hold back on criticizing it, it is the only way I'll learn.

Re: [jira] [Created] (PLC4X-214) [Modbus] Holding register addresses have an offset of 1 (Not reading the correct address)

2020-07-16 Thread Christofer Dutz
Hi Ben and Otto, First off all, thank you Ben for that very detailed explanation. It does seem as if we should extend the parser to support the different numeric variants. I don't see any problems in supporting both the hex-like one as well as the pure numeric one. I think we have 6 separate

Re: [jira] [Created] (PLC4X-214) [Modbus] Holding register addresses have an offset of 1 (Not reading the correct address)

2020-07-16 Thread Niclas Hedhman
To make things worse, there is equipment on the market with both 32-bit numbers as well IEEE floats. And many clients are incapable of doing something meaningful with those... And then there is equipment that uses one register to indicate the magnitude of one or more other registers, say

Re: [jira] [Created] (PLC4X-214) [Modbus] Holding register addresses have an offset of 1 (Not reading the correct address)

2020-07-16 Thread Christofer Dutz
Guess it should be possible for plc4x to interpret INT as two shorts long as four... In that case it could probably also handle half precision floats (16 bit), full floats and double, if the encoding is somewhat standard (which I assume it's not) Chris Von:

Re: Have to run `mvn package` before running example codes in the repo

2020-07-16 Thread Julian Feinauer
Hey, I think we cant as we use code generation. Normally your mvn generate-sources should do the trick, we have to have a look why it didnt. BUT we should definetly write it more prominent in the README.md, I think! Julian Am 16.07.20, 10:29 schrieb "Xiangdong Huang" : Hi, I just

[jira] [Created] (PLC4X-216) Upgrade PLC4x-IoTDB example and supply the document

2020-07-16 Thread Xiangdong Huang (Jira)
Xiangdong Huang created PLC4X-216: - Summary: Upgrade PLC4x-IoTDB example and supply the document Key: PLC4X-216 URL: https://issues.apache.org/jira/browse/PLC4X-216 Project: Apache PLC4X

Have to run `mvn package` before running example codes in the repo

2020-07-16 Thread Xiangdong Huang
Hi, I just checkout to the develop branch and want to run the project in IDEA. However, the IDEA says, class not found Class: RequirePcap Location: org.apache.plc4x.java.utils.rawsockets.netty.RawSocketChannelTest Actually, I can indeed find the RequirePcap source code from the repo. I

Re: [jira] [Created] (PLC4X-214) [Modbus] Holding register addresses have an offset of 1 (Not reading the correct address)

2020-07-16 Thread Ben Hutcheson
Hi, *I think we have 6 separate memory areas. Do you have a mapping, That I could use? I mean which first digit represents which memory area?* I thought there were only 5 areas? 0x - Coils 1x - Inputs 3x - Input Registers 4x - Holding Registers 6x - Extended Registers I've seen the IEEE format

Re: [jira] [Created] (PLC4X-214) [Modbus] Holding register addresses have an offset of 1 (Not reading the correct address)

2020-07-16 Thread Niclas Hedhman
For floats, I have only seen IEEE format. But can't rule out other. On Thu, Jul 16, 2020, 14:57 Christofer Dutz wrote: > Guess it should be possible for plc4x to interpret INT as two shorts long > as four... In that case it could probably also handle half precision floats > (16 bit), full

[GitHub] [plc4x] jixuan1989 opened a new pull request #171: [PLC4X-216]update IoTDB JDBC example and session API example; add the related doc on website

2020-07-16 Thread GitBox
jixuan1989 opened a new pull request #171: URL: https://github.com/apache/plc4x/pull/171 Hi, this pr provides using IoTDB session API for writing data. The related doc on the website is also supplied. This is an

Re: Have to run `mvn package` before running example codes in the repo

2020-07-16 Thread Christofer Dutz
Hi, For me the error reported doesn't really relate to code generation at all ... so it's strange that this solved the problem. It might be co-related as the RawSocketChannelTest seems to be missing the RequirePcap classes, which are what we use to automatically disable tests if your machine

Re: [jira] [Created] (PLC4X-214) [Modbus] Holding register addresses have an offset of 1 (Not reading the correct address)

2020-07-16 Thread Christofer Dutz
Aaaahh ... perfect Thanks Ben and Niclas. Guess I'll be doing some Modbus coding pretty soon :-) But if someone wants to try I'd be more than happy :) Chris Am 16.07.20, 11:48 schrieb "Ben Hutcheson" : Hi, *I think we have 6 separate memory areas. Do you have a mapping, That I