sruehl closed pull request #8: cleanup warnings in plc4j-api, plc4j-core,
dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
dlaboss commented on issue #1: Warning cleanup
URL: https://github.com/apache/incubator-plc4x/pull/1#issuecomment-356292913
Hi Justin, I was expecting to merge it myself, but thanks :-)
Isn't is just better to consistently work in the github
fork/feature-branch/PR flow so as to
chrisdutz commented on issue #1: Warning cleanup
URL: https://github.com/apache/incubator-plc4x/pull/1#issuecomment-356294407
Well we should get the Travis support working first or you will be working
without CI ... I've already setup the travis file thing, but still have to have
Infra
justinmclean closed pull request #1: Warning cleanup
URL: https://github.com/apache/incubator-plc4x/pull/1
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a
justinmclean commented on issue #1: Warning cleanup
URL: https://github.com/apache/incubator-plc4x/pull/1#issuecomment-356121460
IMO no need for a PR for still like this feel free to commit yourself.
This is an automated
dlaboss opened a new pull request #1: Warning cleanup
URL: https://github.com/apache/incubator-plc4x/pull/1
Cleanup a number of warnings reported by Eclipse.
There are still 50+ warnings related to raw types, casts, type safety as
well as unused field/local-variables.
Please
asfgit closed pull request #2: [WIP]Test travis integration
URL: https://github.com/apache/incubator-plc4x/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
crazzle closed pull request #3: Remove response reference in request item
URL: https://github.com/apache/incubator-plc4x/pull/3
This is an automated message from the Apache Git Service.
To respond to the message, please log
niclash opened a new pull request #4: Change from AsserttJ to Hamcrest
URL: https://github.com/apache/incubator-plc4x/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dlaboss opened a new pull request #6: cleanup sonar edgent complaints
URL: https://github.com/apache/incubator-plc4x/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on
asfgit closed pull request #6: cleanup sonar edgent complaints
URL: https://github.com/apache/incubator-plc4x/pull/6
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
asfgit closed pull request #7: cleanup some warnings (in Eclipse)
URL: https://github.com/apache/incubator-plc4x/pull/7
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833373
##
File path:
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833246
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcReadRequest.java
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170832548
##
File path:
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833305
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcWriteRequest.java
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833183
##
File path:
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170831995
##
File path:
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833285
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcReadResponse.java
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833353
##
File path:
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833513
##
File path:
plc4j/core/src/test/java/org/apache/plc4x/java/PlcDriverManagerTest.java
##
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170832428
##
File path:
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833118
##
File path:
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170833397
##
File path:
plc4j/core/src/test/java/org/apache/plc4x/java/PlcDriverManagerTest.java
##
sruehl commented on a change in pull request #8: cleanup warnings in plc4j-api,
plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170832166
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcWriteResponse.java
sruehl commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409959876
one note at this point. As far as I understand netty throws this exception
to indicate that it dislikes when the thread gets blocked. By using
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409958048
@chrisdutz your fixes in the master made it work for me also.
As I found a solution to avoid the blocking exception in the meanwhile I
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409963436
@sruehl my understanding is that netty avoids a scenario where one uses the
event loop executors threads for blocking and thus, risks a
chrisdutz commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409995467
Well I Ave started working on an option that works exactly the same way we
are doing the connection, by creating a CompletableFuture and
chrisdutz commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410171496
And I don't agree with Sebastians assumption. Even if it might be the same
thread when running in unit-tests (Here we have to write the
chrisdutz commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410170620
Ok ... so I just checked in the version I was talking about. It is basically
structurally equal to the way we are doing things in the
JulianFeinauer commented on issue #10: Fixed NPE in S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-410172284
@chrisdutz I guess due to my partial scala background I totally ignore Javas
Completable futures as superior and thus didnt think about
JulianFeinauer opened a new pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10
Fix for the NPE in S7PlcConnection's close method.
After fixing the NPE there was a netty blockingException, thus I had to
refactor the program logic
chrisdutz commented on a change in pull request #9: Added some javadoc to S7
communication path and several todos that ma…
URL: https://github.com/apache/incubator-plc4x/pull/9#discussion_r207142023
##
File path:
JulianFeinauer commented on a change in pull request #9: Added some javadoc to
S7 communication path and several todos that ma…
URL: https://github.com/apache/incubator-plc4x/pull/9#discussion_r207149237
##
File path:
asfgit closed pull request #9: Added some javadoc to S7 communication path and
several todos that ma…
URL: https://github.com/apache/incubator-plc4x/pull/9
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
sruehl commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207145613
##
File path:
plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/s7/connection/S7PlcConnection.java
##
sruehl commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207149145
##
File path:
plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/s7/connection/S7PlcConnection.java
##
sruehl commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207148665
##
File path:
plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/s7/connection/S7PlcConnection.java
##
JulianFeinauer commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207178132
##
File path:
plc4j/protocols/s7/src/main/java/org/apache/plc4x/java/s7/connection/S7PlcConnection.java
chrisdutz commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207224977
##
File path:
plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/s7/connection/S7PlcConnectionIT.java
JulianFeinauer opened a new pull request #9: Added some javadoc to S7
communication path and several todos that ma…
URL: https://github.com/apache/incubator-plc4x/pull/9
Hey all,
i went through the S7 Communication path to understand it for myself and by
doing that I tried adding
sruehl commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207198528
##
File path:
plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/s7/connection/S7PlcConnectionIT.java
##
JulianFeinauer commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207200954
##
File path:
plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/s7/connection/S7PlcConnectionIT.java
sruehl commented on a change in pull request #10: Fixed NPE in
S7PlcConnection#close.
URL: https://github.com/apache/incubator-plc4x/pull/10#discussion_r207197726
##
File path:
plc4j/protocols/s7/src/test/java/org/apache/plc4x/java/s7/connection/S7PlcConnectionIT.java
##
asfgit closed pull request #11: Implement basic example of connecting an S7
device to Azure IoT Hub
URL: https://github.com/apache/incubator-plc4x/pull/11
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
chrisdutz commented on issue #12: fix a few typos
URL: https://github.com/apache/incubator-plc4x/pull/12#issuecomment-412528417
Well I guess I can simply merge this from the GitHub ui ... thanks for this
:-)
This is an
chrisdutz commented on issue #12: fix a few typos
URL: https://github.com/apache/incubator-plc4x/pull/12#issuecomment-412530954
And it does seem as if this revealed syncing problems from GitHub back to
GitBox ... will investigate
bodewig commented on issue #12: fix a few typos
URL: https://github.com/apache/incubator-plc4x/pull/12#issuecomment-412537899
As somebody toying with the idea of using gitbox for some other projects I'd
be interested in hearing what went wrong
chrisdutz closed pull request #12: fix a few typos
URL: https://github.com/apache/incubator-plc4x/pull/12
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a
DerDackel commented on issue #11: Implement basic example of connecting an S7
device to Azure IoT Hub
URL: https://github.com/apache/incubator-plc4x/pull/11#issuecomment-412079165
Whatever do you mean? ;)
Realized my mistake immediately after submitting this PR and re-pushed the
pisquaredover6 opened a new pull request #13: Basic example to connect S7
device to Google Cloud IoT Core
URL: https://github.com/apache/incubator-plc4x/pull/13
Implement basic example of connecting a S7 device to Google Cloud IoT Core
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r214037249
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcWriteRequest.java
##
@@ -24,6 +24,8 @@ Licensed
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r215170934
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldRequest.java
##
@@ -20,11 +20,13 @@
asfgit closed pull request #13: Basic example to connect S7 device to Google
Cloud IoT Core
URL: https://github.com/apache/incubator-plc4x/pull/13
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
skorikov opened a new pull request #16: Implemented throttling in Kafka Source
Connector
URL: https://github.com/apache/incubator-plc4x/pull/16
A new configuration option `rate` is implemented, which allows to limit the
polling rate to a given value (for example every 1000 milliseconds).
chrisdutz closed pull request #16: Implemented throttling in Kafka Source
Connector
URL: https://github.com/apache/incubator-plc4x/pull/16
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213965185
##
File path:
integrations/apache-camel/src/main/java/org/apache/plc4x/camel/Plc4XConsumer.java
##
@@ -84,22 +79,29 @@
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213966073
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcProprietarySender.java
##
@@ -1,41 +0,0 @@
-/*
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213967016
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldResponse.java
##
@@ -0,0 +1,42 @@
+/*
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213965327
##
File path:
integrations/apache-camel/src/main/java/org/apache/plc4x/camel/Plc4XConsumer.java
##
@@ -112,25 +114,25 @@
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213980628
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcProprietarySender.java
##
@@ -1,41 +0,0 @@
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981646
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldRequest.java
##
@@ -0,0 +1,31 @@
+/*
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981663
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcFieldResponse.java
##
@@ -0,0 +1,42 @@
+/*
chrisdutz commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981675
##
File path:
plc4j/api/src/test/java/org/apache/plc4x/java/api/connection/PlcReaderTest.java
##
@@ -38,24 +36,24 @@
sruehl commented on a change in pull request #14: WIP: Api Refactoring
URL: https://github.com/apache/incubator-plc4x/pull/14#discussion_r213981954
##
File path:
plc4j/api/src/test/java/org/apache/plc4x/java/api/connection/PlcReaderTest.java
##
@@ -38,24 +36,24 @@
skorikov opened a new pull request #18: Add support for multiple tasks in kafka
sink connector
URL: https://github.com/apache/incubator-plc4x/pull/18
This is an automated message from the Apache Git Service.
To respond to
asfgit closed pull request #17: Add support for multiple queries in kafka
source connector
URL: https://github.com/apache/incubator-plc4x/pull/17
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
asfgit closed pull request #18: Add support for multiple tasks in kafka sink
connector
URL: https://github.com/apache/incubator-plc4x/pull/18
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
asfgit closed pull request #19: Add URL Field to Key Schema in Kafka Source
Connector
URL: https://github.com/apache/incubator-plc4x/pull/19
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
dlaboss commented on a change in pull request #8: cleanup warnings in
plc4j-api, plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170929853
##
File path:
dlaboss commented on a change in pull request #8: cleanup warnings in
plc4j-api, plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r170931306
##
File path:
plc4j/core/src/test/java/org/apache/plc4x/java/PlcDriverManagerTest.java
##
dlaboss commented on a change in pull request #8: cleanup warnings in
plc4j-api, plc4j-core, dummy-driver
URL: https://github.com/apache/incubator-plc4x/pull/8#discussion_r171087658
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/PlcWriteResponse.java
JulianFeinauer commented on a change in pull request #26: connection manager
for connection pool initial version
URL: https://github.com/apache/incubator-plc4x/pull/26#discussion_r221467015
##
File path:
JulianFeinauer commented on a change in pull request #26: connection manager
for connection pool initial version
URL: https://github.com/apache/incubator-plc4x/pull/26#discussion_r221466988
##
File path:
JulianFeinauer commented on a change in pull request #26: connection manager
for connection pool initial version
URL: https://github.com/apache/incubator-plc4x/pull/26#discussion_r221466969
##
File path:
JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java
checked.
URL: https://github.com/apache/incubator-plc4x/pull/21#issuecomment-425737626
Hey @chrisdutz and @sruehl just wanted to bump that up. I think we should
decide here on something and either merge or decline
JulianFeinauer opened a new pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29
I just finished the first (working) implementation of the Object-Plc-Mapping
(OPM).
This is a JPA Like functionality on top of plc4x which allows to issue
requests
JulianFeinauer commented on issue #26: connection manager for connection pool
initial version
URL: https://github.com/apache/incubator-plc4x/pull/26#issuecomment-431838474
This PR *should* not be merged but all necessary changes should be done in
#30.
JulianFeinauer opened a new pull request #30: connection manager for connection
pool initial version
URL: https://github.com/apache/incubator-plc4x/pull/30
This is a duplicate of #26 to allow @sruehl or @JulianFeinauer to do
changes on the branch as Marcel is currenlty not available.
skorikov opened a new pull request #32: Provide connection metadata
URL: https://github.com/apache/incubator-plc4x/pull/32
As discussed in the mailing list, connection capabilities should be obtained
via metadata and remove `Optional`s from the `PlcConnection`.
sruehl closed pull request #30: connection manager for connection pool initial
version
URL: https://github.com/apache/incubator-plc4x/pull/30
This is an automated message from the Apache Git Service.
To respond to the
asfgit closed pull request #32: Provide connection metadata
URL: https://github.com/apache/incubator-plc4x/pull/32
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
chrisdutz commented on issue #36: Add simple mock driver
URL: https://github.com/apache/incubator-plc4x/pull/36#issuecomment-435013325
I thought it would make more sense to start removing all of these mock
drivers and instead extend the "Test-Driver" as this should provide everything
JulianFeinauer commented on issue #36: Add simple mock driver
URL: https://github.com/apache/incubator-plc4x/pull/36#issuecomment-435101505
@chrisdutz I'll check if I can add this Mock functionality in there. As I
recall the test driver is currently working against internal values or
JulianFeinauer closed pull request #36: Add simple mock driver
URL: https://github.com/apache/incubator-plc4x/pull/36
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
JulianFeinauer opened a new pull request #37: Extend test driver with mock
URL: https://github.com/apache/incubator-plc4x/pull/37
@chrisdutz here is my approach as extension to the Test Driver.
@sruehl It is still not in the Test-utils package but I'm unsure if it
should as I'm unsure
sruehl commented on issue #30: connection manager for connection pool initial
version
URL: https://github.com/apache/incubator-plc4x/pull/30#issuecomment-433380970
I haven't closed this... What the...???
This is an automated
sruehl commented on a change in pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228232133
##
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java
##
@@ -0,0 +1,380 @@
+/*
+
sruehl commented on a change in pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230429
##
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java
##
@@ -0,0 +1,380 @@
+/*
+
sruehl commented on a change in pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228231695
##
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java
##
@@ -0,0 +1,380 @@
+/*
+
sruehl commented on a change in pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230640
##
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java
##
@@ -0,0 +1,380 @@
+/*
+
sruehl commented on issue #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#issuecomment-433106003
looks good to me :)
This is an automated message from the Apache Git Service.
To respond to the
sruehl commented on a change in pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228231802
##
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java
##
@@ -0,0 +1,380 @@
+/*
+
sruehl commented on a change in pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230727
##
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java
##
@@ -0,0 +1,380 @@
+/*
+
sruehl commented on a change in pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230145
##
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntity.java
##
@@ -0,0 +1,34 @@
+/*
+ Licensed to
sruehl commented on a change in pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228230930
##
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java
##
@@ -0,0 +1,380 @@
+/*
+
sruehl commented on a change in pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29#discussion_r228231315
##
File path:
plc4j/utils/opm/src/main/java/org/apache/plc4x/java/opm/PlcEntityManager.java
##
@@ -0,0 +1,380 @@
+/*
+
asfgit closed pull request #29: Opm plcentitymanager
URL: https://github.com/apache/incubator-plc4x/pull/29
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
sruehl closed pull request #26: connection manager for connection pool initial
version
URL: https://github.com/apache/incubator-plc4x/pull/26
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
1 - 100 of 2116 matches
Mail list logo
