Re: Handling of signed / unsigned values

2018-08-02 Thread Julian Feinauer
s our requested datatype. So in this case reading a "Java Integer" would read a "PLC Short". I wouldn't like to have the user have to think of the PLC datatypes when writing his code. Chris

Exception on closing S7PlcConnection

2018-08-01 Thread Julian Feinauer
Hi all, I finally organized an S7 to play around a bit more with Plc4J and observed the following exception that is always thrown when calling close on the S7PlcConnection: 17:04:54.438 [nioEventLoopGroup-2-1] WARN i.n.util.concurrent.DefaultPromise - An exception was thrown by

Re: Handling of signed / unsigned values

2018-08-02 Thread Julian Feinauer
l drivers. What do you all think about this? Chris Outlook for Android<https://aka.ms/ghei36> herunterladen Von: Julian Feinauer Gesendet: Donnerstag, 2. August, 17:14 Betreff: Re: Handling of signed / unsigned values An: dev@plc4x.apache.o

Re: Handling of signed / unsigned values

2018-08-03 Thread Julian Feinauer
le with the address type and implement the mapping. What do you think? Chris Am 02.08.18, 21:36 schrieb "Julian Feinauer" : Hi Chris,

Re: [DISCUSS] Change the format of the S7 Adresses

2018-08-03 Thread Julian Feinauer
Just a small note to your example, in case of the "DOUBLE" we should write LREAL und relly stick to the TIA naming. Just stating that to avoid confusion. Julian Am 03.08.18, 15:42 schrieb "Christofer Dutz" : This is the Discussion thread, so please perform any form of discussion

Re: [VOTE] Change the format of the S7 Adresses

2018-08-03 Thread Julian Feinauer
+1 And I think it is good to do things the "right" way from start, thank you for your effort : ) Am 03.08.18, 15:41 schrieb "Christofer Dutz" : Hi all, We have recently discussed changing something to allow defining not only the Java-Side type, but also the expected type

Datatypes in Plc4j

2018-07-29 Thread Julian Feinauer
Hi all, After going through the code I have one question about the “Typesystem”. From what I see, currently the java class(-name) is used as type parameter. Is there a specific reason for this? I am asking because this limits, in my eyes, the extensibility of the typesystem massively, e.g., for

Warm welcome and Batching

2018-07-26 Thread Julian Feinauer
Hey everybody, first, a great compliment for starting this excellent project and bringing it this far forward. I am on the dev mailing list since some months and was following the development very interested but was not able to give any input due to other duties. We are a small german start-up

Re: Code-Retreat on Mallorca?

2018-07-31 Thread Julian Feinauer
I would simply contact them via email, the same way I have in the past. Chris Am 31.07.18, 14:40 schrieb "Julian Feinauer" : Hey Chris,

Re: Code-Retreat on Mallorca?

2018-07-31 Thread Julian Feinauer
Chris Am 31.07.18, 11:59 schrieb "Julian Feinauer" : Hi Chris, this sounds really awesome and I would love to join you. And I think alongside me two other

Re: Warm welcome and Batching

2018-07-31 Thread Julian Feinauer
of having that setup. At least for this part I have the documentation online ;-) http://plc4x.apache.org/developers/vpn.html Chris Am 27.07.18, 16:52 schrieb "Julian Feinauer" :

Re: Datatypes in Plc4j

2018-07-31 Thread Julian Feinauer
07.18, 13:37 schrieb "Julian Feinauer" : Hi all, After going through the code I have one question about the “Typesystem”. From what I see, currently the java class(-name) is used as type parameter.

Plc4x dev-meeting in Nürtingen

2018-07-31 Thread Julian Feinauer
Hey all, as discussed with Chris we plan to host a small Plc4X meeting in Nürtingen (near Stuttgart) at the pragmatic minds office. I created a doodle for finding a date in September (as in August everybody is on holiday). So if you plan to come please feel free to participate! Link:

AW: Feedback to the TODO items of Julians first Pull Request

2018-08-02 Thread Julian Feinauer
Hi, thanks for bringing them up. I agree with you that we should remove them from the code and better open a ticket for then. I added them as it is an easy and direct way to point the reviewer to the point. One addition to the UUID generation: I get your point (never thought of this).

AW: Exception on closing S7PlcConnection

2018-08-02 Thread Julian Feinauer
y tool to the build and this is reporting some things I have to fix first. Chris Am 01.08.18, 17:07 schrieb "Julian Feinauer" : Hi all, I finally organized an S7 to play around a bit more with Plc4J and observed the following exception that is always thrown when calling

Handling of signed / unsigned values

2018-08-02 Thread Julian Feinauer
Hey all, again me with another question : ) I started going through some examples on our PLC and came to a situation where we use signed and unsigned values in the PLC. This goes kind of back to my type system question. How could I tell the Reader to read me an Unsigned Int from a S7

Re: Code-Retreat on Mallorca?

2018-08-01 Thread Julian Feinauer
e it would be a good chance to get them to come too. Chris Am 31.07.18, 11:59 schr

New Siemens S7 Protocol?

2018-08-01 Thread Julian Feinauer
Hi all, I just came across this announcement https://industrial.softing.com/de/news/nachrichten/article/datafeed-opc-suite-supports-optimized-block-access-for-siemens-controllers.html . They state there that there exists a new S7-2 protocol which allows communication with the PLC over symbolic

Re: Code-Retreat on Mallorca?

2018-07-31 Thread Julian Feinauer
Hi Chris, this sounds really awesome and I would love to join you. And I think alongside me two other members of our team which are currently getting into plc4j would come with us. I really like the idea of getting together and speaking personally. 3-4 days are fine if we do it over a

Re: Warm welcome and Batching

2018-07-27 Thread Julian Feinauer
(separate addresses). Chris Am 26.07.18, 16:54 schrieb "Julian Feinauer" : Hi Chris and hi Sebastian, thank both

Re: Warm welcome and Batching

2018-07-26 Thread Julian Feinauer
plementing this. Chris Am 26.07.18, 13:59 schrieb "Julian Feinauer" : Hey everybody, first, a great compliment for starting this excellent project and bringing

Re: Plc4x dev-meeting in Nürtingen

2018-08-06 Thread Julian Feinauer
schrieb "Julian Feinauer" : Hey all, as discussed with Chris we plan to host a small Plc4X meeting in Nürtingen (near Stuttgart) at the pragmatic minds office. I created a doodle for finding a date in September (as in August everybody is on holiday). So if you pl

Re: How about a \promiscuous\ mode?

2018-08-09 Thread Julian Feinauer
Hi Chris, Hi Sebastian, I like the idea a lot. In fact, when we started our PLC Communication the first idea was to only listen on the net for the PLC / Sensor communication. Especially with protocols like IOLink this would give richer information than the PLC itself. Ideally, without the

Plc4X meeting in Nürtingen

2018-08-09 Thread Julian Feinauer
Hey all, from our doodle we have a clear winner for the date. We will do the plc4x meeting on Sept. 20. I suggest that we start at 10 AM. Our office is located at pragmatic industries GmbH Zementwerk 1 72622 Nürtingen Our entry can only be reached via the spiral stair. I have an idea for the

Re: [DISCUSS] Change the format of the S7 Adresses

2018-08-11 Thread Julian Feinauer
for all of you? Julian Am 07.08.18, 13:06 schrieb "Julian Feinauer" : Hi, Looks good to me. Best Julian Am 07.08.18, 12:53 schrieb "Christofer Dutz" :

Re: [DISCUSS] Change the format of the S7 Adresses

2018-08-11 Thread Julian Feinauer
The first solution especially emphasizes that the connection / address String is really what an S7 programmer sees in his TIA program. What do you think? Julian Am 11.08.18, 11:08 schrieb "Julian Feinauer" : Hi Chris, thanks for the clarification

Re: [DISCUSS] Change the format of the S7 Adresses

2018-08-11 Thread Julian Feinauer
Am 07.08.18, 13:06 schrieb "Julian Feinauer" : Hi, Looks good to me. Best Julian

Re: [DISCUSS] Change the format of the S7 Adresses

2018-08-16 Thread Julian Feinauer
Hey Chris, thanks for your reply. Unfortunately I cannot help you with gathering the types based on the protocol messages (we also have only one type here so reverse engineering is kind of... difficould). But what I "know" is how to read it from the SPS via request (we could send this request

Re: [S7] Finding out what type of S7 we are talking too (Was: Re: [DISCUSS] Change the format of the S7 Adresses)

2018-08-16 Thread Julian Feinauer
be a IsoTP(DATA) packet with a S7(USER_DATA) payload. This contains a parameter of type CPU_SERVICES ... I'll whip something up (hopefully today) ... shouldn't be that difficult. Chris Am 16.08.18, 09:36 schrieb "Julian Feinauer" : Hey Chris,

Re: Suggestion to refactoring drivers (especially S7)

2018-08-17 Thread Julian Feinauer
+1 from my side as well. I think it is definitely best practice to do it that way as it increases encapsulation in a sense. From my perspective serialization is in this situation part of the model not a common concern as usual. One think I observed in the S7 Implementation was the usage of

Refactoring of Drivers

2018-08-17 Thread Julian Feinauer
Hey al, I like to open another discussion as I am currently working on another refactoring of the Drivers, namely the extraction of "binary" encoders and decoders as common concern. After our discussion about the addition of the binary representation to the S7 driver I observed that several

Re: [DISCUSS] Change the format of the S7 Adresses

2018-08-07 Thread Julian Feinauer
d guess a fitting default type if omitted (same behavior as now)+ Chris Am 03.08.18, 15:53 schrieb "Julian Feinauer" : Just a small note to your example, in case of the "DOUBLE" we shou

Re: [DISCUSS] Change the format of the S7 Adresses

2018-08-07 Thread Julian Feinauer
Am 07.08.18, 12:39 schrieb "Julian Feinauer" : Hi Chris, I guess I'm fine with everything but perhaps we should try to find a syntax which goes well for all dri

Re: Plc4X meeting in Nürtingen

2018-08-10 Thread Julian Feinauer
cket of feedback from the industry from we distilled typical use cases. But the 20th is blocked in my calendar and 10am sounds good for me :-) Chris Am 09.08.18, 11:49 schrieb "Julian Feinaue

Re: Plc4X meeting in Nürtingen

2018-08-10 Thread Julian Feinauer
Am 09.08.18, 11:49 schrieb "Julian Feinauer" : Hey all, from our doodle we have a clear winner for the date. We wil

AW: Refactoring of Drivers

2018-08-20 Thread Julian Feinauer
-Date-Time-API-in-Java-8-2198399.html?seite=all I wish I had had a look at this before just now ;-) ... I especially like the "LocalDate", "LocalTime" and "LocalDateTime" seems with this the natural differentiation between Date and Time is now possible without hac

Re: Refactoring of Drivers

2018-08-17 Thread Julian Feinauer
ers sounds a little overkill to me. If a driver requires other conversions, it can implement them itself and if it makes sense to add them to the driver-base version, that code is simply moved there. What do you think? Chris Am 17.08.18, 14:14 schr

Re: Refactoring of Drivers

2018-08-17 Thread Julian Feinauer
rt of need the cartesian set of all combinations of converters. I do agree that this "interpret this integer as a Boolean", or "translate this float into an int" sounds universally usable. Correct? Chris Am 17.08.18, 15:03 schrieb "Julia

AW: Refactoring of Drivers

2018-08-20 Thread Julian Feinauer
8 and we use the Java 8 API quite a lot. So we couldn't go below Java 8 anyway so this wouldn't make things worse. I doubt it will prevent us from using newer versions. Chris Am 20.08.18, 21:20 schrieb "Julian Feinauer" : Hi Chris, yes, JSR 310 definetly made Java a be

Re: Refactoring of Drivers

2018-08-20 Thread Julian Feinauer
omething in the API. This was the reason, why I was so hesitant to do a first release as I knew that there will be changes and I wante to do most of the big ones before a firtst release. Chris Am 20.08.18, 11:31 schrieb "Julian Feinauer" :

Re: Internal Type System

2018-08-23 Thread Julian Feinauer
Hi Sebastian, as we also need this feature for an use case I am willing to implement this ASAP but I want to make sure how to do it properly to avoid long conceptual discussions when a PR is available. Julian Am 23.08.18, 15:53 schrieb "Sebastian Rühl" : Hi Together,

Plc4XJPA Layer considerations

2018-08-24 Thread Julian Feinauer
Hi all, I decided to start a new thread to answer to Sebastians mail below regarding the Plc4X JPA Like layer. First, I think, we should get a feeling of what we all think this layer could or should do and what kind of features we want to incorporate there. From my perspective this layer

Re: Plc4XJPA Layer considerations

2018-08-24 Thread Julian Feinauer
" we will be producing code hard-coded to one type... Chris Am 24.08.18, 11:03 schrieb "Julian Feinauer" : Hey Chris, this definition seems valid to me but is lack

Re: Plc4XJPA Layer considerations

2018-08-24 Thread Julian Feinauer
maybe it's worth following up on that thread ... Have to admit that I also have to re-read it first ;-) Chris [1] https://lists.apache.org/thread.html/dfca30f6c3319e592c4a6412924edc9a31f2e18844204dc373eebc5d@%3Cdev.plc4x.apache.org%3E

API Changes proposal

2018-08-25 Thread Julian Feinauer
Hi Chris, I’m about to go through your suggestions fort he API changes (by the way, thanks for your effort and the very nice documentation) and I’m a bit confused about the differences between * Chris Proposal * Chris Proposal 2 They seem very equal to me. Are these two versions of

Re: ASF Slack

2018-08-28 Thread Julian Feinauer
Hi Benedikt, I think ist a good idea to have a slack for communication but I agree that its a bit inelegant to require an apache email as many interested people or (new) participants won't have one (I for example have none). Julian Am 28.08.18, 15:02 schrieb "Benedikt Ritter" :

Re: Kafka Connect Integration

2018-08-28 Thread Julian Feinauer
Hey Sagar, hey Chris, I want to join your discussion for part b3 as this is something we usually require. We use a module we call the plc-scraper for that task (the term scraping in that content is borrowed from Prometheus where it is used extensively in this context [1]). Generally

Re: ASF Slack

2018-08-28 Thread Julian Feinauer
ustin Mclean" : I could be mistaken but I think anyone can join or be invited On Wed., 29 Aug. 2018, 8:41 am Julian Feinauer, < j.feina...@pragmaticminds.de> wrote: > Hi Benedikt, > > > > I think ist a good idea to have

Re: Refactoring of Drivers

2018-08-20 Thread Julian Feinauer
Or something like that ... What do you think? Chris Am 17.08.18, 17:03 schrieb "Julian Feinauer" : Hi Chris, this is exactly the idea I have in mind. For me in your step 1 I again see two steps.

Re: Refactoring of Drivers

2018-08-20 Thread Julian Feinauer
. Now the driver could optimize this internally. So if a driver supports custom types, this feature is used, if it doesn't the items are individually requested. Just some thoughts on this. Chris Am 20.08.18, 10:09 schrieb "Julian Feinauer" :

Re: Refactoring of Drivers

2018-08-20 Thread Julian Feinauer
Good idea? Or not so good ... at the moment I sort of like it, but I might not have thought about everything. Chris Am 20.08.18, 09:47 schrieb "Julian Feinauer" : Hi Chris, okay, then I had a wrong assumption. Previously,

Re: Making your first release

2018-08-26 Thread Julian Feinauer
Hi Justin, I like your suggestion and also wanted to suggest a first release soon as we start to experiment with plc4j a lot in one project and I don’t like to reference snapshots with the lot of changes going on (or are planned). What do the others think of this? Julian Am 26.08.18,

AW: ASF Slack

2018-08-29 Thread Julian Feinauer
ion ... hope that works. Chris Am 29.08.18, 07:26 schrieb "Julian Feinauer" : Thanks for the clarification justin. The easiest way to find out would be to try ; ) @Benedikt (or anyone else who already is in the channel): I cannot join directly (as I'm missing the @apache

[S7] String handling

2018-09-02 Thread Julian Feinauer
Hey everybody, I have another question about the semantics we should provide for reading / writing Strings in the S7 Driver. I have not found an example on how this is handled currently but to me it looks a bit like a mix of reading the data as “array”, i.e., using the size parameter on the

[S7] TransportSize Enum Code

2018-09-02 Thread Julian Feinauer
Hi all, as I’m going forward refactoring the S7 Driver I have one question about the „code“ field in the TransportSize enum. For me it seems as this code is type related, i.e., is unique for each “S7Type”. Furthermore, the number of bytes should be redundant to the bitWIdth ( / 8), except for

Re: API Changes proposal

2018-09-06 Thread Julian Feinauer
Am 06.09.18, 10:53 schrieb "Julian Feinauer" : Hi Chris, thank you so much for your effort! I can't wait for the refactoring to be finished (and the release of course). I'm following your branch and as you implemented most of the th

Re: API Changes proposal

2018-09-06 Thread Julian Feinauer
d path. So much for the Update ... Chris Am 03.09.18, 13:53 schrieb "Julian Feinauer" : Hi Chris, exactly, that was my point (sorry for writing it not out clearly). We can do it that way the only thing we are "loo

Re: [S7] String handling

2018-09-02 Thread Julian Feinauer
y proposal [2]. I will implement it this way if everybody agrees. Julian [1] https://support.industry.siemens.com/tf/WW/en/posts/string-data-type/51621?page=0=10 [2] https://cwiki.apache.org/confluence/x/jhpPBQ Am 02.09.18, 13:03 schrieb "Julian Feinauer" : Hey everybody,

Re: Feature prospect of project plc4x

2018-09-11 Thread Julian Feinauer
Hi Andreas, a warm welcome also from my side! Regarding your second aspect, I agree with chris and the interface where one could integrate arbitrary complex logic. Regarding your first aspect, I am not sure what you mean with the "hierarchical" interface. I mean, it is surely possible to

Re: Feature prospect of project plc4x

2018-09-11 Thread Julian Feinauer
/to/a/file The Drivers and Dirver Manager can already process such options ... these could be used to override some defaults (Want a smaller PDU-Size, Longer-Timeouts, Specified-Freshness-Factor for all requests, or the just mentioned address-files) Chris Am 11.09.18, 16:28 schri

Re: Missing board report

2018-09-30 Thread Julian Feinauer
Hey Chris, I wanted to give you the precedence here but please let me know if I can help you with anything. Julian Am 30.09.18, 21:52 schrieb "Christofer Dutz" : Yup ... I'm on it ... Just wanted to have the first release out the door and other things done first. Will take

Re: Plc Prefix on all API Types

2018-10-08 Thread Julian Feinauer
Hi Andrey, this was my first thought also. But now I'm unsure whether this si a problem or not as it makes it really clear when working with PlC4X related stuff and when not. And it avoids confusion with wrong imports when typing something like "ReadReq..." (auto-complete) which is about the

Re: Usage of Optional for Reader / Writer

2018-10-08 Thread Julian Feinauer
e extra step of ensuring support, but can omit it where we just don't need it. > > > > Haven't quite understood the whole "Metadata" thing though ... ;-) > > > > Chris > > > >

Re: Request for Registration: PLC4X goes Mallorca meetup (Nov. 2018) ...

2018-10-18 Thread Julian Feinauer
Perfect, we will check our flights tomorrow and try to get that coordinated. Thanks already for your effort, Chris! Julian From: Christofer Dutz Sent: Thursday, October 18, 2018 4:34:37 PM To: dev@plc4x.apache.org Subject: Re: Request for Registration: PLC4X goes

PLC4X-to-OPC-Bridge

2018-10-12 Thread Julian Feinauer
Hey all, I visited the Motec Fair for industrial automation and had a lot of interesting discussions in the context of plc4x. Timm and his colleagues at the Hochschule Esslingen developed a very interesting “I4.0” solution which is currently solely based on OPC UA. We then discussed about

AW: OPM / Connection Pool

2018-10-26 Thread Julian Feinauer
ool validation calls isConnected() on return. So we could implement the „ping“ in the isConnected() as well or implement a ping() as you described. Sebastian > Am 25.10.2018 um 23:13 schrieb Julian Feinauer : > > Hey all, > > just wanted to keep you up to date with some things Se

AW: OPM / Connection Pool

2018-10-26 Thread Julian Feinauer
u mean with "request limiting". Chris Am 26.10.18, 15:55 schrieb "Julian Feinauer" : Hey Sebastian, the only problem witht he reuse i had is possible internal state during in-flight messages or problems with multi threading (I'm not sure if all drivers are thread safe

AW: OPM / Connection Pool

2018-10-26 Thread Julian Feinauer
gt; > > …only message based (e.g. 100 requests). > This could then be implemented in driver-bases (like the > SingleItemToSingleRequestProtocol) and could be used for protocol that don’t > have sophisticated traffic control implementation like S7 > > Sebastian > >

Re: [DISCUSS] How about a new release some time soon?

2018-10-29 Thread Julian Feinauer
+1 from my side as well. Am 29.10.18, 16:29 schrieb "Bahamada" : +1 from my side Von: Christofer Dutz Gesendet: Montag, 29. Oktober 2018 15:17 An: dev@plc4x.apache.org Betreff: [DISCUSS] How about a new release some time soon? Hi all, after I think we

Throw Exception when retrieving non-existing Field in Response

2018-10-31 Thread Julian Feinauer
Hi all, I found some time today to test and toy around a bit with PLC4X and I discovered a behavior which I found weird. I had the response from a request which “failed” (Response was successful but the Field I wanted was NOT_FOUND). So my response.getLong(“…”) returned a “null” and a

Re: Throw Exception when retrieving non-existing Field in Response

2018-11-01 Thread Julian Feinauer
Hi, thanks for your response. I changed it. Julian Am 01.11.18, 12:30 schrieb "Christofer Dutz" : Hi Julian, I agree that we should throw an exception. Chris Am 31.10.18, 21:25 schrieb "Julian Feinauer" : Hi all,

Re: Moving OPM Example

2018-11-01 Thread Julian Feinauer
Hey Chris, I like Kittens also! And yes, I'm definitely okay and will prepare a documentation site soon to make it easier to adopt (well, I hope its pretty easy). Best Julian PS.: Kittens and Mallorca Am 01.11.18, 12:40 schrieb "Christofer Dutz" : Hi Julian, I am currently

Re: [GitHub] JulianFeinauer opened a new pull request #36: Add simple mock driver

2018-11-01 Thread Julian Feinauer
Hi Chris, sorry, I saw this too late. I agree with your idea. And I think these Both would be good additions. I already openend a PR for a "in-between" solution which allows to inject a Mock Object where requests for Type "MOCK/..." are forwarded to. This allows the Full power of frameworks like

AW: Plc-opm

2018-10-26 Thread Julian Feinauer
Thank you so much sebastian, for your warm and motivating words and even more for cleaning up the mess from the github-gitbox desync combined with some merge related problems with the branch. Julian Von: Sebastian Rühl Gesendet: Freitag, 26. Oktober 2018

OPM / Connection Pool

2018-10-25 Thread Julian Feinauer
Hey all, just wanted to keep you up to date with some things Sebastian and I discussed off-list. Thanks to Sebastians support the Object Plc Mapping (opm) is now mergend into master and I would love to get some feedback. I hope that I can soon add some documentation on the side about that and I

AW: Worrying JUnit5 results

2018-10-25 Thread Julian Feinauer
Hey Chris, I'm no Jenkins and no groovy expert, but shouldn't this be doable in the Jenkinsfile... there should be some way to get the number of executed tests from the context and simply fail the build (or set it to yellow) if number of tests is lower than last run (should be doable via

Re: Idea to bootstrap plc4j to X

2018-11-03 Thread Julian Feinauer
tion which is integratable into our build and would bring the biggest benefit. Chris Am 02.11.18, 17:10 schrieb "Julian Feinauer" : Hey all, I thought of our problem to currently only have support for one language (Java). For usage s

Idea to bootstrap plc4j to X

2018-11-02 Thread Julian Feinauer
Hey all, I thought of our problem to currently only have support for one language (Java). For usage scenarios on “regular” devices (not embedded ones) one “simple” and “easy” way to bootstrap our current Java Implementation to other languages would be created by using Thrift or protobuf. In

Re: Better name for "Promiscuous Mode Drivers"

2018-11-06 Thread Julian Feinauer
Ah, too slow... I also Suggest passive :) From: Otto Fowler Sent: Tuesday, November 6, 2018 7:08:41 PM To: dev@plc4x.apache.org; Christofer Dutz Subject: Re: Better name for "Promiscuous Mode Drivers" Passive? On November 6, 2018 at 11:46:13, Christofer Dutz

Re: [DISCUSS] How about a new release some time soon?

2018-11-11 Thread Julian Feinauer
effort. >As now almost all of the important modules are reaching the threshold of > "no issues and vulnerabilities" and "test coverage x >= 80%" >I think we should start the next release process soon. > >So if you got something you want in the 0.2.0, s

Re: [DISCUSS] How about a new release some time soon?

2018-11-11 Thread Julian Feinauer
Oh and thank you soo much for all the refactoring!! This makes things really stable. Julian From: Julian Feinauer Sent: Sunday, November 11, 2018 3:53:51 PM To: dev@plc4x.apache.org Subject: Re: [DISCUSS] How about a new release some time soon? Full ack, +1

Re: [DISCUSS] How about a new release some time soon?

2018-11-15 Thread Julian Feinauer
ecific documentation should be in the plc4j module structure and C stuff in plc4c and alike. But that's just my opinion. Chris Am 15.11.18, 12:19 schrieb "Julian Feinauer" : Hi Chris, I cannot answer questions 1 and 2.

AW: [DISCUSS] How about a new release some time soon?

2018-11-15 Thread Julian Feinauer
uld speed up or you'll have to manually cherry pick commits. Chris Am 11.11.18, 15:55 schrieb "Julian Feinauer" : Oh and thank you soo much for all the refactoring!! This makes things really stable. Julian ____

Re: [S7] Parser for new Syntax

2018-10-01 Thread Julian Feinauer
Did you end up doing this? On September 4, 2018 at 05:46:47, Julian Feinauer ( j.feina...@pragmaticminds.de) wrote: Hi all, I just had a short discussion with chris which I wanted to bring the results back tot he list. As the new Syntax for S7 addressing is getting mor

Re: [DRAFT] Oktober Podling Report Apache PLC4X (incubating)

2018-10-02 Thread Julian Feinauer
st two new committers and PPMC members. * Julian Feinauer (pragmatic industries) * Andrey Skorikov (codecentric) Finally just before finishing this report we also finished our first release: Version 0.1.0 Our mailing list subscriptions went up another 9 to cu

We're (back) in Production / Test coverage

2018-09-29 Thread Julian Feinauer
Hey plc4x-ers, with the help of Sebastian we managed to fix all our modbus issues from the API migration and are finally back in production with the modbus module and the new api (on the current snapshot). We currently use a workflow to do custom (forked) releases to our own nexus to ensure

Re: [DRAFT] Oktober Podling Report Apache PLC4X (incubating)

2018-10-02 Thread Julian Feinauer
people were present. Also did we successfully vote in our first two new committers and PPMC members. * Julian Feinauer (Pragmatic Minds) * Andrey Skorikov (codecentric) Finally just before finishing this report we also finished our first release: Version 0.1.0

Re: [S7] Parser for new Syntax

2018-10-01 Thread Julian Feinauer
d up doing this? On September 4, 2018 at 05:46:47, Julian Feinauer ( j.feina...@pragmaticminds.de) wrote: Hi all, I just had a short discussion with chris which I wanted to bring the results back tot he list. As the new Syntax for S7 addressing is getting more and more comp

Re: [OPM] First Implementation draft finished

2018-10-04 Thread Julian Feinauer
'' + '}'; } } Am 04.10.18, 09:19 schrieb "Christofer Dutz" : Hi Julian, could you please push your branch to the plc4x repo too (You are a committer now) ... cause this simplifies any form of "compare with branch" thing

[OPM] First Implementation draft finished

2018-10-04 Thread Julian Feinauer
Hey all, I just finished the first (working) implementation of the Object-Plc-Mapping (OPM). This is a JPA Like functionality on top of plc4x which allows to issue requests against plc4x by calling Methods on POJOs! Basically, it uses 3 classes. * PlcEntityManager: This is the main class.

Re: Request for Registration: PLC4X goes Mallorca meetup (Nov. 2018) ...

2018-10-06 Thread Julian Feinauer
Hi Chris, as stated, Tim and I are definitely in! Best Julian Am 04.10.18, 15:28 schrieb "Christofer Dutz" : Hi all, well as it seems we will be doing our second PLC4X Meetup at the end of November (22.11.2018 – 25.11.2018) I would need some feedback on who’s planning on

Dummy Driver

2018-10-06 Thread Julian Feinauer
Hey, just had another thought. I remember chris writing about a mysterious Dummy Driver (I think he said it was implemented by Andrey, but I’m not sure). Do we have some kind of documentation about it as it would really make (some testing) a lot more easy? Thanks already! Julian

Usage of Optional for Reader / Writer

2018-10-06 Thread Julian Feinauer
Hey everybody, I’m currently groing through Andreys PR (https://github.com/apache/incubator-plc4x/pull/27) which introduces some very good API changes and makes the API a lot more concise. But one thing that annoys me from the first day on plc4x is still there (and is now even more annoying as

Re: Usage of Optional for Reader / Writer

2018-10-06 Thread Julian Feinauer
ead() with Exception thrown when a unsupported operation is invoked) balances the complexity and flexibility best. Andrey On 10/06/2018 08:38 PM, Julian Feinauer wrote: > Hey everybody, > > I’m currently groing through Andreys PR (https://github.com/a

Re: Usage of Optional for Reader / Writer

2018-10-07 Thread Julian Feinauer
Review in the original sense (105 changes). So after going through the API changes I definitely +1 them but I'm unsure if a "proper" Code Review is possible / necessary (so would agree on merging directly). What do others think? Julian Am 06.10.18, 21:20 schrieb "Julian Feina

Re: PlcSubscriptionEvent extends PlcReadResponse

2018-10-08 Thread Julian Feinauer
Hi Andrey, as I understand it this is somewhat similar of an old question of mine (for the equals method of a Request / Response). I suggested back then to use UUIDs which chris didn’t like that much because they are too heavy (as unique ID / handle), thus we kept it as is. But another

Re: [S7] String handling

2018-09-03 Thread Julian Feinauer
ype. Chris Am 02.09.18, 13:03 schrieb "Julian Feinauer" : Hey everybody, I have another question about the semantics we should provide for reading / writing Strings in the S7 Driver. I have not found an example on how this is hand

Re: API Changes proposal

2018-09-03 Thread Julian Feinauer
Hi chris, I agree with your S7 field except for one little change. How do we proceed with the (optional) bit offset? I made it "Short" with the contract that null indicates no offset given. Another alternative would be to make it 0 as default or even Optional. I would prefer to have it nullable,

Re: [S7] String handling

2018-09-03 Thread Julian Feinauer
ring sizes for now and if we need it to add it with something like STRING(string-length)[array-size] Cause it's not actually an array of arrays of strings ... Chris Am 03.09.18, 13:58 schrieb "Julian Feinauer" : Hi,

Re: API Changes proposal

2018-09-03 Thread Julian Feinauer
way we don't have to add null-checks in the code. But as I said ... that's a very slight preference for that option. Chris Am 03.09.18, 10:27 schrieb "Julian Feinauer" : Hi chris, I agree with your S7 field except for one little change.

  1   2   3   4   5   >