Re: [DISCUSS] Apache PLC4X 0.6.0 RC2

2020-02-12 Thread Julian Feinauer
Hi, thanks to Chris, Dominik and Justin fort he fast replies and fixes. I applied the fixes from develop to rel/0.6 so the rel branch is now clean with the changes. How should we proceed with the VOTE. Do you still keep your -1 Justin under these circumstances? Julian Am 12.02.20, 11:54

Re: [DISCUSS] Apache PLC4X 0.6.0 RC2

2020-02-12 Thread Justin Mclean
Hi, > I just had a look ... I couldn't find any code taken from the Milo project. > All I found was usage of milo libraries. > So as we are releasing sources, do we have to mention the Milo project in the > NOTICE at all? N you do not. Thanks, Justin

Re: [DISCUSS] Apache PLC4X 0.6.0 RC2

2020-02-12 Thread Christofer Dutz
Hi All, I just had a look ... I couldn't find any code taken from the Milo project. All I found was usage of milo libraries. So as we are releasing sources, do we have to mention the Milo project in the NOTICE at all? I would think not. Chris Am 12.02.20, 09:40 schrieb "Christofer Dutz" :

Re: [DISCUSS] Apache PLC4X 0.6.0 RC2

2020-02-12 Thread Christofer Dutz
Or we just re-copy things from the Apache StreamPipes podling ;-) Chris Am 12.02.20, 09:38 schrieb "Justin Mclean" : Hi, > However for the ConfigKeys and Config classes I think we could simply change the header. If the contributors agree then you can change the

Re: [DISCUSS] Apache PLC4X 0.6.0 RC2

2020-02-12 Thread Justin Mclean
Hi, > However for the ConfigKeys and Config classes I think we could simply change > the header. If the contributors agree then you can change the headers, but this is not the major issue here, I’m more concerned by the Milo one. > As Dominik, from whom most of that code came in via PR, is