Re: [incubator-plc4x] branch master updated: Fix the ByteValueTest

2018-02-22 Thread Justin Mclean
Hi, > I extended the test with duplicated hex variants to better visualize the > boundaries: > @Test > public void checkUnsignedBoundsLongHex() { >// Hex representation to visualize valid bounds in bytes >ByteValue.checkUnsignedBounds(0x0_00_00, 2); >

Re: [incubator-plc4x] branch master updated: Fix the ByteValueTest

2018-02-22 Thread Sebastian Rühl
I take a look at it. Regarding breaking build: somehow our pipeline implementation handles a test fail a failure rather than unstable. So from my POV it would be a +1 on fixing obvious small bugs as soon as you find them, but when we find a bug with a test that we can’t immediately fix I think

Re: [incubator-plc4x] branch master updated: Fix the ByteValueTest

2018-02-21 Thread Christofer Dutz
Hi Justin. Ok ... if the max value is outside the bounds and the code should have thrown an error, then I apologize. I just saw that the value being passed in was the same as the max allowed upper bound and thought the test was wrong. Sorry for double breaking __ Maybe Sebastian can have a