[GitHub] [poi] rzymek edited a comment on pull request #154: [bug-57342] Excel compatible Zip64 implementation

2020-05-31 Thread GitBox
rzymek edited a comment on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636462830 Are you getting "corrupted file" error from Excel or OpenOffice or something else? OpenOffice Calc has a [limit of 1024

[GitHub] [poi] rzymek commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation

2020-05-31 Thread GitBox
rzymek commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636462830 Are you getting "corrupted file" error from Excel or OpenOffice or something else? OpenOffice Calc has a limit of 1024 columns (Excel's limit is 16k columns). Other than that, the

[GitHub] [poi] pjfanning commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation

2020-05-31 Thread GitBox
pjfanning commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636493479 Thanks @rzymek - we might want to make Zip64Mode.Always the default - needs some experimentation before we'd make that change though

[GitHub] [poi] rzymek commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation

2020-05-31 Thread GitBox
rzymek commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636494966 Exactly. I think that custom zip64 implementation should sit as an option for a few versions (it's only enabled when Zip64Mode.Always).

[GitHub] [poi] pjfanning commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation

2020-05-31 Thread GitBox
pjfanning commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636483470 @rzymek thanks for clarifying - do you know what effect setting Zip64Mode.Always has if you create a small spreadsheet - will this file cause problems for Excel?

[GitHub] [poi] rzymek commented on pull request #154: [bug-57342] Excel compatible Zip64 implementation

2020-05-31 Thread GitBox
rzymek commented on pull request #154: URL: https://github.com/apache/poi/pull/154#issuecomment-636492054 As far as I checked, Zip64Mode.Always does not cause problem with Excel even in small files. When it comes to Excel and big files (XML over 4Gb), then ZIP64 must be declared in the