pjfanning commented on pull request #180:
URL: https://github.com/apache/poi/pull/180#issuecomment-629460633
Thanks - merged
This is an automated message from the Apache Git Service.
To respond to the message, please log on
asfgit closed pull request #180:
URL: https://github.com/apache/poi/pull/180
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on pull request #179:
URL: https://github.com/apache/poi/pull/179#issuecomment-629447747
Thanks - merged
This is an automated message from the Apache Git Service.
To respond to the message, please log on
asfgit closed pull request #179:
URL: https://github.com/apache/poi/pull/179
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
RemboL opened a new pull request #181:
URL: https://github.com/apache/poi/pull/181
I noticed that value function doesn't work well (or at all) with array
formulas. It was pretty frustrating when we tried to evaluate array formula
like "=SUM(VALUE($B$2:$B$4))" and got error, when in Ms
netmackan opened a new pull request #182:
URL: https://github.com/apache/poi/pull/182
Before this patch the POIFSMiniStore.syncWithDataStore() method sets the
root property size to be based on the number of sectors in each block that is
used.
However it can happen is some files
netmackan commented on pull request #182:
URL: https://github.com/apache/poi/pull/182#issuecomment-630794652
I also have patches for 4.1.2, 4.0.1 and 3.15 if wanted.
This is an automated message from the Apache Git Service.
RemboL opened a new pull request #180:
URL: https://github.com/apache/poi/pull/180
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pjfanning commented on pull request #182:
URL: https://github.com/apache/poi/pull/182#issuecomment-631722702
@netmackan do you have a file that demos this problem?
This is an automated message from the Apache Git Service.
To
leowebb edited a comment on pull request #187:
URL: https://github.com/apache/poi/pull/187#issuecomment-667723572
Hello! Thank you for the response.
I've added a sample file that won't open in Excel, and a corresponding test
that throws an exception from the DataValidation when
jacobharris919 opened a new pull request #193:
URL: https://github.com/apache/poi/pull/193
The TRUNC implementation is still broken. (BUG:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62506 )
1. Bug 62506 reports that TRUNC(0.29, 2) = 0.28
2. The solution proposed in that bugfix
tcerdaITBA opened a new pull request #192:
URL: https://github.com/apache/poi/pull/192
Currently the DOUGHNUT chart requires `XDDFChartAxis` and `XDDFValueAxis`
objects in its creation which is not correct. As with the PIE and PIE3D charts,
the DOUGHNUT chart does not need these axis
snaketl commented on pull request #176:
URL: https://github.com/apache/poi/pull/176#issuecomment-677679695
Nice job! Any plans to have a release version soon with this changes? Thanks
in advance!
This is an automated
pjfanning commented on pull request #183:
URL: https://github.com/apache/poi/pull/183#issuecomment-634921478
LGTM. Merged.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
asfgit closed pull request #183:
URL: https://github.com/apache/poi/pull/183
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kortov opened a new pull request #183:
URL: https://github.com/apache/poi/pull/183
After rearranging some lib folders of ooxml in
https://github.com/apache/poi/commit/114a4dbd41c56e4c544836e58fae02aae6793cdf ,
gradle build (and therefore IDE imports) was broken. This fixes the issue.
bosofelipe commented on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636060520
@rzymek Could you give me an example because i try generate a large excel
with 37000 rows and 2500 coluns and file still corrupted using apache 4.1.2
bosofelipe commented on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636070287
@rzymek my current code failed
`import java.io.File;
import java.io.FileOutputStream;
import org.apache.commons.compress.archivers.zip.Zip64Mode;
import
bosofelipe edited a comment on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636070287
@rzymek my current code failed
`import java.io.File;
import java.io.FileOutputStream;
import org.apache.commons.compress.archivers.zip.Zip64Mode;
import
pjfanning commented on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636071530
Zip64Mode.AsNeeded is more correct - always may mean you use zip64 mode when
you don't need it
This is an
rzymek edited a comment on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636462830
Are you getting "corrupted file" error from Excel or OpenOffice or something
else? OpenOffice Calc has a [limit of 1024
rzymek commented on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636462830
Are you getting "corrupted file" error from Excel or OpenOffice or something
else? OpenOffice Calc has a limit of 1024 columns (Excel's limit is 16k
columns). Other than that, the
pjfanning commented on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636493479
Thanks @rzymek - we might want to make Zip64Mode.Always the default - needs
some experimentation before we'd make that change though
rzymek commented on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636494966
Exactly. I think that custom zip64 implementation should sit as an option
for a few versions (it's only enabled when Zip64Mode.Always).
pjfanning commented on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636483470
@rzymek thanks for clarifying - do you know what effect setting
Zip64Mode.Always has if you create a small spreadsheet - will this file cause
problems for Excel?
rzymek commented on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636492054
As far as I checked, Zip64Mode.Always does not cause problem with Excel even
in small files. When it comes to Excel and big files (XML over 4Gb), then ZIP64
must be declared in the
bosofelipe commented on pull request #154:
URL: https://github.com/apache/poi/pull/154#issuecomment-636839433
@rzymek I tested with Libre Office... now i tested with MS Excel and the
problem was solved, Is a limitation of Libre office, with you told us?
Tks a lot!
asfgit closed pull request #193:
URL: https://github.com/apache/poi/pull/193
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on pull request #193:
URL: https://github.com/apache/poi/pull/193#issuecomment-713040936
Merged with
https://github.com/apache/poi/commit/dd9f132c232c24d939adba5065280fbba0e4ed42 -
thanks
This is an
Sayi opened a new pull request #188:
URL: https://github.com/apache/poi/pull/188
Use the existing CTExternalData element, so that we can keep the settings
such as autoUpdate in CTExternalData.
This is an automated message
asfgit closed pull request #189:
URL: https://github.com/apache/poi/pull/189
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on pull request #187:
URL: https://github.com/apache/poi/pull/187#issuecomment-672089871
thanks - merged with
https://github.com/apache/poi/commit/a8d90aba91ba8788c784e644a6cff2acbcaba4f1
This is an
Nick-Rivera-Meredith opened a new pull request #190:
URL: https://github.com/apache/poi/pull/190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pjfanning commented on pull request #189:
URL: https://github.com/apache/poi/pull/189#issuecomment-672689340
Thanks - merged with
https://github.com/apache/poi/commit/e86ba86f2dbc6c48b34a24bed3cbb2ba2e087648
This is an
asfgit closed pull request #190:
URL: https://github.com/apache/poi/pull/190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on pull request #190:
URL: https://github.com/apache/poi/pull/190#issuecomment-672689592
Thanks - merged with
https://github.com/apache/poi/commit/252a4eccc949445bb20c5dfc4667bc0f823f40f6
This is an
asfgit closed pull request #187:
URL: https://github.com/apache/poi/pull/187
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on pull request #188:
URL: https://github.com/apache/poi/pull/188#issuecomment-670780711
Looks good to me. I can merge (using svn) if you haven't got svn write
access yet.
This is an automated message
Sayi closed pull request #188:
URL: https://github.com/apache/poi/pull/188
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Sayi commented on pull request #188:
URL: https://github.com/apache/poi/pull/188#issuecomment-671021752
r1880707
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
leowebb opened a new pull request #187:
URL: https://github.com/apache/poi/pull/187
Hello,
I am not entirely sure if this is a bug, but as I was writing some code to
produce a list literal for data validations, I was running into an issue where
when I was producing an xlsx, I was
leowebb commented on pull request #187:
URL: https://github.com/apache/poi/pull/187#issuecomment-667723572
Hello! Thank you for the response.
I've added a sample file that is won't open in Excel, and a corresponding
test that throws an exception from the DataValidation when reading
centic9 commented on pull request #187:
URL: https://github.com/apache/poi/pull/187#issuecomment-667637358
Thanks for the contribution.
Any chance you can add a sample file to the test-data/spreadsheet directory
and a unit-test which verifies the added length-validation?
RemboL opened a new pull request #189:
URL: https://github.com/apache/poi/pull/189
Recently I implemented DateValue function that would parse dates in
different formats.
Since then, I noticed that there are other functions (YEARFRAC, in
particular) that use date parsing logic and
RemboL opened a new pull request #185:
URL: https://github.com/apache/poi/pull/185
I reported this before as
https://bz.apache.org/bugzilla/show_bug.cgi?id=64459 , basically issue is that
formula "IF(FALSE(), #VALUE!, 1)" when being used as array formula evaluates to
error value passed
pjfanning commented on pull request #185:
URL: https://github.com/apache/poi/pull/185#issuecomment-653174482
thanks - but can you add a test case that uses IfFunctionTestCaseData.xls ?
This is an automated message from the
RemboL commented on pull request #185:
URL: https://github.com/apache/poi/pull/185#issuecomment-653176081
https://github.com/apache/poi/blob/trunk/src/testcases/org/apache/poi/ss/formula/functions/TestIFFunctionFromSpreadsheet.java
already does that, I believe
pjfanning commented on pull request #185:
URL: https://github.com/apache/poi/pull/185#issuecomment-653213502
So you are replacing a pre-existing xls file and believe that the
pre-existing test is enough and that no extra assertions should be added to
this test?
pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-653629861
Renamed the classes in
https://github.com/apache/poi/commit/9f8b864c413bb3418e79a15172e7d2aac10ee12e
This is an
asfgit closed pull request #185:
URL: https://github.com/apache/poi/pull/185
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on pull request #185:
URL: https://github.com/apache/poi/pull/185#issuecomment-653628453
merged with
https://github.com/apache/poi/commit/be096396384f93c4d9027484a997509edf240708 -
thanks
This is an
Sayi opened a new pull request #186:
URL: https://github.com/apache/poi/pull/186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
asfgit closed pull request #186:
URL: https://github.com/apache/poi/pull/186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on pull request #186:
URL: https://github.com/apache/poi/pull/186#issuecomment-658275049
merged - thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on
RemboL edited a comment on pull request #185:
URL: https://github.com/apache/poi/pull/185#issuecomment-653321876
Yes.
This test is built so that it scans the excel file and adds new data row to
`@Parameterized` test defined in the base class per properly defined row in
excel. I've
RemboL commented on pull request #185:
URL: https://github.com/apache/poi/pull/185#issuecomment-653321876
Yes.
This test is built so that it scans the excel file and adds new data row to
@Parameterized test defined in the base class per properly defined row in
excel. I've added 4
mobreza opened a new pull request #184:
URL: https://github.com/apache/poi/pull/184
Rebased MR !141 on current master.
https://github.com/apache/poi/pull/141
This is an automated message from the Apache Git Service.
mobreza commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-649980596
@pjfanning This is to resume discussions and figure out if this code is
still useful since it's a year since the previous MR.
pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650121638
* `protected ISheetInjector createSheetInjector(InputStream xis) throws
IOException` is now correct
* I don't like the SuperSXSSF names, can we use EmittingSXSSF instead?
pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650119909
This code does not compile
This is an automated message from the Apache Git Service.
To respond to the message,
mobreza commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650908411
Migration from 3.17 (!) to 5.0.0-SNAPSHOT required renaming the
`SuperSXSSF*` to `EmittingSXSSF*` and some minor updates:
mobreza commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650743781
I'll check our existing code that uses this extension. What's the URL of the
maven SNAPSHOTS repository?
This is an
pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650744641
https://github.com/mobreza/poi/pull/1#issuecomment-650729604 provides an
example of how to use code (except the `SuperSXXSF` classes are renamed as
`EmittingSXXSF`
pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650756831
@mobreza I'm struggling to think of a good name for these classes.
SuperSXSSF was too vague but EmittingSXSSF is not right either. How about
DeferredSXSSF or LazySXSSF because of
mobreza commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-65075
Thanks, will have a look. I was expecting it at
https://repository.apache.org/content/groups/snapshots.
This is an
pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650744038
when https://builds.apache.org/view/P/view/POI/job/POI-DSL-1.8/1011/
completes - check
https://builds.apache.org/view/P/view/POI/job/POI-DSL-1.8/lastSuccessfulBuild/artifact/
pjfanning commented on pull request #184:
URL: https://github.com/apache/poi/pull/184#issuecomment-650742399
Thanks. Merged with
https://github.com/apache/poi/commit/f06c45421b1904f196f6aa4c2f99989a1f3185c6
We can treat this as beta for now, as I expect that we might need to add
asfgit closed pull request #184:
URL: https://github.com/apache/poi/pull/184
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mobreza commented on pull request #141:
URL: https://github.com/apache/poi/pull/141#issuecomment-649509233
Is there a way to reopen this PR?
This is an automated message from the Apache Git Service.
To respond to the
pjfanning commented on pull request #141:
URL: https://github.com/apache/poi/pull/141#issuecomment-649512790
@mobreza could you create a new MR from your branch?
This is an automated message from the Apache Git Service.
To
jandhollander commented on pull request #141:
URL: https://github.com/apache/poi/pull/141#issuecomment-649478994
@mobreza @pjfanning Is this something that could make it in, in the future?
We have a web application that uses SXSSF and would like the download of a
workbook to start
pjfanning commented on pull request #141:
URL: https://github.com/apache/poi/pull/141#issuecomment-649492993
This PR has been corrupted but if someone wants to create a new one, we
might consider it.
This is an automated
netmackan commented on pull request #182:
URL: https://github.com/apache/poi/pull/182#issuecomment-641781168
Hi @pjfanning,
Unfortunately, I do not own the test file so I can not share it. But I will
try to create a new one and get back as soon as I get time.
The file
asfgit closed pull request #182:
URL: https://github.com/apache/poi/pull/182
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #181:
URL: https://github.com/apache/poi/pull/181
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pjfanning commented on pull request #182:
URL: https://github.com/apache/poi/pull/182#issuecomment-641356071
@netmackan is there any extra context you can give us on this issue? The
code has probably never supported the scenario you seem to want to fix.
asfgit closed pull request #191:
URL: https://github.com/apache/poi/pull/191
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
RemboL opened a new pull request #191:
URL: https://github.com/apache/poi/pull/191
I had an array formula that referenced range which contained blank cells -
this caused exception, because method evaluateFormulaCellValue did not expect
BlankEval. Interestingly enough, this does not happen
robmv commented on pull request #198:
URL: https://github.com/apache/poi/pull/198#issuecomment-734036119
> If you get that warning
Just for clarifying, I don't get that error, in my machine the build is ok.
The Travis CI display that error, see my previous message about the Travis
pjfanning commented on a change in pull request #203:
URL: https://github.com/apache/poi/pull/203#discussion_r537045639
##
File path: src/java/org/apache/poi/common/usermodel/fonts/FontGroup.java
##
@@ -42,10 +44,14 @@ Licensed to the Apache Software Foundation (ASF) under one
pjfanning commented on a change in pull request #203:
URL: https://github.com/apache/poi/pull/203#discussion_r537047512
##
File path: src/java/org/apache/poi/common/usermodel/fonts/FontGroup.java
##
@@ -42,10 +44,14 @@ Licensed to the Apache Software Foundation (ASF) under one
MariusVolkhart commented on a change in pull request #203:
URL: https://github.com/apache/poi/pull/203#discussion_r536930760
##
File path: src/java/org/apache/poi/common/usermodel/fonts/package-info.java
##
@@ -0,0 +1,4 @@
+@NonNullApi
Review comment:
Marks every
pjfanning commented on pull request #202:
URL: https://github.com/apache/poi/pull/202#issuecomment-739585879
We have a policy of deprecating code before removing it. I don't think this
change is a good idea, even if the code is not really used.
sigemiz opened a new pull request #204:
URL: https://github.com/apache/poi/pull/204
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
MariusVolkhart closed pull request #202:
URL: https://github.com/apache/poi/pull/202
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pjfanning commented on pull request #204:
URL: https://github.com/apache/poi/pull/204#issuecomment-739779623
Thanks. Merged using
https://github.com/apache/poi/commit/29642eedb1dd488d5da40caaef418c7274f7b769
This is an
asfgit closed pull request #204:
URL: https://github.com/apache/poi/pull/204
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
MariusVolkhart opened a new pull request #202:
URL: https://github.com/apache/poi/pull/202
This method is never called by the POI code, and none of the built-in
implementations have meaningful implementation of the method.
PackagePropertiesPart#flush() was called in one location,
MariusVolkhart opened a new pull request #203:
URL: https://github.com/apache/poi/pull/203
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
MariusVolkhart commented on a change in pull request #203:
URL: https://github.com/apache/poi/pull/203#discussion_r536930125
##
File path: src/java/org/apache/poi/common/usermodel/fonts/FontGroup.java
##
@@ -42,10 +44,14 @@ Licensed to the Apache Software Foundation (ASF)
Alain-Bearez opened a new pull request #201:
URL: https://github.com/apache/poi/pull/201
I did not have time to test and I will not have time to follow up in the
next days. :(
This is an automated message from the Apache
asfgit closed pull request #200:
URL: https://github.com/apache/poi/pull/200
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
MariusVolkhart commented on a change in pull request #205:
URL: https://github.com/apache/poi/pull/205#discussion_r538863717
##
File path: src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFPictureData.java
##
@@ -146,7 +146,7 @@ public int getPictureType() {
return 0;
pjfanning commented on a change in pull request #205:
URL: https://github.com/apache/poi/pull/205#discussion_r538861083
##
File path: src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFPictureData.java
##
@@ -146,7 +146,7 @@ public int getPictureType() {
return 0;
MariusVolkhart opened a new pull request #205:
URL: https://github.com/apache/poi/pull/205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pjfanning commented on a change in pull request #206:
URL: https://github.com/apache/poi/pull/206#discussion_r540110069
##
File path: src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java
##
@@ -49,6 +48,7 @@ Licensed to the Apache Software Foundation (ASF) under one or
centic9 commented on pull request #201:
URL: https://github.com/apache/poi/pull/201#issuecomment-742572225
Test-build is running at
https://ci-builds.apache.org/job/POI/job/POI-DSL-Github-PullRequests/1/
This is an
ledstellar opened a new pull request #206:
URL: https://github.com/apache/poi/pull/206
The `SXSSFRow.getRowNum()` method is heavily used from various parts of the
code (in particular, from the cell evaluation method). Current implementation
of the method is using iterating over sheet rows
pjfanning edited a comment on pull request #207:
URL: https://github.com/apache/poi/pull/207#issuecomment-747676752
merged -
https://github.com/apache/poi/commit/e1b0bc6e1db18aa9fe0314ee77559c116742f3cd
This is an automated
pjfanning commented on pull request #207:
URL: https://github.com/apache/poi/pull/207#issuecomment-747676752
merged
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
1 - 100 of 1010 matches
Mail list logo
