[Bug 59734] Named range creation & lookup are linear in the number of ranges

2016-10-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

Dominik Stadler  changed:

   What|Removed |Added

 CC||cgh_c...@126.com

--- Comment #8 from Dominik Stadler  ---
*** Bug 59432 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59734] Named range creation & lookup are linear in the number of ranges

2016-09-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

--- Comment #7 from Javen O'Neal  ---
I added a note on the new dependency to the changelog for the 3.15 release and
I think it was mentioned in the release notes.[1]

I realized that this dependency addition should have been added to the release
notes after the release had been generated.[2]

[1] https://poi.apache.org/changes.html
[2] https://www.apache.org/dyn/closer.lua/poi/release/RELEASE-NOTES.txt

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59734] Named range creation & lookup are linear in the number of ranges

2016-09-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

--- Comment #6 from David North  ---
Simplicity/good developers don't write what they can steal.

Apologies for not noting the new dependency in the change log - I'll add a note
to our release process to make sure this is covered next time round.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59734] Named range creation & lookup are linear in the number of ranges

2016-09-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

--- Comment #5 from Greg Woolsey  ---
Where is the new dependency tracked for end users?  The change log?  For people
who don't use Maven or Ivy, it make come as a surprise that running their code
suddenly fails with a NoClassDefFound error (it just did for me, running a
local project with a local build of POI as a dependency).  I missed the commit
message, and had to go find this issue.

It doesn't seem that hard to implement using a normal HashMap, where the
desired name is upper or lower-cased between the user call and the map lookup.

It could be a Map> construct, where the outer Map is
by sheet name.  Global names would be mapped under the null entry.

Request sheet and table names would be looked up in the internal map by upper
or lower case cannonicalization (null aware for sheets), and no special tuple
or Commons Collections class would be needed.

Was simplicity the only reason for adding the package dependency?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59734] Named range creation & lookup are linear in the number of ranges

2016-07-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

--- Comment #4 from Javen O'Neal  ---
(In reply to David North from comment #3)
> Fixed in r174521
Correction: r1754521

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59734] Named range creation & lookup are linear in the number of ranges

2016-07-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

David North  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from David North  ---
Fixed in r174521

I opted to go with the commons collections route after all.

Existing index-based methods have been deprecated rather than removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59734] Named range creation & lookup are linear in the number of ranges

2016-06-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

--- Comment #2 from David North  ---
The rather old patch I'm working from hides that logic in the key, so I'll
probably go with that approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59734] Named range creation & lookup are linear in the number of ranges

2016-06-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59734

--- Comment #1 from Javen O'Neal  ---
Are you planning on writing a CaseInsensitiveMap or importing
https://commons.apache.org/proper/commons-collections/apidocs/org/apache/commons/collections4/map/CaseInsensitiveMap.html

I guess you would also need a (scope (global or sheet), named range name) tuple
class as your key, so you could hide the canonical case code there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org