Re: [Bug 66347] Add theme support to XWPF
Update shall we see. On Tue, 22 Nov, 2022, 1:46 am , wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=66347 > > --- Comment #5 from stephan.schwieb...@gmail.com --- > Sorry, I should have mentioned that in the previous comment. > > I was considering a test for modifying a theme, but the "XWPFTheme" > implementation is based on/aligned with the existing "XSLFTheme", which > doesn't > provide methods to modify the theme (besides going through > "getXmlObject()", > but that seems to be an internal method). > > I agree that it would be nice to be able to modify themes (for XSLF and > XWPF), > but it seemed to me like that's out of scope of this patch. Or do you think > differently? > > -- > You are receiving this mail because: > You are the assignee for the bug. > - > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org > For additional commands, e-mail: dev-h...@poi.apache.org > >
[Bug 66347] Add theme support to XWPF
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347 PJ Fanning changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 66347] Add theme support to XWPF
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347 --- Comment #5 from stephan.schwieb...@gmail.com --- Sorry, I should have mentioned that in the previous comment. I was considering a test for modifying a theme, but the "XWPFTheme" implementation is based on/aligned with the existing "XSLFTheme", which doesn't provide methods to modify the theme (besides going through "getXmlObject()", but that seems to be an internal method). I agree that it would be nice to be able to modify themes (for XSLF and XWPF), but it seemed to me like that's out of scope of this patch. Or do you think differently? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 66347] Add theme support to XWPF
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347 --- Comment #4 from PJ Fanning --- thanks - added with r1905374 Would it be possible to add a test where a new themes file is created in a docx file? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 66347] Add theme support to XWPF
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347 --- Comment #3 from stephan.schwieb...@gmail.com --- Created attachment 38435 --> https://bz.apache.org/bugzilla/attachment.cgi?id=38435=edit Basic test for XWPF themes Added a small test case to verify that a theme can be read. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 66347] Add theme support to XWPF
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347 --- Comment #2 from stephan.schwieb...@gmail.com --- Sure, I'll add some tests. Thanks! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
[Bug 66347] Add theme support to XWPF
https://bz.apache.org/bugzilla/show_bug.cgi?id=66347 --- Comment #1 from PJ Fanning --- thanks - added with r1905344 Would it be possible to add more test coverage - for regression purposes? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, e-mail: dev-h...@poi.apache.org
