Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-13 Thread Greg Woolsey
You will also need to trace through the code to find the methods and properties referenced indirectly, via reflection, unfortunately. To avoid code duplication, Vaadin chose to access some properties of chart types via reflection where the properties are common to all charts, but not defined in a

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-13 Thread Alain FAGOT BÉAREZ
Hi, @Greg: It was Brazilian Father’s Day today, so that I did not pick up tech lists from bed… but only after my daughter was sleeping. I cloned and searched through the following code base: https://github.com/WoozyG/spreadsheet/tree/ConditionalFormatting There I found no single reference to

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-13 Thread Greg Woolsey
Perhaps then it could be a parallel package to start, marked @Beta, independent of the two existing packages, aside from reusing things like enums perhaps. Projects could then explore it and use it as a common alternative. Once it is deemed stable enough to leave beat status we could then mark

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-12 Thread Alain FAGOT BÉAREZ
Hi, @pjfanning: In the current state, delegating to the XDDF from the legacy SS and XSSF implementation would not be feasible. Some constants were defined in Enum types and I don’t know how to “redirect” an Enum value to the new implementation of it. @Greg: I don’t know how deep your code

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Greg Woolsey
Vaadin7 requires Java 7, Vaadin 8 requires Java 8, so they are OK there. POI 3.17 already has breaking changes, so they have to put off incorporating my work until a larger release anyway, due to possible customer dependencies. Their next release will at least be using 3.16, so users like me can

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Andreas Beeker
> I would prefer this wait until 3.18, for purely selfish reasons, as we've > already released a beta for 3.17. The postponing is ok for me ... but afterwards you have the breaking changes anyways and the Vaadin guys (or you?) have to do the chart modifications twice ... or Vaadin might be

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Greg Woolsey
That might work for me, I'm not sure. Here's more background. There is much I want to do with the charts API already, but I haven't had time to see if this change goes in directions I'm wanting already. In particular I am constantly having to do variations on "instanceof" and type casting

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Javen O'Neal
That sounds like a good compromise. On Aug 11, 2017 04:18, "pj.fanning" wrote: > Would it be feasible to keep the existing classes and APIs and have them > delegate to the XDDF impl? > We could immediately deprecate any of these legacy APIs. > > > > -- > View this message

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread pj.fanning
Would it be feasible to keep the existing classes and APIs and have them delegate to the XDDF impl? We could immediately deprecate any of these legacy APIs. -- View this message in context:

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread Greg Woolsey
I'm all for standardizing the API between modules, however I have a large amount of code using the current XSSF API, in conjunction with another library, Vaadin-Spreadsheet. I'm in the process of submitting a large change request to that group , adding my features to their product. They already

Re: XDDF implementation shared between XSSFChart and XSLFChart

2017-08-11 Thread kiwiwings
Hi Alain, I have this issue on my todo-/watchlist, but I currently haven't got much time for POI. So if no-one else jumps in, you can ping me. We haven't yet started with the preparations for 3.17 final/4.0 - so I think, we'll get that one in before. Best wishes, Andi -- View this message in