[GitHub] incubator-ponymail issue #187: Bug: combine.sh uses GNU-only sed extension -...

2016-10-17 Thread asfgit
Github user asfgit closed the issue at:

https://github.com/apache/incubator-ponymail/issues/187


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-ponymail issue #187: Bug: combine.sh uses GNU-only sed extension -...

2016-10-15 Thread sebbASF
GitHub user sebbASF opened an issue:

https://github.com/apache/incubator-ponymail/issues/187

Bug: combine.sh uses GNU-only sed extension -s (--separate); it's not needed

The combine.sh script uses the following command line:

```
sed -s -e '/^\/\*/,/\*\//d' ${f} >> ../ponymail.js
```
However the '-s' flag is a GNU-sed extension which tells sed to consider 
files on the command line to be separate files rather than a single stream.
Since only a single file is passed to sed this flag is redundant, and 
should be dropped






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---