[GitHub] jai1 opened a new pull request #650: CPP Client: Fix BrokerConsumerStats function returning value instead of void

2017-08-07 Thread git
jai1 opened a new pull request #650: CPP Client: Fix BrokerConsumerStats function returning value instead of void URL: https://github.com/apache/incubator-pulsar/pull/650 ### Motivation My IDE was complaining that for certain functions `Return has value, in function returning void`.

[GitHub] jai1 commented on issue #630: Intermittent C++ test failure in LatchTest.testTimedWait

2017-08-07 Thread git
jai1 commented on issue #630: Intermittent C++ test failure in LatchTest.testTimedWait URL: https://github.com/apache/incubator-pulsar/issues/630#issuecomment-320592639 The test is correct, the only reason it would fail if:- a. #CPU threads < 4 b. IO operation (LOG_INFO) is taking to

[GitHub] maskit commented on a change in pull request #647: Add link checker and fix broken links

2017-08-07 Thread git
maskit commented on a change in pull request #647: Add link checker and fix broken links URL: https://github.com/apache/incubator-pulsar/pull/647#discussion_r131661068 ## File path: site/Makefile ## @@ -34,11 +34,14 @@ python_setup: sudo pip install pdoc pygments

[GitHub] merlimat closed pull request #648: Add instructions on compiling from source

2017-08-07 Thread git
merlimat closed pull request #648: Add instructions on compiling from source URL: https://github.com/apache/incubator-pulsar/pull/648 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] merlimat closed pull request #649: CPP Client: Fix for sendTimer_ being dereferenced after reset

2017-08-07 Thread git
merlimat closed pull request #649: CPP Client: Fix for sendTimer_ being dereferenced after reset URL: https://github.com/apache/incubator-pulsar/pull/649 This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat closed issue #618: Intermittent failures in C++ unit test BasicEndToEndTest.testResendViaSendCallback

2017-08-07 Thread git
merlimat closed issue #618: Intermittent failures in C++ unit test BasicEndToEndTest.testResendViaSendCallback URL: https://github.com/apache/incubator-pulsar/issues/618 This is an automated message from the Apache Git Serv

[GitHub] merlimat closed pull request #650: CPP Client: Fix BrokerConsumerStats function returning value instead of void

2017-08-07 Thread git
merlimat closed pull request #650: CPP Client: Fix BrokerConsumerStats function returning value instead of void URL: https://github.com/apache/incubator-pulsar/pull/650 This is an automated message from the Apache Git Servi

[GitHub] merlimat closed issue #644: Intermittent test failure on BrokerServiceThrottlingTest.testLookupThrottlingForClientByBroker

2017-08-07 Thread git
merlimat closed issue #644: Intermittent test failure on BrokerServiceThrottlingTest.testLookupThrottlingForClientByBroker URL: https://github.com/apache/incubator-pulsar/issues/644 This is an automated message from the Apa

[GitHub] merlimat closed pull request #645: Fix #644: BrokerServiceThrottlingTest.testLookupThrottlingForClientBy?

2017-08-07 Thread git
merlimat closed pull request #645: Fix #644: BrokerServiceThrottlingTest.testLookupThrottlingForClientBy? URL: https://github.com/apache/incubator-pulsar/pull/645 This is an automated message from the Apache Git Service. To

[GitHub] jai1 commented on issue #649: CPP Client: Fix for sendTimer_ being dereferenced after reset

2017-08-07 Thread git
jai1 commented on issue #649: CPP Client: Fix for sendTimer_ being dereferenced after reset URL: https://github.com/apache/incubator-pulsar/pull/649#issuecomment-320724572 ``` [ RUN ] BasicEndToEndTest.testResendViaSendCallback 2017-08-06 14:41:43.469 : INFO /Users/jai1/cpp/pul

[GitHub] merlimat commented on issue #641: Added missing copyright notice for Circe library

2017-08-07 Thread git
merlimat commented on issue #641: Added missing copyright notice for Circe library URL: https://github.com/apache/incubator-pulsar/pull/641#issuecomment-320729580 retest this please This is an automated message from the Apac

[GitHub] rdhabalia commented on a change in pull request #628: Docker image to build website in Jenkins

2017-08-07 Thread git
rdhabalia commented on a change in pull request #628: Docker image to build website in Jenkins URL: https://github.com/apache/incubator-pulsar/pull/628#discussion_r131730158 ## File path: site/api/python/index.html ## @@ -1125,653 +1058,649 @@ pulsar module Install from

[GitHub] rdhabalia commented on a change in pull request #628: Docker image to build website in Jenkins

2017-08-07 Thread git
rdhabalia commented on a change in pull request #628: Docker image to build website in Jenkins URL: https://github.com/apache/incubator-pulsar/pull/628#discussion_r131725977 ## File path: build/docker/Dockerfile ## @@ -31,3 +32,22 @@ RUN cd /usr/src/gtest && cmake . && mak

[GitHub] rdhabalia commented on a change in pull request #628: Docker image to build website in Jenkins

2017-08-07 Thread git
rdhabalia commented on a change in pull request #628: Docker image to build website in Jenkins URL: https://github.com/apache/incubator-pulsar/pull/628#discussion_r131729418 ## File path: site/api/python/index.html ## @@ -1125,653 +1058,649 @@ pulsar module Install from

[GitHub] rdhabalia commented on a change in pull request #628: Docker image to build website in Jenkins

2017-08-07 Thread git
rdhabalia commented on a change in pull request #628: Docker image to build website in Jenkins URL: https://github.com/apache/incubator-pulsar/pull/628#discussion_r131730022 ## File path: site/api/python/index.html ## @@ -1125,653 +1058,649 @@ pulsar module Install from

[GitHub] merlimat closed pull request #640: Removed required maven version from pom.xml

2017-08-07 Thread git
merlimat closed pull request #640: Removed required maven version from pom.xml URL: https://github.com/apache/incubator-pulsar/pull/640 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] merlimat commented on issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic

2017-08-07 Thread git
merlimat commented on issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic URL: https://github.com/apache/incubator-pulsar/issues/635#issuecomment-320756396 @rdhabalia Looks like it failed again in https://builds.apache.org/job/pulsar-master/org.apache.pul

[GitHub] rdhabalia commented on issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic

2017-08-07 Thread git
rdhabalia commented on issue #635: Intermittent test failures in AdminApiTest.testIncrementPartitionsOfTopic URL: https://github.com/apache/incubator-pulsar/issues/635#issuecomment-320760808 It seems it is not the same `assert-failure` but it failed with 500 due to `PulsarService` gets sh

[GitHub] merlimat commented on a change in pull request #628: Docker image to build website in Jenkins

2017-08-07 Thread git
merlimat commented on a change in pull request #628: Docker image to build website in Jenkins URL: https://github.com/apache/incubator-pulsar/pull/628#discussion_r131746188 ## File path: build/docker/Dockerfile ## @@ -31,3 +32,22 @@ RUN cd /usr/src/gtest && cmake . && make

[GitHub] merlimat commented on a change in pull request #628: Docker image to build website in Jenkins

2017-08-07 Thread git
merlimat commented on a change in pull request #628: Docker image to build website in Jenkins URL: https://github.com/apache/incubator-pulsar/pull/628#discussion_r131746296 ## File path: site/api/python/index.html ## @@ -1125,653 +1058,649 @@ pulsar module Install from P

[GitHub] merlimat commented on a change in pull request #628: Docker image to build website in Jenkins

2017-08-07 Thread git
merlimat commented on a change in pull request #628: Docker image to build website in Jenkins URL: https://github.com/apache/incubator-pulsar/pull/628#discussion_r131746188 ## File path: build/docker/Dockerfile ## @@ -31,3 +32,22 @@ RUN cd /usr/src/gtest && cmake . && make

[GitHub] lucperkins commented on a change in pull request #647: Add link checker and fix broken links

2017-08-07 Thread git
lucperkins commented on a change in pull request #647: Add link checker and fix broken links URL: https://github.com/apache/incubator-pulsar/pull/647#discussion_r131753611 ## File path: site/Makefile ## @@ -34,11 +34,14 @@ python_setup: sudo pip install pdoc pygmen

[GitHub] merlimat opened a new issue #651: Intermittent test failure PulsarClientToolTest.testInitialzation

2017-08-07 Thread git
merlimat opened a new issue #651: Intermittent test failure PulsarClientToolTest.testInitialzation URL: https://github.com/apache/incubator-pulsar/issues/651 As seen in https://builds.apache.org/job/pulsar-master/org.apache.pulsar$pulsar-client-tools/17/testReport/junit/org.apache.pulsar.c

[GitHub] merlimat closed pull request #643: Ensure the Python client works with Python-3

2017-08-07 Thread git
merlimat closed pull request #643: Ensure the Python client works with Python-3 URL: https://github.com/apache/incubator-pulsar/pull/643 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] merlimat closed pull request #628: Docker image to build website in Jenkins

2017-08-07 Thread git
merlimat closed pull request #628: Docker image to build website in Jenkins URL: https://github.com/apache/incubator-pulsar/pull/628 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] merlimat commented on issue #647: Add link checker and fix broken links

2017-08-07 Thread git
merlimat commented on issue #647: Add link checker and fix broken links URL: https://github.com/apache/incubator-pulsar/pull/647#issuecomment-320787849 @lucperkins there are 2 conflicting files which were actually deleted from the tree -

[GitHub] merlimat commented on issue #641: Added missing copyright notice for Circe library

2017-08-07 Thread git
merlimat commented on issue #641: Added missing copyright notice for Circe library URL: https://github.com/apache/incubator-pulsar/pull/641#issuecomment-320729580 retest this please This is an automated message from the Apac

[GitHub] merlimat commented on issue #641: Added missing copyright notice for Circe library

2017-08-07 Thread git
merlimat commented on issue #641: Added missing copyright notice for Circe library URL: https://github.com/apache/incubator-pulsar/pull/641#issuecomment-320797995 retest this please This is an automated message f

[GitHub] merlimat commented on issue #632: Splitted Admin API reference into multiple pages

2017-08-07 Thread git
merlimat commented on issue #632: Splitted Admin API reference into multiple pages URL: https://github.com/apache/incubator-pulsar/pull/632#issuecomment-320798994 @rdhabalia Can you take a look at this one too? This is the change we had talked on the slack discussion

[GitHub] merlimat opened a new pull request #652: Build website using the current user rather than root

2017-08-07 Thread git
merlimat opened a new pull request #652: Build website using the current user rather than root URL: https://github.com/apache/incubator-pulsar/pull/652 ### Motivation Trying to publish the website after the build on Jenkins, it appears that there are some permissions related issue r

[GitHub] merlimat opened a new pull request #653: Removed duplicated ASF headers from BookKeeper

2017-08-07 Thread git
merlimat opened a new pull request #653: Removed duplicated ASF headers from BookKeeper URL: https://github.com/apache/incubator-pulsar/pull/653 ### Motivation As reported on the incubator mailing list, there are few files that were imported from BookKeeper that have double license

[GitHub] merlimat opened a new pull request #654: Do not delete inactive topics if they have retention policy

2017-08-07 Thread git
merlimat opened a new pull request #654: Do not delete inactive topics if they have retention policy URL: https://github.com/apache/incubator-pulsar/pull/654 ### Motivation When a retention policy is set, an "inactive" topic should not be garbage collected until the retention period

[GitHub] merlimat opened a new issue #655: Documentation for "Set retention policy" has

2017-08-07 Thread git
merlimat opened a new issue #655: Documentation for "Set retention policy" has URL: https://github.com/apache/incubator-pulsar/issues/655 In the [Message retention and expiry ](https://pulsar.incubator.apache.org/docs/latest/advanced/RetentionExpiry/) page, we are explaining that `set-r

[GitHub] merlimat closed pull request #652: Build website using the current user rather than root

2017-08-07 Thread git
merlimat closed pull request #652: Build website using the current user rather than root URL: https://github.com/apache/incubator-pulsar/pull/652 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] rdhabalia commented on issue #634: PIP-3 : Introduce message-dispatch rate limiting

2017-08-07 Thread git
rdhabalia commented on issue #634: PIP-3 : Introduce message-dispatch rate limiting URL: https://github.com/apache/incubator-pulsar/pull/634#issuecomment-320817486 @merlimat as per your suggestion in #402, I have added rate-limiting by msg-rate and byte-rate. I will update the doc once you

[GitHub] lucperkins opened a new pull request #656: Issue #655: fix misleading info on retention policies

2017-08-07 Thread git
lucperkins opened a new pull request #656: Issue #655: fix misleading info on retention policies URL: https://github.com/apache/incubator-pulsar/pull/656 ### Motivation This PR addresses issue #655. ### Modifications Misleading explanations and code samples have been re

[GitHub] rdhabalia commented on a change in pull request #632: Splitted Admin API reference into multiple pages

2017-08-07 Thread git
rdhabalia commented on a change in pull request #632: Splitted Admin API reference into multiple pages URL: https://github.com/apache/incubator-pulsar/pull/632#discussion_r131799120 ## File path: site/docs/latest/admin-api/permissions.md ## @@ -1,155 +1,6 @@ -Pulsar {% pop

[GitHub] rdhabalia commented on a change in pull request #632: Splitted Admin API reference into multiple pages

2017-08-07 Thread git
rdhabalia commented on a change in pull request #632: Splitted Admin API reference into multiple pages URL: https://github.com/apache/incubator-pulsar/pull/632#discussion_r131798719 ## File path: site/docs/latest/admin-api/permissions.md ## @@ -1,155 +1,6 @@ -Pulsar {% pop

[GitHub] rdhabalia commented on a change in pull request #632: Splitted Admin API reference into multiple pages

2017-08-07 Thread git
rdhabalia commented on a change in pull request #632: Splitted Admin API reference into multiple pages URL: https://github.com/apache/incubator-pulsar/pull/632#discussion_r131798565 ## File path: site/docs/latest/admin-api/partitioned-topics.md ## @@ -1,9 +1,15 @@ +--- +ti