[GitHub] rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview
rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview URL: https://github.com/apache/incubator-pulsar/pull/664#discussion_r132262248 ## File path: site/_includes/explanations/partitioned-topic-admin.md ## @@ -1,4 +1,4 @@ -You can use Pulsar's [admin API](../../admin/AdminInterface) to create and manage partitioned topics. +You can use Pulsar's [admin API](../../admin-api/overview) to create and manage partitioned topics. Review comment: yes, right we can keep overview-link for for admin-api text. may be we can add link on `partitioned topics` as `partitioned-topics`. it's not necessary but it might be useful for user. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview
rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview URL: https://github.com/apache/incubator-pulsar/pull/664#discussion_r132251410 ## File path: site/_includes/explanations/partitioned-topic-admin.md ## @@ -1,4 +1,4 @@ -You can use Pulsar's [admin API](../../admin/AdminInterface) to create and manage partitioned topics. +You can use Pulsar's [admin API](../../admin-api/overview) to create and manage partitioned topics. Review comment: instead of overview -> `partitioned-topics`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview
rdhabalia commented on a change in pull request #664: Fixed broken links to
admin-api/overview
URL: https://github.com/apache/incubator-pulsar/pull/664#discussion_r132251530
##
File path: site/_includes/explanations/partitioned-topics.md
##
@@ -14,7 +14,7 @@ Decisions about routing and subscription modes can be made
separately in most ca
There is no difference between partitioned topics and normal topics in terms
of how subscription modes work, as partitioning only determines what happens
between when a message is published by a {% popover producer %} and processed
and {% popover acknowledged %} by a {% popover consumer %}.
-Partitioned topics need to be explicitly created via the [admin
API](../../admin/AdminInterface). The number of partitions can be specified
when creating the topic.
+Partitioned topics need to be explicitly created via the [admin
API](../../admin-api/overview). The number of partitions can be specified when
creating the topic.
Review comment:
instead of overview -> `non-persistent-topics`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview
rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview URL: https://github.com/apache/incubator-pulsar/pull/664#discussion_r132251712 ## File path: site/docs/latest/admin-api/properties.md ## @@ -2,7 +2,7 @@ title: Managing properties --- -Properties, like namespaces, can be managed using the [admin API](../../admin/AdminInterface). There are currently two configurable aspects of properties: +Properties, like namespaces, can be managed using the [admin API](../../admin-api/overview). There are currently two configurable aspects of properties: Review comment: `properties`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview
rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview URL: https://github.com/apache/incubator-pulsar/pull/664#discussion_r132251584 ## File path: site/docs/latest/admin-api/partitioned-topics.md ## @@ -2,7 +2,7 @@ title: Managing partitioned topics --- -You can use Pulsar's [admin API](../../admin/AdminInterface) to create and manage partitioned topics. +You can use Pulsar's [admin API](../../admin-api/overview) to create and manage partitioned topics. Review comment: same ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview
rdhabalia commented on a change in pull request #664: Fixed broken links to admin-api/overview URL: https://github.com/apache/incubator-pulsar/pull/664#discussion_r132251410 ## File path: site/_includes/explanations/partitioned-topic-admin.md ## @@ -1,4 +1,4 @@ -You can use Pulsar's [admin API](../../admin/AdminInterface) to create and manage partitioned topics. +You can use Pulsar's [admin API](../../admin-api/overview) to create and manage partitioned topics. Review comment: instead of overview -> `non-persistent-topics`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
