RE: [VOTE] Pulsar 1.22.0-incubating Release Candidate 1

2018-02-20 Thread Masahiro Sakamoto
> Sent: Tuesday, February 20, 2018 10:59 AM > To: dev@pulsar.incubator.apache.org > Subject: RE: [VOTE] Pulsar 1.22.0-incubating Release Candidate 1 > > Hi Jai, > > I have found an issue related to the feature that has been added in the > following pull request. > https://

RE: [VOTE] Pulsar 1.22.0-incubating Release Candidate 1

2018-02-19 Thread Masahiro Sakamoto
, Masahiro -- Masahiro Sakamoto Yahoo Japan Corp. E-mail: massa...@yahoo-corp.jp -- > -Original Message- > From: Jai Asher [mailto:jai.ashe...@gmail.com] > Sent: Tuesday, February 20, 2018 5:01 AM > To: dev@pulsar.incubator.apache.org > Subject: Re: [VOTE] Pulsar 1.22.0-inc

Re: [VOTE] Pulsar 1.22.0-incubating Release Candidate 1

2018-02-19 Thread Jai Asher
Thanks, Matteo :-) I will have another release candidate ready by the End of Day. On Mon, Feb 19, 2018 at 10:49 AM, Matteo Merli wrote: > Jai, > > I have merged the mentioned fix in master & 1.22 branch. > > On Mon, Feb 19, 2018 at 9:53 AM Dave Fisher wrote: > > > Hi - > > > > Given this commen

Re: [VOTE] Pulsar 1.22.0-incubating Release Candidate 1

2018-02-19 Thread Matteo Merli
Jai, I have merged the mentioned fix in master & 1.22 branch. On Mon, Feb 19, 2018 at 9:53 AM Dave Fisher wrote: > Hi - > > Given this comment I’ll wait until tomorrow to review the release. > > Regards, > Dave > > > On Feb 19, 2018, at 9:27 AM, Matteo Merli wrote: > > > > Jai, the artifacts l

Re: [VOTE] Pulsar 1.22.0-incubating Release Candidate 1

2018-02-19 Thread Dave Fisher
Hi - Given this comment I’ll wait until tomorrow to review the release. Regards, Dave > On Feb 19, 2018, at 9:27 AM, Matteo Merli wrote: > > Jai, the artifacts look good. > > Though I think we should squeeze in the fix for > https://github.com/apache/incubator-pulsar/pull/1251 > That makes pa

Re: [VOTE] Pulsar 1.22.0-incubating Release Candidate 1

2018-02-19 Thread Matteo Merli
Jai, the artifacts look good. Though I think we should squeeze in the fix for https://github.com/apache/incubator-pulsar/pull/1251 That makes partitions unusable on non-persistent topics. Matteo On Sat, Feb 17, 2018 at 1:13 AM Jai Asher wrote: > This is the second release candidate for Apache