[jira] [Commented] (PROTON-1998) [Proton-J] Add SASL protocol trace

2019-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758163#comment-16758163 ] ASF GitHub Bot commented on PROTON-1998: gemmellr commented on issue #30: PROTON-1998: Add SASL

[GitHub] jdanekrh opened a new pull request #174: NO-JIRA: [c] Fix typo in sizeof (wrong, bigger, type used)

2019-02-01 Thread GitBox
jdanekrh opened a new pull request #174: NO-JIRA: [c] Fix typo in sizeof (wrong, bigger, type used) URL: https://github.com/apache/qpid-proton/pull/174 This is a clang-analyzer warning, and it does look suspicious. Consider this more like a suspected bug report (diff makes it easier to

[GitHub] gemmellr commented on issue #30: PROTON-1998: Add SASL protocol trace

2019-02-01 Thread GitBox
gemmellr commented on issue #30: PROTON-1998: Add SASL protocol trace URL: https://github.com/apache/qpid-proton-j/pull/30#issuecomment-459672396 Though I may have at the outset, I don't think I'd go this way with adjustment of TransportFrame at this point. Given that the

[jira] [Commented] (PROTON-1998) [Proton-J] Add SASL protocol trace

2019-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758390#comment-16758390 ] ASF GitHub Bot commented on PROTON-1998: k-wall commented on issue #30: PROTON-1998: Add SASL

[GitHub] k-wall commented on issue #30: PROTON-1998: Add SASL protocol trace

2019-02-01 Thread GitBox
k-wall commented on issue #30: PROTON-1998: Add SASL protocol trace URL: https://github.com/apache/qpid-proton-j/pull/30#issuecomment-459752253 Thanks for the feedback, I'll try the suggestions. This is an automated message

[jira] [Commented] (PROTON-1999) [c] Crash in pn_connection_finalize

2019-02-01 Thread Jeremy (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758319#comment-16758319 ] Jeremy commented on PROTON-1999: Hello [~ODelbeke] and [~cliffjansen], [~ODelbeke]: Before going into

[jira] [Resolved] (PROTON-1917) [proton-c] the c++ proton consumer with retry should continue to retry if virtual host not active

2019-02-01 Thread Jeremy (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy resolved PROTON-1917. Resolution: Fixed > [proton-c] the c++ proton consumer with retry should continue to retry if > virtual

[jira] [Comment Edited] (PROTON-1999) [c] Crash in pn_connection_finalize

2019-02-01 Thread Jeremy (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758319#comment-16758319 ] Jeremy edited comment on PROTON-1999 at 2/1/19 1:55 PM: Hello [~ODelbeke] and

[jira] [Comment Edited] (PROTON-1999) [c] Crash in pn_connection_finalize

2019-02-01 Thread Jeremy (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758319#comment-16758319 ] Jeremy edited comment on PROTON-1999 at 2/1/19 1:59 PM: Hello [~ODelbeke] and

[jira] [Commented] (PROTON-1998) [Proton-J] Add SASL protocol trace

2019-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758439#comment-16758439 ] ASF GitHub Bot commented on PROTON-1998: gemmellr commented on issue #30: PROTON-1998: Add SASL

[GitHub] gemmellr commented on issue #30: PROTON-1998: Add SASL protocol trace

2019-02-01 Thread GitBox
gemmellr commented on issue #30: PROTON-1998: Add SASL protocol trace URL: https://github.com/apache/qpid-proton-j/pull/30#issuecomment-459771487 Yeah, its a fair point, and I have actually held off doing this in the past precisely because I think so (and also because it couldn't be added

[GitHub] rgodfrey commented on issue #30: PROTON-1998: Add SASL protocol trace

2019-02-01 Thread GitBox
rgodfrey commented on issue #30: PROTON-1998: Add SASL protocol trace URL: https://github.com/apache/qpid-proton-j/pull/30#issuecomment-459784499 Personally I see it as a (longstanding) bug that it doesn't do the same thing as proton-c and surprising/(very very) annoying that SASL is

[jira] [Commented] (PROTON-1998) [Proton-J] Add SASL protocol trace

2019-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758484#comment-16758484 ] ASF GitHub Bot commented on PROTON-1998: rgodfrey commented on issue #30: PROTON-1998: Add SASL

[jira] [Commented] (PROTON-1998) [Proton-J] Add SASL protocol trace

2019-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758427#comment-16758427 ] ASF GitHub Bot commented on PROTON-1998: tabish121 commented on issue #30: PROTON-1998: Add SASL

[GitHub] tabish121 commented on issue #30: PROTON-1998: Add SASL protocol trace

2019-02-01 Thread GitBox
tabish121 commented on issue #30: PROTON-1998: Add SASL protocol trace URL: https://github.com/apache/qpid-proton-j/pull/30#issuecomment-459768206 I'd tend to agree with @gemmellr that the change should be more targeted and not alter the TransportFrame at this point. Also I'm wondering is

[jira] [Commented] (PROTON-1998) [Proton-J] Add SASL protocol trace

2019-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758490#comment-16758490 ] ASF GitHub Bot commented on PROTON-1998: k-wall commented on issue #30: PROTON-1998: Add SASL

[GitHub] k-wall commented on issue #30: PROTON-1998: Add SASL protocol trace

2019-02-01 Thread GitBox
k-wall commented on issue #30: PROTON-1998: Add SASL protocol trace URL: https://github.com/apache/qpid-proton-j/pull/30#issuecomment-459792031 I'd personally prefer the consistency with the proton implementation, that is, produce the complete complete frame trace including SASL.

[jira] [Resolved] (DISPATCH-1260) Closing traffic animation doesn't always work

2019-02-01 Thread Ernest Allen (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernest Allen resolved DISPATCH-1260. Resolution: Fixed > Closing traffic animation doesn't always work >

[jira] [Created] (DISPATCH-1260) Closing traffic animation doesn't always work

2019-02-01 Thread Ernest Allen (JIRA)
Ernest Allen created DISPATCH-1260: -- Summary: Closing traffic animation doesn't always work Key: DISPATCH-1260 URL: https://issues.apache.org/jira/browse/DISPATCH-1260 Project: Qpid Dispatch

[jira] [Commented] (DISPATCH-1261) Builds failing on CentOS7

2019-02-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758562#comment-16758562 ] ASF subversion and git services commented on DISPATCH-1261: --- Commit

[jira] [Commented] (DISPATCH-1260) Closing traffic animation doesn't always work

2019-02-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758540#comment-16758540 ] ASF subversion and git services commented on DISPATCH-1260: --- Commit

[jira] [Created] (DISPATCH-1261) Builds failing on CentOS7

2019-02-01 Thread Ernest Allen (JIRA)
Ernest Allen created DISPATCH-1261: -- Summary: Builds failing on CentOS7 Key: DISPATCH-1261 URL: https://issues.apache.org/jira/browse/DISPATCH-1261 Project: Qpid Dispatch Issue Type: Bug