[GitHub] jdanekrh opened a new pull request #178: NO-JIRA: [c] Fix two warnings from clang-analyzer

2019-02-20 Thread GitBox
jdanekrh opened a new pull request #178: NO-JIRA: [c] Fix two warnings from clang-analyzer URL: https://github.com/apache/qpid-proton/pull/178 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jdanekrh commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr

2019-02-20 Thread GitBox
jdanekrh commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr URL: https://github.com/apache/qpid-proton/pull/176#issuecomment-465889752 > Also doing strncat(host); strncat(':'); strncat(port) is wrong. The output buffer should start with

[GitHub] astitcher commented on issue #175: src/ssl/openssl: add libressl compatibility

2019-02-20 Thread GitBox
astitcher commented on issue #175: src/ssl/openssl: add libressl compatibility URL: https://github.com/apache/qpid-proton/pull/175#issuecomment-465671591 This change is missing the definition of default_seclevel at line 78 - this is only used when SSL_CTX_get_security_level and

[GitHub] astitcher merged pull request #177: NO-JIRA: [c] Fix "Logically dead code" warning caused by excessive NULL checks

2019-02-20 Thread GitBox
astitcher merged pull request #177: NO-JIRA: [c] Fix "Logically dead code" warning caused by excessive NULL checks URL: https://github.com/apache/qpid-proton/pull/177 This is an automated message from the Apache Git

[GitHub] astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr

2019-02-20 Thread GitBox
astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr URL: https://github.com/apache/qpid-proton/pull/176#issuecomment-465636973 I don't think this is the correct fix. There is no problem using strncat that requires inventing a new (and

[jira] [Created] (DISPATCH-1269) Improve error handling for remote_sasl.c plugin

2019-02-20 Thread Gordon Sim (JIRA)
Gordon Sim created DISPATCH-1269: Summary: Improve error handling for remote_sasl.c plugin Key: DISPATCH-1269 URL: https://issues.apache.org/jira/browse/DISPATCH-1269 Project: Qpid Dispatch

[jira] [Commented] (PROTON-1936) Support cross compiling to Windows from Linux

2019-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773225#comment-16773225 ] ASF GitHub Bot commented on PROTON-1936: astitcher commented on issue #156: PROTON-1936: lower

[GitHub] astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs

2019-02-20 Thread GitBox
astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465677673 You don't explain what problem you are solving with these changes. Please give more details about why you need to - 1. change

[GitHub] astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr

2019-02-20 Thread GitBox
astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr URL: https://github.com/apache/qpid-proton/pull/176#issuecomment-465646443 Thinking more... > I don't think this is the correct fix. There is no problem using strncat that

[GitHub] astitcher merged pull request #174: NO-JIRA: [c] Fix typo in sizeof (wrong, bigger, type used)

2019-02-20 Thread GitBox
astitcher merged pull request #174: NO-JIRA: [c] Fix typo in sizeof (wrong, bigger, type used) URL: https://github.com/apache/qpid-proton/pull/174 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (DISPATCH-1269) Improve error handling for remote_sasl.c plugin

2019-02-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/DISPATCH-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773246#comment-16773246 ] ASF subversion and git services commented on DISPATCH-1269: --- Commit

[jira] [Commented] (PROTON-1936) Support cross compiling to Windows from Linux

2019-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773298#comment-16773298 ] ASF GitHub Bot commented on PROTON-1936: marcelmeulemans commented on issue #156: PROTON-1936:

[GitHub] marcelmeulemans edited a comment on issue #156: PROTON-1936: lower case include and updated ifdefs

2019-02-20 Thread GitBox
marcelmeulemans edited a comment on issue #156: PROTON-1936: lower case include and updated ifdefs URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465714280 Sorry, you are right, I could have been a bit more verbose in explaining the issue being tackled here (also in the

[jira] [Commented] (PROTON-1936) Support cross compiling to Windows from Linux

2019-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773297#comment-16773297 ] ASF GitHub Bot commented on PROTON-1936: marcelmeulemans commented on issue #156: PROTON-1936:

[GitHub] marcelmeulemans commented on issue #156: PROTON-1936: lower case include and updated ifdefs

2019-02-20 Thread GitBox
marcelmeulemans commented on issue #156: PROTON-1936: lower case include and updated ifdefs URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465714280 Sorry, you are right, I could have been a bit more verbose in explaining the issue being tackled here (also in the Jira

[GitHub] astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr

2019-02-20 Thread GitBox
astitcher commented on issue #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr URL: https://github.com/apache/qpid-proton/pull/176#issuecomment-465784333 How about something like (compiles and passes tests with valgrind, but not tested with sanitisers or

[GitHub] astitcher commented on issue #168: PROTON-1887: [c] Convert C tests to use Catch2 harness.

2019-02-20 Thread GitBox
astitcher commented on issue #168: PROTON-1887: [c] Convert C tests to use Catch2 harness. URL: https://github.com/apache/qpid-proton/pull/168#issuecomment-465785001 This has been merged This is an automated message from the

[GitHub] astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs

2019-02-20 Thread GitBox
astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465778368 > > 1. **File name casing**. The windows API is not really very consistent when is comes to the casing of file names (can

[jira] [Commented] (PROTON-1936) Support cross compiling to Windows from Linux

2019-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773442#comment-16773442 ] ASF GitHub Bot commented on PROTON-1936: astitcher commented on issue #156: PROTON-1936: lower

[GitHub] astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs

2019-02-20 Thread GitBox
astitcher commented on issue #156: PROTON-1936: lower case include and updated ifdefs URL: https://github.com/apache/qpid-proton/pull/156#issuecomment-465779208 Having said all that on the whole if the Windows CI build works and the Linux CI build is unaffected I'm ok with merging this

[jira] [Commented] (PROTON-1936) Support cross compiling to Windows from Linux

2019-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773444#comment-16773444 ] ASF GitHub Bot commented on PROTON-1936: astitcher commented on issue #156: PROTON-1936: lower

[jira] [Commented] (PROTON-1887) [c] Introduce external C test harness for C tests

2019-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773467#comment-16773467 ] ASF GitHub Bot commented on PROTON-1887: astitcher commented on pull request #168: PROTON-1887:

[GitHub] astitcher closed pull request #168: PROTON-1887: [c] Convert C tests to use Catch2 harness.

2019-02-20 Thread GitBox
astitcher closed pull request #168: PROTON-1887: [c] Convert C tests to use Catch2 harness. URL: https://github.com/apache/qpid-proton/pull/168 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (PROTON-1887) [c] Introduce external C test harness for C tests

2019-02-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773466#comment-16773466 ] ASF GitHub Bot commented on PROTON-1887: astitcher commented on issue #168: PROTON-1887: [c]

[GitHub] jdanekrh opened a new pull request #177: NO-JIRA: [c] Fix "Logically dead code" warning caused by excessive NULL checks

2019-02-20 Thread GitBox
jdanekrh opened a new pull request #177: NO-JIRA: [c] Fix "Logically dead code" warning caused by excessive NULL checks URL: https://github.com/apache/qpid-proton/pull/177 dead_error_line: Execution cannot reach the expression 0UL inside this statement: *actual = (buf ? needed : 0...