[GitHub] asfgit closed pull request #431: DISPATCH-1231: correct credit handling in core client

2019-01-02 Thread GitBox
asfgit closed pull request #431: DISPATCH-1231: correct credit handling in core client URL: https://github.com/apache/qpid-dispatch/pull/431 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] codecov-io edited a comment on issue #431: DISPATCH-1231: correct credit handling in core client

2019-01-02 Thread GitBox
codecov-io edited a comment on issue #431: DISPATCH-1231: correct credit handling in core client URL: https://github.com/apache/qpid-dispatch/pull/431#issuecomment-449682539 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #434: DISPATCH-1232 - Improved mechanism to identify openssl version installed

2019-01-05 Thread GitBox
codecov-io edited a comment on issue #434: DISPATCH-1232 - Improved mechanism to identify openssl version installed URL: https://github.com/apache/qpid-dispatch/pull/434#issuecomment-451687930 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/434?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #434: DISPATCH-1232 - Improved mechanism to identify openssl version installed

2019-01-05 Thread GitBox
codecov-io commented on issue #434: DISPATCH-1232 - Improved mechanism to identify openssl version installed URL: https://github.com/apache/qpid-dispatch/pull/434#issuecomment-451687930 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/434?src=pr=h1) Report > Merging

[GitHub] ganeshmurthy opened a new pull request #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast…

2019-01-06 Thread GitBox
ganeshmurthy opened a new pull request #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436 …ed peer if there are being delivered to one of more receivers

[GitHub] codecov-io commented on issue #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast…

2019-01-06 Thread GitBox
codecov-io commented on issue #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436#issuecomment-451772267 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast…

2019-01-06 Thread GitBox
codecov-io edited a comment on issue #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436#issuecomment-451772267 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=h1) Report > Merging

[GitHub] kgiusti opened a new pull request #440: DISPATCH-1243: modify unit test to only run qdrouterd under valgrind

2019-01-16 Thread GitBox
kgiusti opened a new pull request #440: DISPATCH-1243: modify unit test to only run qdrouterd under valgrind URL: https://github.com/apache/qpid-dispatch/pull/440 Added bonus: cuts down on the time taken to run the unit tests by ~25%

[GitHub] astitcher opened a new pull request #173: Rework Python binding to use only core APIs

2019-01-17 Thread GitBox
astitcher opened a new pull request #173: Rework Python binding to use only core APIs URL: https://github.com/apache/qpid-proton/pull/173 This is a reworking of the Python binding to Proton to avoid using APIs outside the Proton Core library. Thus the Python based reactive code has been

[GitHub] ErnieAllen opened a new pull request #441: DISPATCH-1245 Update console dependencies to avoid build warnings

2019-01-17 Thread GitBox
ErnieAllen opened a new pull request #441: DISPATCH-1245 Update console dependencies to avoid build warnings URL: https://github.com/apache/qpid-dispatch/pull/441 Updated the package.json find and re-generated the package-lock.json file to avoid build warnings. Other edits to the

[GitHub] ChugR commented on issue #173: Rework Python binding to use only core APIs

2019-01-17 Thread GitBox
ChugR commented on issue #173: Rework Python binding to use only core APIs URL: https://github.com/apache/qpid-proton/pull/173#issuecomment-455247612 Built qpid-proton; passes self tests. Built qpid-dispatch; fails several self tests: 19 - system_tests_one_router (Failed)

[GitHub] kgiusti opened a new pull request #443: DISPATCH-1248: free autolink core timers on shutdown

2019-01-18 Thread GitBox
kgiusti opened a new pull request #443: DISPATCH-1248: free autolink core timers on shutdown URL: https://github.com/apache/qpid-dispatch/pull/443 This is an automated message from the Apache Git Service. To respond to the

[GitHub] kgiusti opened a new pull request #442: DISPATCH-1247: fix minor bitmask leak

2019-01-18 Thread GitBox
kgiusti opened a new pull request #442: DISPATCH-1247: fix minor bitmask leak URL: https://github.com/apache/qpid-dispatch/pull/442 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] kgiusti opened a new pull request #439: DISPATCH-1214: remove shutdown leak reported by Valgrind

2019-01-15 Thread GitBox
kgiusti opened a new pull request #439: DISPATCH-1214: remove shutdown leak reported by Valgrind URL: https://github.com/apache/qpid-dispatch/pull/439 This leak is filling up the valgrind results with noise. This is an

[GitHub] astitcher commented on issue #173: Rework Python binding to use only core APIs

2019-01-23 Thread GitBox
astitcher commented on issue #173: Rework Python binding to use only core APIs URL: https://github.com/apache/qpid-proton/pull/173#issuecomment-456838959 @ganeshmurthy Thank you - I'll fix that issue then get back to you again.

[GitHub] ganeshmurthy commented on issue #173: Rework Python binding to use only core APIs

2019-01-23 Thread GitBox
ganeshmurthy commented on issue #173: Rework Python binding to use only core APIs URL: https://github.com/apache/qpid-proton/pull/173#issuecomment-456837203 Hi @astitcher, I got down the very latest code from this PR and ran qpid-dispatch master against this PR. All but one test passed.

[GitHub] ganeshmurthy edited a comment on issue #173: Rework Python binding to use only core APIs

2019-01-23 Thread GitBox
ganeshmurthy edited a comment on issue #173: Rework Python binding to use only core APIs URL: https://github.com/apache/qpid-proton/pull/173#issuecomment-456837203 Hi @astitcher, I got down the very latest code from this PR and ran qpid-dispatch master against this PR. All but one test

[GitHub] ChugR commented on issue #173: Rework Python binding to use only core APIs

2019-01-23 Thread GitBox
ChugR commented on issue #173: Rework Python binding to use only core APIs URL: https://github.com/apache/qpid-proton/pull/173#issuecomment-456849349 I get the same two errors/stack traces seen by @ganeshmurthy. In addition, I occasionally (50%) see a failure in

[GitHub] ganeshmurthy opened a new pull request #444: DISPATCH-1254 - Fix a corner cases, usually when a router is just sta…

2019-01-23 Thread GitBox
ganeshmurthy opened a new pull request #444: DISPATCH-1254 - Fix a corner cases, usually when a router is just sta… URL: https://github.com/apache/qpid-dispatch/pull/444 …rting up, where the validOrigins list can come across as None

[GitHub] codecov-io commented on issue #444: DISPATCH-1254 - Fix a corner cases, usually when a router is just sta…

2019-01-23 Thread GitBox
codecov-io commented on issue #444: DISPATCH-1254 - Fix a corner cases, usually when a router is just sta… URL: https://github.com/apache/qpid-dispatch/pull/444#issuecomment-456918948 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/444?src=pr=h1) Report > :exclamation: No

[GitHub] ChugR commented on issue #173: Rework Python binding to use only core APIs

2019-01-23 Thread GitBox
ChugR commented on issue #173: Rework Python binding to use only core APIs URL: https://github.com/apache/qpid-proton/pull/173#issuecomment-456951784 I get the same two errors/stack traces seen by @ganeshmurthy. In addition, I occasionally (50%) see a failure in

[GitHub] astitcher commented on issue #173: Rework Python binding to use only core APIs

2019-01-17 Thread GitBox
astitcher commented on issue #173: Rework Python binding to use only core APIs URL: https://github.com/apache/qpid-proton/pull/173#issuecomment-455357921 @ChugR I'll take a look at the new code, but from the stack trace you gave I'd say the event here in on_timer_task() does not have a

[GitHub] ErnieAllen closed pull request #441: DISPATCH-1245 Update console dependencies to avoid build warnings

2019-01-17 Thread GitBox
ErnieAllen closed pull request #441: DISPATCH-1245 Update console dependencies to avoid build warnings URL: https://github.com/apache/qpid-dispatch/pull/441 This is an automated message from the Apache Git Service. To

[GitHub] astitcher commented on issue #173: Rework Python binding to use only core APIs

2019-01-22 Thread GitBox
astitcher commented on issue #173: Rework Python binding to use only core APIs URL: https://github.com/apache/qpid-proton/pull/173#issuecomment-456674280 @ChugR @ganeshmurthy I've fixed the problem of the missing container for on_timer_task events. If you have a moment please run the

[GitHub] asfgit closed pull request #425: DISPATCH-1213 - Prevent stalling of presettled large message senders …

2018-12-18 Thread GitBox
asfgit closed pull request #425: DISPATCH-1213 - Prevent stalling of presettled large message senders … URL: https://github.com/apache/qpid-dispatch/pull/425 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] kgiusti opened a new pull request #426: DISPATCH-1225: fill freed memory with a pattern for debugging

2018-12-18 Thread GitBox
kgiusti opened a new pull request #426: DISPATCH-1225: fill freed memory with a pattern for debugging URL: https://github.com/apache/qpid-dispatch/pull/426 Hold off on merging this until DISPATCH-1226 lands. Ready for review now.

[GitHub] kgiusti opened a new pull request #427: DISPATCH-1226: fix race during link detach handling

2018-12-18 Thread GitBox
kgiusti opened a new pull request #427: DISPATCH-1226: fix race during link detach handling URL: https://github.com/apache/qpid-dispatch/pull/427 This is an automated message from the Apache Git Service. To respond to the

[GitHub] gemmellr commented on issue #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master

2018-12-20 Thread GitBox
gemmellr commented on issue #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master URL: https://github.com/apache/qpid-dispatch/pull/428#issuecomment-449088645 Updated to only do the coverage build and reporting tasks on one of the sub-jobs

[GitHub] fgiorgetti opened a new pull request #429: DISPATCH-1229 - Fixed imports causing issues to system tests on python3.7

2018-12-20 Thread GitBox
fgiorgetti opened a new pull request #429: DISPATCH-1229 - Fixed imports causing issues to system tests on python3.7 URL: https://github.com/apache/qpid-dispatch/pull/429 This is an automated message from the Apache Git

[GitHub] kgiusti closed pull request #429: DISPATCH-1229 - Fixed imports causing issues to system tests on python3.7

2018-12-20 Thread GitBox
kgiusti closed pull request #429: DISPATCH-1229 - Fixed imports causing issues to system tests on python3.7 URL: https://github.com/apache/qpid-dispatch/pull/429 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] gemmellr commented on issue #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master

2018-12-21 Thread GitBox
gemmellr commented on issue #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master URL: https://github.com/apache/qpid-dispatch/pull/428#issuecomment-449358062 Pushed this as it seems to work as desired, if folks have other improvements we can add them later.

[GitHub] asfgit closed pull request #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master

2018-12-21 Thread GitBox
asfgit closed pull request #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master URL: https://github.com/apache/qpid-dispatch/pull/428 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] codecov-io commented on issue #431: DISPATCH-1231: correct credit handling in core client

2018-12-23 Thread GitBox
codecov-io commented on issue #431: DISPATCH-1231: correct credit handling in core client URL: https://github.com/apache/qpid-dispatch/pull/431#issuecomment-449682539 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/431?src=pr=h1) Report > :exclamation: No coverage uploaded

[GitHub] fgiorgetti opened a new pull request #432: DISPATCH-1232 - Adjusted FakeBroker to be compatible with python2.6

2018-12-26 Thread GitBox
fgiorgetti opened a new pull request #432: DISPATCH-1232 - Adjusted FakeBroker to be compatible with python2.6 URL: https://github.com/apache/qpid-dispatch/pull/432 This is an automated message from the Apache Git Service.

[GitHub] kgiusti opened a new pull request #431: DISPATCH-1231: correct credit handling in core client

2018-12-23 Thread GitBox
kgiusti opened a new pull request #431: DISPATCH-1231: correct credit handling in core client URL: https://github.com/apache/qpid-dispatch/pull/431 This is an automated message from the Apache Git Service. To respond to the

[GitHub] codecov-io commented on issue #430: DISPATCH-1230 - Fixed system_tests_ssl when using OpenSSL 1.1 or greater

2018-12-24 Thread GitBox
codecov-io commented on issue #430: DISPATCH-1230 - Fixed system_tests_ssl when using OpenSSL 1.1 or greater URL: https://github.com/apache/qpid-dispatch/pull/430#issuecomment-449725317 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/430?src=pr=h1) Report > :exclamation:

[GitHub] fgiorgetti opened a new pull request #430: DISPATCH-1230 - Fixed system_tests_ssl when using OpenSSL 1.1 or greater

2018-12-21 Thread GitBox
fgiorgetti opened a new pull request #430: DISPATCH-1230 - Fixed system_tests_ssl when using OpenSSL 1.1 or greater URL: https://github.com/apache/qpid-dispatch/pull/430 This is an automated message from the Apache Git

[GitHub] grs commented on issue #20: QPID-5285 [AMQP 1.0] timestamped messages not supported

2019-01-08 Thread GitBox
grs commented on issue #20: QPID-5285 [AMQP 1.0] timestamped messages not supported URL: https://github.com/apache/qpid-cpp/pull/20#issuecomment-452404614 Looks good, existing tests all pass and I've verified the timestamp is added as expected when enabled (but not otherwise).

[GitHub] grs commented on a change in pull request #20: QPID-5285 [AMQP 1.0] timestamped messages not supported

2019-01-08 Thread GitBox
grs commented on a change in pull request #20: QPID-5285 [AMQP 1.0] timestamped messages not supported URL: https://github.com/apache/qpid-cpp/pull/20#discussion_r246104594 ## File path: src/qpid/broker/amqp/Incoming.cpp ## @@ -108,7 +109,11 @@ namespace { }

[GitHub] grs commented on a change in pull request #20: QPID-5285 [AMQP 1.0] timestamped messages not supported

2019-01-08 Thread GitBox
grs commented on a change in pull request #20: QPID-5285 [AMQP 1.0] timestamped messages not supported URL: https://github.com/apache/qpid-cpp/pull/20#discussion_r246099807 ## File path: src/qpid/broker/amqp/Incoming.cpp ## @@ -146,6 +151,10 @@ void

[GitHub] codecov-io edited a comment on issue #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast…

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436#issuecomment-451772267 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/436?src=pr=h1) Report > Merging

[GitHub] asfgit closed pull request #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast…

2019-01-10 Thread GitBox
asfgit closed pull request #436: DISPATCH-1237 - Modified link cleanup code to not release a multicast… URL: https://github.com/apache/qpid-dispatch/pull/436 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] porrafabrizio opened a new pull request #20: Update Incoming.cpp

2019-01-07 Thread GitBox
porrafabrizio opened a new pull request #20: Update Incoming.cpp URL: https://github.com/apache/qpid-cpp/pull/20 Added a timestamp marking the actual arrival time at the broker. Change affects the DecodingIncoming:deliver method. Property "x-opt-ingress-timestamp" has been added to

[GitHub] codecov-io commented on issue #437: DISPATCH-1239 - Modified system tests to work with python2.6

2019-01-07 Thread GitBox
codecov-io commented on issue #437: DISPATCH-1239 - Modified system tests to work with python2.6 URL: https://github.com/apache/qpid-dispatch/pull/437#issuecomment-452055157 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/437?src=pr=h1) Report > Merging

[GitHub] fgiorgetti opened a new pull request #437: DISPATCH-1239 - Modified system tests to work with python2.6

2019-01-07 Thread GitBox
fgiorgetti opened a new pull request #437: DISPATCH-1239 - Modified system tests to work with python2.6 URL: https://github.com/apache/qpid-dispatch/pull/437 This is an automated message from the Apache Git Service. To

[GitHub] porrafabrizio commented on issue #20: QPID-5285 [AMQP 1.0] timestamped messages not supported

2019-01-08 Thread GitBox
porrafabrizio commented on issue #20: QPID-5285 [AMQP 1.0] timestamped messages not supported URL: https://github.com/apache/qpid-cpp/pull/20#issuecomment-452303378 Timestamping is now configurable by parameter "enable-timestamp" as in amqp 0-10: property "x-opt-ingress-timestamp" is set

[GitHub] porrafabrizio edited a comment on issue #20: QPID-5285 [AMQP 1.0] timestamped messages not supported

2019-01-08 Thread GitBox
porrafabrizio edited a comment on issue #20: QPID-5285 [AMQP 1.0] timestamped messages not supported URL: https://github.com/apache/qpid-cpp/pull/20#issuecomment-452303378 Thank you, grs. Timestamping is now configurable by parameter "enable-timestamp" as in amqp 0-10: property

[GitHub] ganeshmurthy opened a new pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…

2019-01-03 Thread GitBox
ganeshmurthy opened a new pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433 … context is freed. This is an automated message from

[GitHub] codecov-io commented on issue #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…

2019-01-03 Thread GitBox
codecov-io commented on issue #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#issuecomment-451225511 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/433?src=pr=h1) Report > :exclamation: No

[GitHub] asfgit closed pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…

2019-01-04 Thread GitBox
asfgit closed pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…

2019-01-03 Thread GitBox
kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089019 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c

[GitHub] kgiusti opened a new pull request #435: DISPATCH-1235: properly unlink peer deliveries in the case of multicast

2019-01-04 Thread GitBox
kgiusti opened a new pull request #435: DISPATCH-1235: properly unlink peer deliveries in the case of multicast URL: https://github.com/apache/qpid-dispatch/pull/435 This is an automated message from the Apache Git Service.

[GitHub] asfgit closed pull request #435: DISPATCH-1235: properly unlink peer deliveries in the case of multicast

2019-01-04 Thread GitBox
asfgit closed pull request #435: DISPATCH-1235: properly unlink peer deliveries in the case of multicast URL: https://github.com/apache/qpid-dispatch/pull/435 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] franz1981 commented on issue #26: QPIDJMS-430 Lock-Free FifoMessageQueue

2019-01-11 Thread GitBox
franz1981 commented on issue #26: QPIDJMS-430 Lock-Free FifoMessageQueue URL: https://github.com/apache/qpid-jms/pull/26#issuecomment-453601630 @tabish121 I haven't had the chance to measure the gains now that https://github.com/apache/activemq-artemis/pull/2467 has been merged and sadly

[GitHub] franz1981 closed pull request #26: QPIDJMS-430 Lock-Free FifoMessageQueue

2019-01-11 Thread GitBox
franz1981 closed pull request #26: QPIDJMS-430 Lock-Free FifoMessageQueue URL: https://github.com/apache/qpid-jms/pull/26 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] franz1981 opened a new pull request #26: QPIDJMS-430 Lock-Free FifoMessageQueue

2019-01-11 Thread GitBox
franz1981 opened a new pull request #26: QPIDJMS-430 Lock-Free FifoMessageQueue URL: https://github.com/apache/qpid-jms/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] franz1981 commented on issue #26: QPIDJMS-430 Lock-Free FifoMessageQueue

2019-01-11 Thread GitBox
franz1981 commented on issue #26: QPIDJMS-430 Lock-Free FifoMessageQueue URL: https://github.com/apache/qpid-jms/pull/26#issuecomment-453593690 @tabish121 I can make this impl simpler (eg no padding) because it is an improvement over the original version, but needs some macro test: thanks

[GitHub] franz1981 removed a comment on issue #26: QPIDJMS-430 Lock-Free FifoMessageQueue

2019-01-11 Thread GitBox
franz1981 removed a comment on issue #26: QPIDJMS-430 Lock-Free FifoMessageQueue URL: https://github.com/apache/qpid-jms/pull/26#issuecomment-453593690 @tabish121 I can make this impl simpler (eg no padding) because it is an improvement over the original version, but needs some macro test:

[GitHub] franz1981 edited a comment on issue #26: QPIDJMS-430 Lock-Free FifoMessageQueue

2019-01-11 Thread GitBox
franz1981 edited a comment on issue #26: QPIDJMS-430 Lock-Free FifoMessageQueue URL: https://github.com/apache/qpid-jms/pull/26#issuecomment-453601630 @tabish121 I haven't had the chance to measure the gains now that https://github.com/apache/activemq-artemis/pull/2467 has been merged and

[GitHub] asfgit closed pull request #20: QPID-5285 [AMQP 1.0] timestamped messages not supported

2019-01-09 Thread GitBox
asfgit closed pull request #20: QPID-5285 [AMQP 1.0] timestamped messages not supported URL: https://github.com/apache/qpid-cpp/pull/20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] grs commented on issue #20: QPID-5285 [AMQP 1.0] timestamped messages not supported

2019-01-09 Thread GitBox
grs commented on issue #20: QPID-5285 [AMQP 1.0] timestamped messages not supported URL: https://github.com/apache/qpid-cpp/pull/20#issuecomment-452683759 @porrafabrizio Thank you very much! Your change is now merged to master.

[GitHub] asfgit closed pull request #438: DISPATCH-1240: prevent truncation of correlation id

2019-01-09 Thread GitBox
asfgit closed pull request #438: DISPATCH-1240: prevent truncation of correlation id URL: https://github.com/apache/qpid-dispatch/pull/438 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] asfgit closed pull request #437: DISPATCH-1239 - Modified system tests to work with python2.6

2019-01-09 Thread GitBox
asfgit closed pull request #437: DISPATCH-1239 - Modified system tests to work with python2.6 URL: https://github.com/apache/qpid-dispatch/pull/437 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] asfgit closed pull request #432: DISPATCH-1232 - Adjusted FakeBroker to be compatible with python2.6

2019-01-02 Thread GitBox
asfgit closed pull request #432: DISPATCH-1232 - Adjusted FakeBroker to be compatible with python2.6 URL: https://github.com/apache/qpid-dispatch/pull/432 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] fgiorgetti closed pull request #430: DISPATCH-1230 - Fixed system_tests_ssl when using OpenSSL 1.1 or greater

2019-01-02 Thread GitBox
fgiorgetti closed pull request #430: DISPATCH-1230 - Fixed system_tests_ssl when using OpenSSL 1.1 or greater URL: https://github.com/apache/qpid-dispatch/pull/430 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…

2019-01-03 Thread GitBox
kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089295 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c

[GitHub] kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge…

2019-01-03 Thread GitBox
kgiusti commented on a change in pull request #433: DISPATCH-1234 - Zero out the edge context on the link before the edge… URL: https://github.com/apache/qpid-dispatch/pull/433#discussion_r245089130 ## File path: src/router_core/modules/edge_addr_tracking/edge_addr_tracking.c

[GitHub] fgiorgetti opened a new pull request #434: DISPATCH-1232 - Improved mechanism to identify openssl version installed

2019-01-03 Thread GitBox
fgiorgetti opened a new pull request #434: DISPATCH-1232 - Improved mechanism to identify openssl version installed URL: https://github.com/apache/qpid-dispatch/pull/434 This is an automated message from the Apache Git

[GitHub] asfgit closed pull request #426: DISPATCH-1225: fill freed memory with a pattern for debugging

2018-12-19 Thread GitBox
asfgit closed pull request #426: DISPATCH-1225: fill freed memory with a pattern for debugging URL: https://github.com/apache/qpid-dispatch/pull/426 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] asfgit closed pull request #427: DISPATCH-1226: fix race during link detach handling

2018-12-19 Thread GitBox
asfgit closed pull request #427: DISPATCH-1226: fix race during link detach handling URL: https://github.com/apache/qpid-dispatch/pull/427 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] gemmellr opened a new pull request #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master

2018-12-19 Thread GitBox
gemmellr opened a new pull request #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master URL: https://github.com/apache/qpid-dispatch/pull/428 There have been various cases that using only Proton master for CI caused Dispatch test failures, or lead to Dispatch

[GitHub] gemmellr commented on issue #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master

2018-12-19 Thread GitBox
gemmellr commented on issue #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master URL: https://github.com/apache/qpid-dispatch/pull/428#issuecomment-448672524 Ignore this comment (but not the PR), testing integration again.

[GitHub] gemmellr commented on issue #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master

2018-12-19 Thread GitBox
gemmellr commented on issue #428: DISPATCH-1115: make TravisCI job use a Proton release in addition to master URL: https://github.com/apache/qpid-dispatch/pull/428#issuecomment-448666834 Ignore this comment (but not the PR), testing integration.

[GitHub] kgiusti opened a new pull request #445: DISPATCH-1246: clean up core link endpoints on shutdown

2019-01-24 Thread GitBox
kgiusti opened a new pull request #445: DISPATCH-1246: clean up core link endpoints on shutdown URL: https://github.com/apache/qpid-dispatch/pull/445 This patch makes the following changes: o) the do_cleanup callback is always invoked then the core link endpoint is released. The

[GitHub] Rahulbuk opened a new pull request #27: QPIDJMS-442 - Options to bind local address and port

2019-01-26 Thread GitBox
Rahulbuk opened a new pull request #27: QPIDJMS-442 - Options to bind local address and port URL: https://github.com/apache/qpid-jms/pull/27 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit closed pull request #443: DISPATCH-1248: free autolink core timers on shutdown

2019-01-22 Thread GitBox
asfgit closed pull request #443: DISPATCH-1248: free autolink core timers on shutdown URL: https://github.com/apache/qpid-dispatch/pull/443 This is an automated message from the Apache Git Service. To respond to the

[GitHub] asfgit closed pull request #440: DISPATCH-1243: modify unit test to only run qdrouterd under valgrind

2019-01-22 Thread GitBox
asfgit closed pull request #440: DISPATCH-1243: modify unit test to only run qdrouterd under valgrind URL: https://github.com/apache/qpid-dispatch/pull/440 This is an automated message from the Apache Git Service. To

[GitHub] ganeshmurthy commented on a change in pull request #439: DISPATCH-1214: remove shutdown leak reported by Valgrind

2019-01-22 Thread GitBox
ganeshmurthy commented on a change in pull request #439: DISPATCH-1214: remove shutdown leak reported by Valgrind URL: https://github.com/apache/qpid-dispatch/pull/439#discussion_r249841944 ## File path: src/router_core/router_core.c ## @@ -173,6 +173,9 @@ void

[GitHub] gemmellr commented on issue #27: QPIDJMS-442 - Options to bind local address and port

2019-01-28 Thread GitBox
gemmellr commented on issue #27: QPIDJMS-442 - Options to bind local address and port URL: https://github.com/apache/qpid-jms/pull/27#issuecomment-458199926 Thanks for the PR. I have pushed a change based on it, with some modifications and more tests, feel free to give it a try out.

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #479: Dispatch 1302

2019-04-02 Thread GitBox
kgiusti opened a new pull request #479: Dispatch 1302 URL: https://github.com/apache/qpid-dispatch/pull/479 The "multicast" tests are not actually multicast for now - I'll merge more tests there once unsettled mcast is done. It happened to have a simple reproducer for the settlement race

[GitHub] [qpid-dispatch] codecov-io commented on issue #479: Dispatch 1302

2019-04-02 Thread GitBox
codecov-io commented on issue #479: Dispatch 1302 URL: https://github.com/apache/qpid-dispatch/pull/479#issuecomment-479124065 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/479?src=pr=h1) Report > Merging

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #474: NO-JIRA: prevent python system paths from leaking into the test envir…

2019-03-20 Thread GitBox
kgiusti opened a new pull request #474: NO-JIRA: prevent python system paths from leaking into the test envir… URL: https://github.com/apache/qpid-dispatch/pull/474 …onment This is an automated message from the Apache Git

[GitHub] [qpid-broker-j] asfgit closed pull request #22: QPID-8286: [Broker-J] Add operations into priority queue to change message priority

2019-03-27 Thread GitBox
asfgit closed pull request #22: QPID-8286: [Broker-J] Add operations into priority queue to change message priority URL: https://github.com/apache/qpid-broker-j/pull/22 This is an automated message from the Apache Git

[GitHub] [qpid-dispatch] kgiusti commented on issue #474: NO-JIRA: prevent python system paths from leaking into the test envir…

2019-03-21 Thread GitBox
kgiusti commented on issue #474: NO-JIRA: prevent python system paths from leaking into the test envir… URL: https://github.com/apache/qpid-dispatch/pull/474#issuecomment-475214388 Do Not Merge! Breaks the travis-ci build

[GitHub] [qpid-dispatch] asfgit closed pull request #473: DISPATCH-1297: Fix the outgoing buffer reference counting

2019-03-22 Thread GitBox
asfgit closed pull request #473: DISPATCH-1297: Fix the outgoing buffer reference counting URL: https://github.com/apache/qpid-dispatch/pull/473 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [qpid-dispatch] ChugR commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa…

2019-03-24 Thread GitBox
ChugR commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa… URL: https://github.com/apache/qpid-dispatch/pull/477#issuecomment-476015524 This may get the test to pass but there has been a bad behavior change somewhere in the router.

[GitHub] [qpid-dispatch] ted-ross commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa…

2019-03-24 Thread GitBox
ted-ross commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa… URL: https://github.com/apache/qpid-dispatch/pull/477#issuecomment-476034872 Don’t use a timer. You can get the reply address in the on_link_opened event. There are many examples of

[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa…

2019-03-24 Thread GitBox
ganeshmurthy commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa… URL: https://github.com/apache/qpid-dispatch/pull/477#issuecomment-476022472 I was able to reproduce this test failure in version 1.5.0. This is not a regression.

[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa…

2019-03-24 Thread GitBox
ganeshmurthy commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa… URL: https://github.com/apache/qpid-dispatch/pull/477#issuecomment-476022892 Here is the output of the test failure when running the same test in v1.5.0 [gmurthy@localhost

[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa…

2019-03-25 Thread GitBox
ganeshmurthy commented on issue #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa… URL: https://github.com/apache/qpid-dispatch/pull/477#issuecomment-476186200 Closing this PR. Will be using on_link_opened as @ted-ross suggested. Will open a new PR with the

[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa…

2019-03-25 Thread GitBox
ganeshmurthy closed pull request #477: DISPATCH-1301 - Updated test test_18_management_not_implemented to wa… URL: https://github.com/apache/qpid-dispatch/pull/477 This is an automated message from the Apache Git Service.

[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #478: DISPATCH-1301 - Got the reply_to address from inside of on_link_opene…

2019-03-25 Thread GitBox
ganeshmurthy opened a new pull request #478: DISPATCH-1301 - Got the reply_to address from inside of on_link_opene… URL: https://github.com/apache/qpid-dispatch/pull/478 …d. This prevents test failures due to prematurely getting the rely address

[GitHub] [qpid-dispatch] cliffjansen commented on issue #476: DISPATCH-1295 - Reduce lock contention and make fewer system calls.

2019-03-25 Thread GitBox
cliffjansen commented on issue #476: DISPATCH-1295 - Reduce lock contention and make fewer system calls. URL: https://github.com/apache/qpid-dispatch/pull/476#issuecomment-476237398 Since this pull request builds on top of DISPATCH-1274, and that has been removed for the next release, I

[GitHub] [qpid-dispatch] cliffjansen closed pull request #476: DISPATCH-1295 - Reduce lock contention and make fewer system calls.

2019-03-25 Thread GitBox
cliffjansen closed pull request #476: DISPATCH-1295 - Reduce lock contention and make fewer system calls. URL: https://github.com/apache/qpid-dispatch/pull/476 This is an automated message from the Apache Git Service. To

[GitHub] [qpid-dispatch] cliffjansen opened a new pull request #476: DISPATCH-1295 - Reduce lock contention and make fewer system calls.

2019-03-23 Thread GitBox
cliffjansen opened a new pull request #476: DISPATCH-1295 - Reduce lock contention and make fewer system calls. URL: https://github.com/apache/qpid-dispatch/pull/476 Flamegraphs show on a single quiver run that there is lock contention in setting timers. Locks are held across system

[GitHub] [qpid-dispatch] codecov-io commented on issue #476: DISPATCH-1295 - Reduce lock contention and make fewer system calls.

2019-03-23 Thread GitBox
codecov-io commented on issue #476: DISPATCH-1295 - Reduce lock contention and make fewer system calls. URL: https://github.com/apache/qpid-dispatch/pull/476#issuecomment-475874874 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/476?src=pr=h1) Report > Merging

[GitHub] [qpid-dispatch] asfgit closed pull request #478: DISPATCH-1301 - Got the reply_to address from inside of on_link_opene…

2019-03-25 Thread GitBox
asfgit closed pull request #478: DISPATCH-1301 - Got the reply_to address from inside of on_link_opene… URL: https://github.com/apache/qpid-dispatch/pull/478 This is an automated message from the Apache Git Service. To

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #480: NO-JIRA: update travis configuration

2019-04-03 Thread GitBox
kgiusti opened a new pull request #480: NO-JIRA: update travis configuration URL: https://github.com/apache/qpid-dispatch/pull/480 - update proton to current release (0.27.0) - add a debug-enabled build environment - change the Coverage build to use stable proton - remove

[GitHub] [qpid-dispatch] asfgit closed pull request #479: Dispatch 1302

2019-04-03 Thread GitBox
asfgit closed pull request #479: Dispatch 1302 URL: https://github.com/apache/qpid-dispatch/pull/479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [qpid-dispatch] codecov-io commented on issue #480: NO-JIRA: update travis configuration

2019-04-03 Thread GitBox
codecov-io commented on issue #480: NO-JIRA: update travis configuration URL: https://github.com/apache/qpid-dispatch/pull/480#issuecomment-479561691 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/480?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request

  1   2   3   4   >