[GitHub] qpid-dispatch pull request #254: DISPATCH-911 - Added global delivery counts

2018-02-27 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/qpid-dispatch/pull/254


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #254: DISPATCH-911 - Added global delivery counts

2018-02-14 Thread ganeshmurthy 
Github user ganeshmurthy commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/254#discussion_r168192351
  
--- Diff: src/router_node.c ---
@@ -33,7 +33,6 @@
 const char *QD_ROUTER_NODE_TYPE = "router.node";
 const char *QD_ROUTER_ADDRESS_TYPE = "router.address";
 const char *QD_ROUTER_LINK_TYPE = "router.link";
-const char *CORE_AGENT_ADDRESS = "$management";
--- End diff --

You are correct. This is not related to the PR. I saw that this was not 
being used anywhere, so I removed it. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #254: DISPATCH-911 - Added global delivery counts

2018-02-12 Thread ted-ross 
Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/254#discussion_r167742873
  
--- Diff: src/router_node.c ---
@@ -33,7 +33,6 @@
 const char *QD_ROUTER_NODE_TYPE = "router.node";
 const char *QD_ROUTER_ADDRESS_TYPE = "router.address";
 const char *QD_ROUTER_LINK_TYPE = "router.link";
-const char *CORE_AGENT_ADDRESS = "$management";
--- End diff --

How is this related to the PR?


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #254: DISPATCH-911 - Added global delivery counts

2018-02-12 Thread ganeshmurthy 
GitHub user ganeshmurthy opened a pull request:

https://github.com/apache/qpid-dispatch/pull/254

DISPATCH-911 - Added global delivery counts



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-911-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #254


commit adea1d9908ee6699b493e6d27d3fae81b7468516
Author: Ganesh Murthy 
Date:   2018-01-26T18:12:12Z

DISPATCH-911 - Added global delivery counts




---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org