[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-09 Thread dmitrytokarev
Github user dmitrytokarev commented on the issue: https://github.com/apache/qpid-proton/pull/110 @jdanekrh well it doesn't really matter how it's done as long as community contributions are authored and recognized. Some people may show case their github accounts on their resumes, so

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-09 Thread jdanekrh
Github user jdanekrh commented on the issue: https://github.com/apache/qpid-proton/pull/110 whoa, codecov.io has gone crazy... this report above includes about 10 recent commits to master, not just this one... @dmitrytokarev Is committing as myself, but setting `git commit

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-08 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/110 @dmitrytokarev , I was failing at making it merge the way I wanted. I will try to figure out the right sequence of commands so I get it right next time. ---

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-08 Thread dmitrytokarev
Github user dmitrytokarev commented on the issue: https://github.com/apache/qpid-proton/pull/110 @ssorj why didn't you just merge this PR? Now @aikchar doesn't get credit for his work. --- - To unsubscribe,

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-08 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/qpid-proton/pull/110 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/110?src=pr=h1) Report > Merging [#110](https://codecov.io/gh/apache/qpid-proton/pull/110?src=pr=desc) into

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

2017-12-08 Thread ssorj
Github user ssorj commented on the issue: https://github.com/apache/qpid-proton/pull/110 @aikchar , I applied this patch. Please close when you get a chance. https://github.com/apache/qpid-proton/commit/2b033949c54549591113e61ea33e625f9b898cbb ---