[GitHub] qpid-proton issue #110: Fix for PROTON-1517

[dmitrytokarev]

Github user dmitrytokarev commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
@jdanekrh well it doesn't really matter how it's done as long as community 
contributions are authored and recognized. Some people may show case their 
github accounts on their resumes, so if they don't get credit for their work, 
they have nothing to showcase. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

[jdanekrh]

Github user jdanekrh commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
whoa, codecov.io has gone crazy... this report above includes about 10 
recent commits to master, not just this one...

@dmitrytokarev Is committing as myself, but setting `git commit --author 
"Other person "` acceptable GitHub practice? Or doing a final 
`commit --amend` with the `--author` set? This is what I intended to do (in my 
personal project...)


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
@dmitrytokarev , I was failing at making it merge the way I wanted.  I will 
try to figure out the right sequence of commands so I get it right next time. 


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

[dmitrytokarev]

Github user dmitrytokarev commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
@ssorj why didn't you just merge this PR?
Now @aikchar doesn't get credit for his work.


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/110?src=pr=h1) 
Report
> Merging 
[#110](https://codecov.io/gh/apache/qpid-proton/pull/110?src=pr=desc) into 
[master](https://codecov.io/gh/apache/qpid-proton/commit/1ff005f661e070d72397cdc3a431854693626b97?src=pr=desc)
 will **decrease** coverage by `0.35%`.
> The diff coverage is `68.19%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-proton/pull/110/graphs/tree.svg?height=150=pr=UKKzV9XnFF=650)](https://codecov.io/gh/apache/qpid-proton/pull/110?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #110  +/-   ##
==
- Coverage   78.67%   78.31%   -0.36% 
==
  Files 231  232   +1 
  Lines   3054630687 +141 
  Branches 2903 2927  +24 
==
+ Hits2403324034   +1 
- Misses   4872 4912  +40 
- Partials 1641 1741 +100
```


| [Impacted 
Files](https://codecov.io/gh/apache/qpid-proton/pull/110?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[proton-c/bindings/cpp/src/scalar\_test.hpp](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvY3BwL3NyYy9zY2FsYXJfdGVzdC5ocHA=)
 | `100% <ø> (ø)` | |
| 
[examples/c/send-ssl.c](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-ZXhhbXBsZXMvYy9zZW5kLXNzbC5j)
 | `76.28% <ø> (ø)` | :arrow_up: |
| 
[examples/c/send.c](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-ZXhhbXBsZXMvYy9zZW5kLmM=)
 | `75.82% <ø> (ø)` | :arrow_up: |
| 
[proton-c/bindings/cpp/src/connection\_driver.cpp](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvY3BwL3NyYy9jb25uZWN0aW9uX2RyaXZlci5jcHA=)
 | `77.77% <ø> (ø)` | |
| 
[examples/cpp/multithreaded\_client.cpp](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-ZXhhbXBsZXMvY3BwL211bHRpdGhyZWFkZWRfY2xpZW50LmNwcA==)
 | `81.81% <ø> (ø)` | :arrow_up: |
| 
[examples/c/send-abort.c](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-ZXhhbXBsZXMvYy9zZW5kLWFib3J0LmM=)
 | `76.34% <ø> (ø)` | :arrow_up: |
| 
[examples/c/direct.c](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-ZXhhbXBsZXMvYy9kaXJlY3QuYw==)
 | `83.63% <ø> (ø)` | :arrow_up: |
| 
[proton-c/bindings/cpp/src/types\_internal.hpp](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvY3BwL3NyYy90eXBlc19pbnRlcm5hbC5ocHA=)
 | `94.73% <ø> (ø)` | |
| 
[proton-c/src/core/message.c](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-cHJvdG9uLWMvc3JjL2NvcmUvbWVzc2FnZS5j)
 | `59.53% <ø> (-0.78%)` | :arrow_down: |
| 
[examples/cpp/ssl\_client\_cert.cpp](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree#diff-ZXhhbXBsZXMvY3BwL3NzbF9jbGllbnRfY2VydC5jcHA=)
 | `81.08% <ø> (ø)` | :arrow_up: |
| ... and [71 
more](https://codecov.io/gh/apache/qpid-proton/pull/110/diff?src=pr=tree-more)
 | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/110?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/110?src=pr=footer). 
Last update 
[1ff005f...a4dafa2](https://codecov.io/gh/apache/qpid-proton/pull/110?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #110: Fix for PROTON-1517

[ssorj]

Github user ssorj commented on the issue:

https://github.com/apache/qpid-proton/pull/110
  
@aikchar , I applied this patch.  Please close when you get a chance.


https://github.com/apache/qpid-proton/commit/2b033949c54549591113e61ea33e625f9b898cbb


---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org