[GitHub] qpid-proton issue #83: [Go binding] Replaced c handler based flowcontroller ...

2016-10-14 Thread alanconway
Github user alanconway commented on the issue:

https://github.com/apache/qpid-proton/pull/83
  
Add module tests to proton_test.go. As you can see right now it is empty 
which is not ideal (!) The actual tests are in electron/electron_tests.go and 
the examples are also auto-tested by ctest. We should really have unit tests 
for proton itself though so if you want to start that off, please do :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[GitHub] qpid-proton issue #83: [Go binding] Replaced c handler based flowcontroller ...

2016-10-13 Thread astitcher
Github user astitcher commented on the issue:

https://github.com/apache/qpid-proton/pull/83
  
@alanconway Thanks for pointing out the stupid Cism in my go code.

I've fixed it now.

I'd much porefer to check this iin with sone sort of test - any clue how I 
should go about that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org