[ https://issues.apache.org/jira/browse/QPID-7451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564995#comment-15564995 ]
Keith Wall edited comment on QPID-7451 at 10/11/16 9:21 AM: ------------------------------------------------------------ Changes look reasonable to me. Merged to 6.0.x. was (Author: k-wall): Changes look reasonable to me. > [Java Broker] MessageTransferMessage should cache message size > -------------------------------------------------------------- > > Key: QPID-7451 > URL: https://issues.apache.org/jira/browse/QPID-7451 > Project: Qpid > Issue Type: Bug > Components: Java Broker > Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, > qpid-java-6.0.3, qpid-java-6.0.4 > Reporter: Rob Godfrey > Assignee: Rob Godfrey > Fix For: qpid-java-6.0.5, qpid-java-6.1 > > Attachments: QPID-7451_for_0_32.patch > > > AMQMessage (the 0-9-1 path) caches message size, however > MessageTransferMessage (the 0-10 path) does not. This means that the > delivery path from AbstractQueue may require retrieval of the message meta > data from the store to get the message size. Since not all requests to get > the message size are protected by first getting a message reference, there is > a chance of a race whereby the message is removed from the store between > checking whether it is available and obtaining the message size. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org