[jira] [Commented] (DISPATCH-113) expose NodeTracker::last_topology_change in management

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691275#comment-15691275
 ] 

ASF GitHub Bot commented on DISPATCH-113:
-

Github user ted-ross commented on a diff in the pull request:

https://github.com/apache/qpid-dispatch/pull/117#discussion_r89392215
  
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -1209,7 +1209,12 @@
 "cost": {
 "description": "Reachability cost",
 "type": "integer"
+},
+"lastTopoChange": {
+ "description": "Timestamp showing the most recent 
change to this node's neighborhood.",
+ "type": "string"
--- End diff --

This should be an integer, not a string.  Seconds since the epoch is more 
than sufficient granularity.


> expose NodeTracker::last_topology_change in management 
> ---
>
> Key: DISPATCH-113
> URL: https://issues.apache.org/jira/browse/DISPATCH-113
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Affects Versions: 0.4
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Minor
>
> NodeTracker is already keeping track of the last time it saw a topology 
> change.
> I would like to expose that number to management so I can read it from my 
> testing program and directly measure how long it takes the network to settle 
> down after a topological change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (DISPATCH-113) expose NodeTracker::last_topology_change in management

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DISPATCH-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691129#comment-15691129
 ] 

ASF GitHub Bot commented on DISPATCH-113:
-

GitHub user mgoulish opened a pull request:

https://github.com/apache/qpid-dispatch/pull/117

DISPATCH-113 -- expose topology_last_changed to management



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-113

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-dispatch/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #117


commit c5f71aa47f789a3e1cb26760aa1fa55835d0f52f
Author: mick 
Date:   2016-11-23T19:24:44Z

DISPATCH-113 -- expose topology_last_changed to management




> expose NodeTracker::last_topology_change in management 
> ---
>
> Key: DISPATCH-113
> URL: https://issues.apache.org/jira/browse/DISPATCH-113
> Project: Qpid Dispatch
>  Issue Type: Improvement
>  Components: Router Node
>Affects Versions: 0.4
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Minor
>
> NodeTracker is already keeping track of the last time it saw a topology 
> change.
> I would like to expose that number to management so I can read it from my 
> testing program and directly measure how long it takes the network to settle 
> down after a topological change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org