[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15504240#comment-15504240 ] ASF GitHub Bot commented on PROTON-1303: Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/81 You're right, godoc takes a host:port not a URL. Ship It. > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496655#comment-15496655 ] ASF GitHub Bot commented on PROTON-1303: Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/81 ":1234" is not allowed by the go URL parser - that is what is rejecting it. It gets rejected before our code has anything to do with it. [That is because it is invalid as a URL - you can't have a leading ":" without a scheme. > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1549#comment-1549 ] ASF subversion and git services commented on PROTON-1303: - Commit b8acb8ae53146c6e5726a872e71ee986649c1c16 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=b8acb8a ] PROTON-1303: Use LastIndex instead of LastIndexByte to compile with go 1.4 too > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496667#comment-15496667 ] ASF subversion and git services commented on PROTON-1303: - Commit 88e4f076b97375a4ab79240f38d5eb4a4930d41f in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=88e4f07 ] PROTON-1303: Comment out examples that give different output for go 1.4 > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496665#comment-15496665 ] ASF subversion and git services commented on PROTON-1303: - Commit 26e7ff804783ff34b2d8e86f737f048b3aa0778c in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=26e7ff8 ] PROTON-1303: Replace go binding URL parser with version that doesn't use the Proton URL parser > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496668#comment-15496668 ] ASF subversion and git services commented on PROTON-1303: - Commit 4bb26814cbb778e6fdb999d0162b39170a04923f in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4bb2681 ] Merge PROTON-1303 Closes #81 > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496669#comment-15496669 ] ASF GitHub Bot commented on PROTON-1303: Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/81 > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496564#comment-15496564 ] ASF GitHub Bot commented on PROTON-1303: Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/81 OOps no: I don't like that this is not allowed ":1234" becase it *is* allowed by the go URL parser and is correctly interpreted as "listen on all interfaces" or "connect to localhost" by the go runtimes. It is commonly used in go documentation, e.g .the standard way to start the godoc webserver is godoc -http :6060 I'm starting to feel that there isn't much/any need for a special URL parser if we simply provide the Update function to fill in defaults. Then we don't have to do anything to mess with parsing/what is acceptable as a URL, we just provide AMQP info - which is our job > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494276#comment-15494276 ] ASF GitHub Bot commented on PROTON-1303: Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/81 @alanconway Did you note the change in meaning for a few URLs? > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1303) Don't use the proton-c url parser
[ https://issues.apache.org/jira/browse/PROTON-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494235#comment-15494235 ] ASF GitHub Bot commented on PROTON-1303: GitHub user astitcher opened a pull request: https://github.com/apache/qpid-proton/pull/81 PROTON-1303: Replace go binding URL parser with version that doesn't … This PR is specially for @alanconway to review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/astitcher/qpid-proton go-url-parser Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/81.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #81 > Don't use the proton-c url parser > - > > Key: PROTON-1303 > URL: https://issues.apache.org/jira/browse/PROTON-1303 > Project: Qpid Proton > Issue Type: Improvement > Components: go-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Go has it's own standard url parser - it doesn't need to use the rather odd > and somewhat error prone parser in proton-c. > It will be useful to provide some ability to set appropriate defaults for > supplied amqp urls though. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
