[jira] [Commented] (PROTON-1304) SSL code shouldn't need to know the time (shouldn't use the platform dependent parts of proton-c)
[ https://issues.apache.org/jira/browse/PROTON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496460#comment-15496460 ] ASF GitHub Bot commented on PROTON-1304: Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/80 > SSL code shouldn't need to know the time (shouldn't use the platform > dependent parts of proton-c) > - > > Key: PROTON-1304 > URL: https://issues.apache.org/jira/browse/PROTON-1304 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Currently the interface to OpenSSL keeps it's own cache of sessions separate > from the cache held in OpenSSL itself. > It needs to be able to purge this cache when the entries expire, so it needs > to know the time to figure out how old the cache entries are. > If we eliminate this cache and just use the underlying OpenSSL cache then we > wouldn't need to know the time and this code would be platform independent > (or at least as platform independent as OpenSSL code itself). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1304) SSL code shouldn't need to know the time (shouldn't use the platform dependent parts of proton-c)
[ https://issues.apache.org/jira/browse/PROTON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496458#comment-15496458 ] ASF subversion and git services commented on PROTON-1304: - Commit ce79d1ca2995cb7d990b6c19ec1e86028410c6ad in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ce79d1c ] PROTON-1304: Changed OpenSSL interface code to not need time at all - Used the openssl session client cache without having own cache that needs expiring. > SSL code shouldn't need to know the time (shouldn't use the platform > dependent parts of proton-c) > - > > Key: PROTON-1304 > URL: https://issues.apache.org/jira/browse/PROTON-1304 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Currently the interface to OpenSSL keeps it's own cache of sessions separate > from the cache held in OpenSSL itself. > It needs to be able to purge this cache when the entries expire, so it needs > to know the time to figure out how old the cache entries are. > If we eliminate this cache and just use the underlying OpenSSL cache then we > wouldn't need to know the time and this code would be platform independent > (or at least as platform independent as OpenSSL code itself). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1304) SSL code shouldn't need to know the time (shouldn't use the platform dependent parts of proton-c)
[ https://issues.apache.org/jira/browse/PROTON-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494231#comment-15494231 ] ASF GitHub Bot commented on PROTON-1304: GitHub user astitcher opened a pull request: https://github.com/apache/qpid-proton/pull/80 PROTON-1304: Changed OpenSSL interface code to not need time at all This PR is specially for @kgiusti to review - Used the openssl session client cache without having own cache that needs expiring. You can merge this pull request into a Git repository by running: $ git pull https://github.com/astitcher/qpid-proton openssl-session-cache Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 > SSL code shouldn't need to know the time (shouldn't use the platform > dependent parts of proton-c) > - > > Key: PROTON-1304 > URL: https://issues.apache.org/jira/browse/PROTON-1304 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > Currently the interface to OpenSSL keeps it's own cache of sessions separate > from the cache held in OpenSSL itself. > It needs to be able to purge this cache when the entries expire, so it needs > to know the time to figure out how old the cache entries are. > If we eliminate this cache and just use the underlying OpenSSL cache then we > wouldn't need to know the time and this code would be platform independent > (or at least as platform independent as OpenSSL code itself). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
