[jira] [Commented] (PROTON-1535) Can't set hostname on SASL-INIT through sasl plugin interface

2017-08-17 Thread Gordon Sim (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130138#comment-16130138
 ] 

Gordon Sim commented on PROTON-1535:


See https://issues.apache.org/jira/browse/PROTON-1542 for the public API.

> Can't set hostname on SASL-INIT through sasl plugin interface
> -
>
> Key: PROTON-1535
> URL: https://issues.apache.org/jira/browse/PROTON-1535
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
> Fix For: proton-c-0.18.0
>
>
> There is no way to set the hostname in the SASL-INIT frame that is sent out 
> by proton. This is needed if the server will use that hostname to determine 
> the realm/domain against which to authenticate in a multi-tenant environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1535) Can't set hostname on SASL-INIT through sasl plugin interface

2017-08-11 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123908#comment-16123908
 ] 

ASF subversion and git services commented on PROTON-1535:
-

Commit 46f3007c4cad01891a2993e368f9b12e02aa in qpid-proton's branch 
refs/heads/master from [~gsim]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=46f3007 ]

PROTON-1535: allow plugins to set the hostname sent out in sasl-int frames


> Can't set hostname on SASL-INIT through sasl plugin interface
> -
>
> Key: PROTON-1535
> URL: https://issues.apache.org/jira/browse/PROTON-1535
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
> Fix For: proton-c-0.18.0
>
>
> There is no way to set the hostname in the SASL-INIT frame that is sent out 
> by proton. This is needed if the server will use that hostname to determine 
> the realm/domain against which to authenticate in a multi-tenant environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1535) Can't set hostname on SASL-INIT through sasl plugin interface

2017-08-11 Thread Andrew Stitcher (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123894#comment-16123894
 ] 

Andrew Stitcher commented on PROTON-1535:
-

Yeah. By 'in general' I meant should proton do this always, or rather if 
proton-c can't do this are there some applications that it won't work for?

But in any case that should be a new and separate JIRA.

> Can't set hostname on SASL-INIT through sasl plugin interface
> -
>
> Key: PROTON-1535
> URL: https://issues.apache.org/jira/browse/PROTON-1535
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
> Fix For: proton-c-0.18.0
>
>
> There is no way to set the hostname in the SASL-INIT frame that is sent out 
> by proton. This is needed if the server will use that hostname to determine 
> the realm/domain against which to authenticate in a multi-tenant environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1535) Can't set hostname on SASL-INIT

2017-08-11 Thread Gordon Sim (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123867#comment-16123867
 ] 

Gordon Sim commented on PROTON-1535:


Yes, it is compliant. By 'doing this in general' do you mean setting it by 
default? If so, possibly, but then you would need a more public api (to disable 
or alter the default where needed). Thats true for the second question also I 
think, i.e. you might indeed want a public api that lets you read what has been 
sent from outside the sasl plugin (within the plugin there is already a method 
to read it). I could clarify in the title for this bug that it covers the new 
sasl plugin interface only? (Then the decision to have a public api for general 
use if needed can be considered separately).

> Can't set hostname on SASL-INIT
> ---
>
> Key: PROTON-1535
> URL: https://issues.apache.org/jira/browse/PROTON-1535
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
> Fix For: proton-c-0.18.0
>
>
> There is no way to set the hostname in the SASL-INIT frame that is sent out 
> by proton. This is needed if the server will use that hostname to determine 
> the realm/domain against which to authenticate in a multi-tenant environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1535) Can't set hostname on SASL-INIT

2017-08-11 Thread Andrew Stitcher (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123730#comment-16123730
 ] 

Andrew Stitcher commented on PROTON-1535:
-

The fix looks fine (assuming the frame that is generated is still protocol 
compliant).

A question does arise though - should we be doing this in general?

A second question is how are you getting to the local fqdn at the other end 
seeing as proton doesn't handle it (or does it?).

> Can't set hostname on SASL-INIT
> ---
>
> Key: PROTON-1535
> URL: https://issues.apache.org/jira/browse/PROTON-1535
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
> Fix For: proton-c-0.18.0
>
>
> There is no way to set the hostname in the SASL-INIT frame that is sent out 
> by proton. This is needed if the server will use that hostname to determine 
> the realm/domain against which to authenticate in a multi-tenant environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org



[jira] [Commented] (PROTON-1535) Can't set hostname on SASL-INIT

2017-08-11 Thread Gordon Sim (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123677#comment-16123677
 ] 

Gordon Sim commented on PROTON-1535:


Possible fix: https://reviews.apache.org/r/61596/

> Can't set hostname on SASL-INIT
> ---
>
> Key: PROTON-1535
> URL: https://issues.apache.org/jira/browse/PROTON-1535
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Gordon Sim
>Assignee: Andrew Stitcher
> Fix For: proton-c-0.18.0
>
>
> There is no way to set the hostname in the SASL-INIT frame that is sent out 
> by proton. This is needed if the server will use that hostname to determine 
> the realm/domain against which to authenticate in a multi-tenant environment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org