[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127388#comment-17127388
]
ASF subversion and git services commented on PROTON-2225:
-
Commit caaa9459e77a593017fe4cfdea883bd21f66bf67 in qpid-proton's branch
refs/heads/master from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=caaa945 ]
PROTON-2225: adjust valgrind.supp for yet another form of threaderciser leak
(#258)
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==by 0x40362D: proactor_thread (threaderciser.c:473)
> ==17017==by 0x483E568: mythread_wrapper (in
>
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17127387#comment-17127387
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek merged pull request #258:
URL: https://github.com/apache/qpid-proton/pull/258
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==by
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126860#comment-17126860
]
ASF GitHub Bot commented on PROTON-2225:
codecov-commenter commented on pull request #258:
URL: https://github.com/apache/qpid-proton/pull/258#issuecomment-639554564
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/258?src=pr=h1)
Report
> Merging
[#258](https://codecov.io/gh/apache/qpid-proton/pull/258?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/65a5d9e837cf8de3024e7039dc7f5f2175d13461=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/258?src=pr=tree)
```diff
@@Coverage Diff @@
## master #258 +/- ##
==
+ Coverage 83.05% 83.09% +0.04%
==
Files 338 339 +1
Lines 4143141520 +89
==
+ Hits3441034501 +91
+ Misses 7021 7019 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/258?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/258/diff?src=pr=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==)
| `81.10% <0.00%> (-0.17%)` | :arrow_down: |
|
[c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/258/diff?src=pr=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=)
| `83.21% <0.00%> (-0.06%)` | :arrow_down: |
|
[ruby/tests/test\_interop.rb](https://codecov.io/gh/apache/qpid-proton/pull/258/diff?src=pr=tree#diff-cnVieS90ZXN0cy90ZXN0X2ludGVyb3AucmI=)
| `95.55% <0.00%> (ø)` | |
|
[ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/258/diff?src=pr=tree#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==)
| `96.10% <0.00%> (+3.89%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/258?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/258?src=pr=footer).
Last update
[65a5d9e...fd0e50d](https://codecov.io/gh/apache/qpid-proton/pull/258?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
>
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126804#comment-17126804
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek opened a new pull request #258:
URL: https://github.com/apache/qpid-proton/pull/258
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118939#comment-17118939
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek merged pull request #252:
URL: https://github.com/apache/qpid-proton/pull/252
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==by
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118938#comment-17118938
]
ASF subversion and git services commented on PROTON-2225:
-
Commit b34bbea0e34901b8e25b1c74715fcc5a5229ad65 in qpid-proton's branch
refs/heads/master from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=b34bbea ]
PROTON-2225: adjust valgrind.supp to cover both forms of the leak (#252)
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==by 0x40362D: proactor_thread (threaderciser.c:473)
> ==17017==by 0x483E568: mythread_wrapper (in
>
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[ https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118908#comment-17118908 ] ASF GitHub Bot commented on PROTON-2225: codecov-commenter edited a comment on pull request #252: URL: https://github.com/apache/qpid-proton/pull/252#issuecomment-635479840 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=h1) Report > Merging [#252](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/db01c09748ff950d454c9d777de16cf442e37631=desc) will **decrease** coverage by `9.99%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #252 +/- ## === - Coverage 93.08% 83.09% -10.00% === Files 62 339 +277 Lines417741362+37185 === + Hits 388834368+30480 - Misses289 6994 +6705 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=tree) | Coverage Δ | | |---|---|---| | [cpp/src/test\_bits.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy90ZXN0X2JpdHMuaHBw) | `43.90% <0.00%> (ø)` | | | [c/tests/pn\_test\_proactor.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Yy90ZXN0cy9wbl90ZXN0X3Byb2FjdG9yLmhwcA==) | `100.00% <0.00%> (ø)` | | | [cpp/src/link.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy9saW5rLmNwcA==) | `82.75% <0.00%> (ø)` | | | [cpp/include/proton/sender.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3NlbmRlci5ocHA=) | `28.57% <0.00%> (ø)` | | | [c/tests/refcount\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Yy90ZXN0cy9yZWZjb3VudF90ZXN0LmNwcA==) | `100.00% <0.00%> (ø)` | | | [cpp/include/proton/value.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3ZhbHVlLmhwcA==) | `100.00% <0.00%> (ø)` | | | [cpp/src/receiver\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy9yZWNlaXZlcl9vcHRpb25zLmNwcA==) | `82.45% <0.00%> (ø)` | | | [cpp/include/proton/codec/unordered\_map.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL3Vub3JkZXJlZF9tYXAuaHBw) | `100.00% <0.00%> (ø)` | | | [cpp/src/duration.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy9kdXJhdGlvbi5jcHA=) | `83.33% <0.00%> (ø)` | | | [cpp/examples/ssl\_client\_cert.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL2V4YW1wbGVzL3NzbF9jbGllbnRfY2VydC5jcHA=) | `89.47% <0.00%> (ø)` | | | ... and [267 more](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=footer). Last update [db01c09...a0fde56](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Set -DTHREADERCISER=ON by default, to prevent regressions > - > > Key: PROTON-2225 > URL: https://issues.apache.org/jira/browse/PROTON-2225 > Project: Qpid Proton > Issue Type: Test > Components: build >Affects Versions: proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: proton-c-0.32.0 > > > Previously, the test stopped compiling, as fixed in PROTON-2120. The reason > the test is disabled is that the test is failing when it is run. > Instead of disabling the test, it would
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[ https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118906#comment-17118906 ] ASF GitHub Bot commented on PROTON-2225: codecov-commenter commented on pull request #252: URL: https://github.com/apache/qpid-proton/pull/252#issuecomment-635479840 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=h1) Report > Merging [#252](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/db01c09748ff950d454c9d777de16cf442e37631=desc) will **decrease** coverage by `9.99%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #252 +/- ## === - Coverage 93.08% 83.09% -10.00% === Files 62 339 +277 Lines417741362+37185 === + Hits 388834368+30480 - Misses289 6994 +6705 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=tree) | Coverage Δ | | |---|---|---| | [c/src/core/log.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Yy9zcmMvY29yZS9sb2cuYw==) | `21.73% <0.00%> (ø)` | | | [cpp/src/endpoint.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy9lbmRwb2ludC5jcHA=) | `72.72% <0.00%> (ø)` | | | [python/proton/utils.py](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-cHl0aG9uL3Byb3Rvbi91dGlscy5weQ==) | `100.00% <0.00%> (ø)` | | | [cpp/src/link.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy9saW5rLmNwcA==) | `82.75% <0.00%> (ø)` | | | [cpp/src/transfer.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy90cmFuc2Zlci5jcHA=) | `33.33% <0.00%> (ø)` | | | [.../test\_PROTON\_1709\_application\_event\_object\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzE3MDlfYXBwbGljYXRpb25fZXZlbnRfb2JqZWN0X2xlYWsucHk=) | `100.00% <0.00%> (ø)` | | | [python/proton/\_endpoints.py](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-cHl0aG9uL3Byb3Rvbi9fZW5kcG9pbnRzLnB5) | `91.89% <0.00%> (ø)` | | | [cpp/include/proton/binary.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2JpbmFyeS5ocHA=) | `100.00% <0.00%> (ø)` | | | [c/src/handlers/handshaker.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Yy9zcmMvaGFuZGxlcnMvaGFuZHNoYWtlci5j) | `89.74% <0.00%> (ø)` | | | [cpp/src/delivery.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy9kZWxpdmVyeS5jcHA=) | `70.00% <0.00%> (ø)` | | | ... and [267 more](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=footer). Last update [db01c09...a0fde56](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Set -DTHREADERCISER=ON by default, to prevent regressions > - > > Key: PROTON-2225 > URL: https://issues.apache.org/jira/browse/PROTON-2225 > Project: Qpid Proton > Issue Type: Test > Components: build >Affects Versions: proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: proton-c-0.32.0 > > > Previously, the test stopped compiling, as fixed in PROTON-2120. The reason > the test is disabled is that the test is failing when it is run. > Instead of disabling the test, it would be better to have the test
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[ https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118907#comment-17118907 ] ASF GitHub Bot commented on PROTON-2225: codecov-commenter edited a comment on pull request #252: URL: https://github.com/apache/qpid-proton/pull/252#issuecomment-635479840 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=h1) Report > Merging [#252](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/db01c09748ff950d454c9d777de16cf442e37631=desc) will **decrease** coverage by `9.99%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #252 +/- ## === - Coverage 93.08% 83.09% -10.00% === Files 62 339 +277 Lines417741362+37185 === + Hits 388834368+30480 - Misses289 6994 +6705 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=tree) | Coverage Δ | | |---|---|---| | [cpp/examples/client.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL2V4YW1wbGVzL2NsaWVudC5jcHA=) | `86.84% <0.00%> (ø)` | | | [cpp/src/reconnect\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy9yZWNvbm5lY3Rfb3B0aW9ucy5jcHA=) | `66.66% <0.00%> (ø)` | | | [c/tests/engine\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Yy90ZXN0cy9lbmdpbmVfdGVzdC5jcHA=) | `100.00% <0.00%> (ø)` | | | [python/proton/\_utils.py](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-cHl0aG9uL3Byb3Rvbi9fdXRpbHMucHk=) | `71.48% <0.00%> (ø)` | | | [c/src/core/framing.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Yy9zcmMvY29yZS9mcmFtaW5nLmM=) | `96.00% <0.00%> (ø)` | | | [c/tests/fuzz/fuzz-url.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Yy90ZXN0cy9mdXp6L2Z1enotdXJsLmM=) | `100.00% <0.00%> (ø)` | | | [c/src/proactor/proactor-internal.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Yy9zcmMvcHJvYWN0b3IvcHJvYWN0b3ItaW50ZXJuYWwuYw==) | `84.21% <0.00%> (ø)` | | | [cpp/src/link\_namer.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy9saW5rX25hbWVyLmNwcA==) | `100.00% <0.00%> (ø)` | | | [cpp/src/connection\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Y3BwL3NyYy9jb25uZWN0aW9uX29wdGlvbnMuY3Bw) | `90.69% <0.00%> (ø)` | | | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.30% <0.00%> (ø)` | | | ... and [267 more](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=footer). Last update [db01c09...a0fde56](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Set -DTHREADERCISER=ON by default, to prevent regressions > - > > Key: PROTON-2225 > URL: https://issues.apache.org/jira/browse/PROTON-2225 > Project: Qpid Proton > Issue Type: Test > Components: build >Affects Versions: proton-c-0.31.0 >Reporter: Jiri Daněk >Assignee: Jiri Daněk >Priority: Major > Fix For: proton-c-0.32.0 > > > Previously, the test stopped compiling, as fixed in PROTON-2120. The reason > the test is disabled is that the test is failing when it is run. > Instead of disabling the test, it would be better to have the test running, > suppress the reported
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118863#comment-17118863
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek opened a new pull request #252:
URL: https://github.com/apache/qpid-proton/pull/252
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117355#comment-17117355
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek opened a new pull request #250:
URL: https://github.com/apache/qpid-proton/pull/250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117342#comment-17117342
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek merged pull request #250:
URL: https://github.com/apache/qpid-proton/pull/250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==by
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117319#comment-17117319
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek commented on a change in pull request #250:
URL: https://github.com/apache/qpid-proton/pull/250#discussion_r430670130
##
File path: c/tests/CMakeLists.txt
##
@@ -88,7 +88,8 @@ if (CMAKE_CXX_COMPILER)
option(THREADERCISER "Run the threaderciser concurrency tests"
${DEFAULT_THREADERCISER})
if (THREADERCISER)
add_executable(c-threaderciser threaderciser.c)
- set_target_properties(c-threaderciser PROPERTIES COMPILE_FLAGS
"${CMAKE_C_FLAGS} ${C_WARNING_FLAGS}")
+ set_target_properties(c-threaderciser
+ PROPERTIES COMPILE_FLAGS "${COMPILE_LANGUAGE_FLAGS}
${CMAKE_C_FLAGS} ${C_WARNING_FLAGS}")
Review comment:
```suggestion
set_target_properties(c-threaderciser
PROPERTIES COMPILE_FLAGS "${COMPILE_LANGUAGE_FLAGS} ${CMAKE_C_FLAGS}
${C_WARNING_FLAGS}")
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117021#comment-17117021
]
ASF subversion and git services commented on PROTON-2225:
-
Commit f6df369a06bb459ccc67ee309989628a5dfebf35 in qpid-proton's branch
refs/heads/master from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=f6df369 ]
PROTON-2225: compile c-threaderciser with COMPILE_LANGUAGE_FLAGS (#250)
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
> Fix For: proton-c-0.32.0
>
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==by 0x40362D: proactor_thread (threaderciser.c:473)
> ==17017==by 0x483E568: mythread_wrapper (in
>
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114311#comment-17114311
]
ASF subversion and git services commented on PROTON-2225:
-
Commit bc4a1db33937f02010d5accdc303b3a6bf5db287 in qpid-proton's branch
refs/heads/master from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=bc4a1db ]
PROTON-2225: enable threaderciser by default, suppress race checkers (#247)
* NO-JIRA: specify explicitly the compiler used on macOS
On Travis on macOS, gcc is aliased to clang. This way, we won't
have a misleading line in Travis report about the compiler.
* PROTON-2225: enable threaderciser by default, suppress race checkers
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114313#comment-17114313
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek merged pull request #247:
URL: https://github.com/apache/qpid-proton/pull/247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==by 0x40362D: proactor_thread
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114312#comment-17114312
]
ASF subversion and git services commented on PROTON-2225:
-
Commit bc4a1db33937f02010d5accdc303b3a6bf5db287 in qpid-proton's branch
refs/heads/master from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-proton.git;h=bc4a1db ]
PROTON-2225: enable threaderciser by default, suppress race checkers (#247)
* NO-JIRA: specify explicitly the compiler used on macOS
On Travis on macOS, gcc is aliased to clang. This way, we won't
have a misleading line in Travis report about the compiler.
* PROTON-2225: enable threaderciser by default, suppress race checkers
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113637#comment-17113637
]
ASF GitHub Bot commented on PROTON-2225:
codecov-commenter edited a comment on pull request #247:
URL: https://github.com/apache/qpid-proton/pull/247#issuecomment-632405481
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=h1)
Report
> Merging
[#247](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/7f86fa4eb261fad7ade33f62acf3d2ce115e9497=desc)
will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=tree)
```diff
@@Coverage Diff @@
## master #247 +/- ##
==
+ Coverage 81.56% 81.74% +0.18%
==
Files 270 271 +1
Lines 3643936720 +281
==
+ Hits2972230018 +296
+ Misses 6717 6702 -15
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/247/diff?src=pr=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=)
| `83.27% <0.00%> (ø)` | |
|
[c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/247/diff?src=pr=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==)
| `81.21% <0.00%> (+3.30%)` | :arrow_up: |
|
[c/src/proactor/proactor-internal.c](https://codecov.io/gh/apache/qpid-proton/pull/247/diff?src=pr=tree#diff-Yy9zcmMvcHJvYWN0b3IvcHJvYWN0b3ItaW50ZXJuYWwuYw==)
| `84.21% <0.00%> (+5.26%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=footer).
Last update
[7f86fa4...a447088](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
>
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113634#comment-17113634
]
ASF GitHub Bot commented on PROTON-2225:
codecov-commenter commented on pull request #247:
URL: https://github.com/apache/qpid-proton/pull/247#issuecomment-632405481
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=h1)
Report
> Merging
[#247](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-proton/commit/7f86fa4eb261fad7ade33f62acf3d2ce115e9497=desc)
will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=tree)
```diff
@@Coverage Diff @@
## master #247 +/- ##
==
+ Coverage 81.56% 81.74% +0.18%
==
Files 270 271 +1
Lines 3643936720 +281
==
+ Hits2972230018 +296
+ Misses 6717 6702 -15
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/247/diff?src=pr=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=)
| `83.27% <0.00%> (ø)` | |
|
[c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/247/diff?src=pr=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==)
| `81.21% <0.00%> (+3.30%)` | :arrow_up: |
|
[c/src/proactor/proactor-internal.c](https://codecov.io/gh/apache/qpid-proton/pull/247/diff?src=pr=tree#diff-Yy9zcmMvcHJvYWN0b3IvcHJvYWN0b3ItaW50ZXJuYWwuYw==)
| `84.21% <0.00%> (+5.26%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=footer).
Last update
[7f86fa4...a447088](https://codecov.io/gh/apache/qpid-proton/pull/247?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
>
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113584#comment-17113584
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek edited a comment on pull request #247:
URL: https://github.com/apache/qpid-proton/pull/247#issuecomment-632367227
On Travis, the test takes
- 85.55 sec under Valgrind Memcheck
- 1.17 sec under ASan
- 1.18 sec under TSan
- 1.09 sec in -DCMAKE_BUILD_TYPE=Coverage job
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113569#comment-17113569
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek commented on pull request #247:
URL: https://github.com/apache/qpid-proton/pull/247#issuecomment-632367227
On Travis, the test takes
- 85.55 sec under Valgrind Memcheck
- 1.17 sec under ASan
- 1.18 sec under TSan
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40:
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113114#comment-17113114
]
Jiri Daněk commented on PROTON-2225:
Another flaky possibility, freeze on macOS with libuv,
[https://travis-ci.org/github/apache/qpid-proton/jobs/689218930#L1941].
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll (epoll.c:2676)
> ==17017==by 0x4856402: pn_proactor_wait (epoll.c:2803)
> ==17017==by 0x40362D: proactor_thread (threaderciser.c:473)
> ==17017==by 0x483E568: mythread_wrapper (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x4864EDC: start_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
>
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113104#comment-17113104
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek commented on pull request #247:
URL: https://github.com/apache/qpid-proton/pull/247#issuecomment-632040004
@astitcher weird, my AppVeyor jobs failed with build errors, but the ones on
Apache account passed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disabled is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks held: 1, at address 0x4FD4380
> ==17017==at 0x4855143: post_event (epoll.c:2429)
> ==17017==by 0x4855C40: proactor_do_epoll
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112134#comment-17112134
]
ASF GitHub Bot commented on PROTON-2225:
jiridanek opened a new pull request #247:
URL: https://github.com/apache/qpid-proton/pull/247
@astitcher Can you please help me figure out why is this failing on Windows
(AppVeyor)? I cannot even identify the cause in the error ouptut. (Link here,
or one of the previous builds at
https://ci.appveyor.com/project/jirkadanek/qpid-proton/builds/33002940)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disable is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Block was alloc'd by thread #1
> ==17017==
> ==17017== Possible data race during read of size 4 at 0x4FDF90C by thread #5
> ==17017== Locks
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112121#comment-17112121
]
Jiri Daněk commented on PROTON-2225:
Another flaky occurence, assertion fail on macOS with libuv,
https://travis-ci.com/github/jiridanek/qpid-proton/jobs/337488524#L1931
{noformat}
6: Test command: /usr/local/opt/python/libexec/bin/python
"/Users/travis/build/jiridanek/qpid-proton/scripts/env.py" "--"
"/Users/travis/build/jiridanek/qpid-proton/build/c/tests/c-threaderciser"
6: Test timeout computed to be: 1500
6: threaderciser start: threads=8, time=1, actions=[listen, close-listen,
connect, close-connect, wake, timeout, cancel-timeout]
6: Assertion failed: (p->active > 0), function remove_active_lh, file
/Users/travis/build/jiridanek/qpid-proton/c/src/proactor/libuv.c, line 392.
6/31 Test #6: c-threaderciser ..***Failed0.18 sec
{noformat}
The test itself is not deterministic, and it is running for a fairly short time
in the CI, so it is actually expected that the failures will be flaky.
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disable is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails under helgrind with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
> ==17017==
> ==17017== Lock at 0x4FD4380 was first observed
> ==17017==at 0x483F7BD: pthread_mutex_init (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x484EBFF: pmutex_init (epoll.c:137)
> ==17017==by 0x485412D: pn_proactor (epoll.c:2104)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
> ==17017==by 0x403BD2: main (threaderciser.c:564)
> ==17017== Address 0x4fd4380 is 576 bytes inside a block of size 896 alloc'd
> ==17017==at 0x483A9F2: calloc (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x48540BD: pn_proactor (epoll.c:2099)
> ==17017==by 0x402F2D: global_init (threaderciser.c:335)
>
[jira] [Commented] (PROTON-2225) Set -DTHREADERCISER=ON by default, to prevent regressions
[
https://issues.apache.org/jira/browse/PROTON-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112101#comment-17112101
]
Jiri Daněk commented on PROTON-2225:
Furthermore, I've seen it sometimes freeze on older clang (flaky on xenial
https://travis-ci.com/github/jiridanek/qpid-proton/jobs/337482058#L2049,
freezes reliably on xcode
https://travis-ci.com/github/jiridanek/qpid-proton/jobs/337466798#L2165) and
flaky leak on gcc xenial,
https://travis-ci.com/github/jiridanek/qpid-proton/jobs/337466791#L1779.
{noformat}
6: Test command: /opt/pyenv/shims/python
"/home/travis/build/jiridanek/qpid-proton/scripts/env.py" "--"
"TEST_EXE_PREFIX=/usr/bin/valgrind --tool=memcheck --leak-check=full
--error-exitcode=42 --quiet
--suppressions=/home/travis/build/jiridanek/qpid-proton/tests/valgrind.supp"
"/usr/bin/valgrind" "--tool=memcheck" "--leak-check=full" "--error-exitcode=42"
"--quiet"
"--suppressions=/home/travis/build/jiridanek/qpid-proton/tests/valgrind.supp"
"/home/travis/build/jiridanek/qpid-proton/build/c/tests/c-threaderciser"
6: Test timeout computed to be: 1500
6: threaderciser start: threads=8, time=1, actions=[listen, close-listen,
connect, close-connect, wake, timeout, cancel-timeout]
6: ==11750== 64 bytes in 1 blocks are definitely lost in loss record 1 of 1
6: ==11750==at 0x4C2DB8F: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
6: ==11750==by 0x40217A: connection_ctx_new (threaderciser.c:211)
6: ==11750==by 0x40217A: cpool_connect.part.3 (threaderciser.c:226)
6: ==11750==by 0x402CC6: cpool_connect (threaderciser.c:225)
6: ==11750==by 0x402CC6: handle (threaderciser.c:425)
6: ==11750==by 0x402CC6: proactor_thread (threaderciser.c:476)
6: ==11750==by 0x504E6B9: start_thread (pthread_create.c:333)
6: ==11750==
6/46 Test #6: c-threaderciser ..***Failed 95.41 sec
{noformat}
> Set -DTHREADERCISER=ON by default, to prevent regressions
> -
>
> Key: PROTON-2225
> URL: https://issues.apache.org/jira/browse/PROTON-2225
> Project: Qpid Proton
> Issue Type: Test
> Components: build
>Affects Versions: proton-c-0.31.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> Previously, the test stopped compiling, as fixed in PROTON-2120. The reason
> the test is disable is that the test is failing when it is run.
> Instead of disabling the test, it would be better to have the test running,
> suppress the reported errors and fill a jira to get them fixed eventually.
> This requires writing suppressions for both helgrind and tsan.
> Now that fd-limit test is disabled (PROTON-2172), we should have some other
> test to highlight issues from PROTON-2133.
> Current state is that threaderciser test builds and fails with
> {noformat}
> threaderciser start: threads=8, time=1, actions=[listen, close-listen,
> connect, close-connect, wake, timeout, cancel-timeout]
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #5 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C92: main (threaderciser.c:572)
> ==17017==
> ==17017== ---Thread-Announcement--
> ==17017==
> ==17017== Thread #2 was created
> ==17017==at 0x4D69A3E: clone (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libc-2.30.so)
> ==17017==by 0x4863DBB: create_thread (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x486568B: pthread_create@@GLIBC_2.2.5 (in
> /nix/store/6m2k8kx8h216jlx9dg3lp4m90bz05yck-glibc-2.30/lib/libpthread-2.30.so)
> ==17017==by 0x483E374: pthread_create_WRK (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x483F46F: pthread_create@* (in
> /nix/store/6glsqxyngs9kjkx9mqhshwfi93qfsw8q-valgrind-3.15.0/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
> ==17017==by 0x403C64: main (threaderciser.c:571)
> ==17017==
> ==17017==
