[jira] [Commented] (QPID-7366) [Java Broker] Add Management operation to VirtualHost to allow publishing of messages through management
[ https://issues.apache.org/jira/browse/QPID-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536150#comment-15536150 ] ASF subversion and git services commented on QPID-7366: --- Commit 1762915 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1762915 ] QPID-7366: [Java Broker] Remove additional publish guards - these belong in the message conversion layer > [Java Broker] Add Management operation to VirtualHost to allow publishing of > messages through management > > > Key: QPID-7366 > URL: https://issues.apache.org/jira/browse/QPID-7366 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-6.1 > > > Sometimes it is useful to be able to publish messages into the broker without > requiring an AMQP client. For this we can add a management operation to > allow for the publishing of messages over HTTP. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7366) [Java Broker] Add Management operation to VirtualHost to allow publishing of messages through management
[ https://issues.apache.org/jira/browse/QPID-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529154#comment-15529154 ] Rob Godfrey commented on QPID-7366: --- It seems a little strange to me to do checks on the headers in AbstractVirtualHost (e.g. for keys greater than 255 characters) when the same situation may occur from (for example) a 0-10 published message being converted to a 0-8 receiver. > [Java Broker] Add Management operation to VirtualHost to allow publishing of > messages through management > > > Key: QPID-7366 > URL: https://issues.apache.org/jira/browse/QPID-7366 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-6.1 > > > Sometimes it is useful to be able to publish messages into the broker without > requiring an AMQP client. For this we can add a management operation to > allow for the publishing of messages over HTTP. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7366) [Java Broker] Add Management operation to VirtualHost to allow publishing of messages through management
[ https://issues.apache.org/jira/browse/QPID-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515979#comment-15515979 ] Keith Wall commented on QPID-7366: -- Rob - can you review and ensure that this is an acceptable compromise for 6.1. > [Java Broker] Add Management operation to VirtualHost to allow publishing of > messages through management > > > Key: QPID-7366 > URL: https://issues.apache.org/jira/browse/QPID-7366 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-6.1 > > > Sometimes it is useful to be able to publish messages into the broker without > requiring an AMQP client. For this we can add a management operation to > allow for the publishing of messages over HTTP. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7366) [Java Broker] Add Management operation to VirtualHost to allow publishing of messages through management
[ https://issues.apache.org/jira/browse/QPID-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515975#comment-15515975 ] Keith Wall commented on QPID-7366: -- I've made some hopefully reasonable pragmatic changes to publishMessage so it guards against input that would cause our current message converters to fail. Jira will be raised to mature the message converters. > [Java Broker] Add Management operation to VirtualHost to allow publishing of > messages through management > > > Key: QPID-7366 > URL: https://issues.apache.org/jira/browse/QPID-7366 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-6.1 > > > Sometimes it is useful to be able to publish messages into the broker without > requiring an AMQP client. For this we can add a management operation to > allow for the publishing of messages over HTTP. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7366) [Java Broker] Add Management operation to VirtualHost to allow publishing of messages through management
[ https://issues.apache.org/jira/browse/QPID-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15515971#comment-15515971 ] ASF subversion and git services commented on QPID-7366: --- Commit 1762041 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1762041 ] QPID-7366: [Java Broker] Pragmatically guard #publishMessage against application header key/values that would cause message converter to fail. > [Java Broker] Add Management operation to VirtualHost to allow publishing of > messages through management > > > Key: QPID-7366 > URL: https://issues.apache.org/jira/browse/QPID-7366 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Sometimes it is useful to be able to publish messages into the broker without > requiring an AMQP client. For this we can add a management operation to > allow for the publishing of messages over HTTP. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7366) [Java Broker] Add Management operation to VirtualHost to allow publishing of messages through management
[
https://issues.apache.org/jira/browse/QPID-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513665#comment-15513665
]
Keith Wall commented on QPID-7366:
--
Currently, the new feature allows me to inject a message containing a header
with an empty key into the system. If the such a message is converted for a
0-8 client, the Broker fails with the following exception. In 0-10 the same
message fails on the client side on receipt.
In AMQP 0-9 the headers are transported as a field table. Of field tables, the
spec says (4.2.5.5) says that "Field names MUST start with a letter, '$' or '#'
and may continue with letters, '$' or '#', digits, or underlines, to a maximum
length of 128 characters.". So this implies that message header names cannot
be empty. In AMQP 0-10, the spec doesn't impose the same restriction - it uses
a 0-10 map for the application headers with str8 as keys. There is no
restriction disallowing empty keys.
As JMS disallows empty message property names. I suggest that
{{publishMessage}} imposes the same restriction.
{noformat}
2016-09-22 16:25:06,779 ERROR [IO-/127.0.0.1:52202]
o.a.q.t.u.InternalBrokerHolder Uncaught exception from thread
IO-/127.0.0.1:52202
java.lang.IllegalArgumentException: Property name must not be the empty string
at
org.apache.qpid.framing.FieldTable.checkPropertyName(FieldTable.java:778)
~[classes/:na]
at org.apache.qpid.framing.FieldTable.setProperty(FieldTable.java:140)
~[classes/:na]
at org.apache.qpid.framing.FieldTable.setString(FieldTable.java:558)
~[classes/:na]
at org.apache.qpid.framing.FieldTable.setObject(FieldTable.java:692)
~[classes/:na]
at org.apache.qpid.framing.FieldTable.put(FieldTable.java:1044)
~[classes/:na]
at
org.apache.qpid.framing.FieldTable.convertToFieldTable(FieldTable.java:1210)
~[classes/:na]
at
org.apache.qpid.server.protocol.v0_8.MessageConverter_Internal_to_v0_8.convertMetaData(MessageConverter_Internal_to_v0_8.java:148)
~[classes/:na]
at
org.apache.qpid.server.protocol.v0_8.MessageConverter_Internal_to_v0_8.convertToStoredMessage(MessageConverter_Internal_to_v0_8.java:75)
~[classes/:na]
at
org.apache.qpid.server.protocol.v0_8.MessageConverter_Internal_to_v0_8.convert(MessageConverter_Internal_to_v0_8.java:69)
~[classes/:na]
at
org.apache.qpid.server.protocol.v0_8.MessageConverter_Internal_to_v0_8.convert(MessageConverter_Internal_to_v0_8.java:48)
~[classes/:na]
at
org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.convertToAMQMessage(ProtocolOutputConverterImpl.java:83)
~[classes/:na]
at
org.apache.qpid.server.protocol.v0_8.ProtocolOutputConverterImpl.writeDeliver(ProtocolOutputConverterImpl.java:69)
~[classes/:na]
{noformat}
> [Java Broker] Add Management operation to VirtualHost to allow publishing of
> messages through management
>
>
> Key: QPID-7366
> URL: https://issues.apache.org/jira/browse/QPID-7366
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Rob Godfrey
>Assignee: Keith Wall
> Fix For: qpid-java-6.1
>
>
> Sometimes it is useful to be able to publish messages into the broker without
> requiring an AMQP client. For this we can add a management operation to
> allow for the publishing of messages over HTTP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7366) [Java Broker] Add Management operation to VirtualHost to allow publishing of messages through management
[ https://issues.apache.org/jira/browse/QPID-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15452227#comment-15452227 ] Keith Wall commented on QPID-7366: -- Automated test case to be added and review. > [Java Broker] Add Management operation to VirtualHost to allow publishing of > messages through management > > > Key: QPID-7366 > URL: https://issues.apache.org/jira/browse/QPID-7366 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-6.1 > > > Sometimes it is useful to be able to publish messages into the broker without > requiring an AMQP client. For this we can add a management operation to > allow for the publishing of messages over HTTP. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7366) [Java Broker] Add Management operation to VirtualHost to allow publishing of messages through management
[ https://issues.apache.org/jira/browse/QPID-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397677#comment-15397677 ] ASF subversion and git services commented on QPID-7366: --- Commit 1754421 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1754421 ] QPID-7366 : Allow publishing of messages using a management operation > [Java Broker] Add Management operation to VirtualHost to allow publishing of > messages through management > > > Key: QPID-7366 > URL: https://issues.apache.org/jira/browse/QPID-7366 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Rob Godfrey >Assignee: Rob Godfrey > Fix For: qpid-java-6.1 > > > Sometimes it is useful to be able to publish messages into the broker without > requiring an AMQP client. For this we can add a management operation to > allow for the publishing of messages over HTTP. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
