[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656802#comment-15656802 ] Keith Wall commented on QPID-7447: -- These two commits belonged on this JIRA but were mistagged QPID-7477 (which didn't exist when the work was done). Author: rgodfrey Date: Mon Oct 17 18:34:59 2016 + QPID-7477 : a single update to credit should only result in one call to setSuspended git-svn-id: https://svn.apache.org/repos/asf/qpid/java/trunk@1765350 13f79535-47bb-0310-9956-ffa450edef68 commit ab4432187e2012e40b853d719fad25c267bfe51b Author: rgodfrey Date: Mon Oct 17 18:32:27 2016 + QPID-7477 : If a connection is already scheduled, there is no need to reschedule it git-svn-id: https://svn.apache.org/repos/asf/qpid/java/trunk@1765349 13f79535-47bb-0310-9956-ffa450edef68 > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592224#comment-15592224 ] ASF subversion and git services commented on QPID-7447: --- Commit 1765843 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1765843 ] QPID-7447 : Address review comments > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15585848#comment-15585848 ] Lorenz Quack commented on QPID-7447: r1764865 and r1764917 look okay to me. r1764918 : * StatisticsCounter$Sample#getRate does not return the rate but the absolute count. rename to getCount. similar lastRate. * If a peak occurs across two samples it will not be detected * The very first sample might be shorter than _period (e.g. if _start=9 and _period=10 then it will only be 1ms). to fix this we would have to subtract _start from every timestamp and start from sampleId=0 > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581566#comment-15581566 ] Lorenz Quack commented on QPID-7447: For the record, I had reviewed up to r1764479 and I had no comments. > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575528#comment-15575528 ] ASF subversion and git services commented on QPID-7447: --- Commit 1764918 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1764918 ] QPID-7447 : Remove synchronization on StatisticsCounter > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575525#comment-15575525 ] ASF subversion and git services commented on QPID-7447: --- Commit 1764917 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1764917 ] QPID-7447 : Fix test failures from last commit > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574950#comment-15574950 ] ASF subversion and git services commented on QPID-7447: --- Commit 1764865 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1764865 ] QPID-7447 : Cache authorization of publish message results on the session > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568951#comment-15568951 ] ASF subversion and git services commented on QPID-7447: --- Commit 1764479 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1764479 ] QPID-7447 : Small optimisations > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568436#comment-15568436 ] ASF subversion and git services commented on QPID-7447: --- Commit 1764440 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1764440 ] QPID-7447 : Small optimisations > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566456#comment-15566456 ] ASF subversion and git services commented on QPID-7447: --- Commit 1764339 from [~godfrer] in branch 'java/trunk' [ https://svn.apache.org/r1764339 ] QPID-7447 : Small optimisations > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562239#comment-15562239 ] ASF subversion and git services commented on QPID-7447: --- Commit 1764080 from [~lorenz.quack] in branch 'java/trunk' [ https://svn.apache.org/r1764080 ] QPID-7447: [Java Broker] Performance Improvements * Stop taking defensive copy in AMQConnection#getSessionModels() * Use Long instead of Date in TransactionTimeoutTicker * Prevent unnecessary iterator alloctions in SelectorThread when lists are empty > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1420#comment-1420 ] Lorenz Quack commented on QPID-7447: Code looks good. But In general I would prefer these code changes have comments on them explaining what the if() checks around the for loops are for performance reasons. Otherwise I can see myself or someone else coming in here in a couple of month and removing them because they seem redundant. > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552382#comment-15552382 ] ASF subversion and git services commented on QPID-7447: --- Commit 1763623 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1763623 ] QPID-7447: [Java Broker] Avoid empty iterator creation on handling of post-commit actions in store transaction > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552381#comment-15552381 ] ASF subversion and git services commented on QPID-7447: --- Commit 1763622 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1763622 ] QPID-7447: [Java Broker] Avoid empty iterator creation on iteration through tickers in AggregateTicker > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552383#comment-15552383 ] ASF subversion and git services commented on QPID-7447: --- Commit 1763624 from oru...@apache.org in branch 'java/trunk' [ https://svn.apache.org/r1763624 ] QPID-7447: [Java Broker] Avoid evaluation of default access control result twice when result is deferred > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551037#comment-15551037 ] ASF subversion and git services commented on QPID-7447: --- Commit 1763499 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1763499 ] QPID-7447: [Java Broker] Avoid empty iterator creation on SSL write path when no application data due to be written > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15549294#comment-15549294 ] ASF subversion and git services commented on QPID-7447: --- Commit 1763467 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1763467 ] QPID-7447: [Java Broker] Avoid empty iterator garbage when processing pending work for sessions with no consumers > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7447) Java Broker tuning improvements for v6.1 release
[ https://issues.apache.org/jira/browse/QPID-7447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545901#comment-15545901 ] ASF subversion and git services commented on QPID-7447: --- Commit 1763296 from [~k-wall] in branch 'java/trunk' [ https://svn.apache.org/r1763296 ] QPID-7447: [Java Broker] Avoid iterator garbage with NonBlockingConnection#getBufferedSize if no buffers remain > Java Broker tuning improvements for v6.1 release > > > Key: QPID-7447 > URL: https://issues.apache.org/jira/browse/QPID-7447 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-6.1 > > > Java Broker tuning improvements for v6.1 release -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org