[jira] [Commented] (QPID-7972) Virtual Host Node should be in error state if the underlying Virtual Host is in error state
[ https://issues.apache.org/jira/browse/QPID-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374546#comment-16374546 ] ASF GitHub Bot commented on QPID-7972: -- Github user asfgit closed the pull request at: https://github.com/apache/qpid-broker-j/pull/4 > Virtual Host Node should be in error state if the underlying Virtual Host is > in error state > --- > > Key: QPID-7972 > URL: https://issues.apache.org/jira/browse/QPID-7972 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-6.1.4 >Reporter: Adel Boutros >Priority: Major > > All details can be found here: > http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Broker-is-ready-even-if-an-error-is-occuring-on-startup-and-failStartupWithEre-tp7668029.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7972) Virtual Host Node should be in error state if the underlying Virtual Host is in error state
[ https://issues.apache.org/jira/browse/QPID-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374206#comment-16374206 ] ASF GitHub Bot commented on QPID-7972: -- Github user overmeulen commented on the issue: https://github.com/apache/qpid-broker-j/pull/4 Hello, Yes it would answer my use case. Actually I considered this option when doing the dev but I wasn't very fond of the Broker checking the whole tree of children nodes... I found it better to keep each node aware of just its direct children and it looked more correct to actually put the VirtualHostNode in ERRORed state too. Olivier > Virtual Host Node should be in error state if the underlying Virtual Host is > in error state > --- > > Key: QPID-7972 > URL: https://issues.apache.org/jira/browse/QPID-7972 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-6.1.4 >Reporter: Adel Boutros >Priority: Major > > All details can be found here: > http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Broker-is-ready-even-if-an-error-is-occuring-on-startup-and-failStartupWithEre-tp7668029.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7972) Virtual Host Node should be in error state if the underlying Virtual Host is in error state
[ https://issues.apache.org/jira/browse/QPID-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372900#comment-16372900 ] ASF GitHub Bot commented on QPID-7972: -- Github user k-wall commented on the issue: https://github.com/apache/qpid-broker-j/pull/4 Hello Olivier Thanks for the contribution. It is much appreciated. I am not too uncomfortable with the idea of special casing of the state behaviour for this one type of VirtualHostNode. I think in the long term, in general parent objects should have some way to react to the state of the their child, but I think this would want to be done within the common mechanics of AbstractConfiguredObject rather than applied piecemeal. It would be useful to be able to apply different rules - for instance a virtualhost might be considered critical whereas a BrokerSyslogLogger not. This would be a larger piece of work. I am looking for another way to solve your problem. Looking at `BrokerImpl#performActivation`, it currently checks the immediate decedents of the Broker if `broker.failStartupWithErroredChild` is set. We could alter this code so it can either check immediate descendants or the state of the entire tree. If the code had that ability would your use case by answered? > Virtual Host Node should be in error state if the underlying Virtual Host is > in error state > --- > > Key: QPID-7972 > URL: https://issues.apache.org/jira/browse/QPID-7972 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-6.1.4 >Reporter: Adel Boutros >Priority: Major > > All details can be found here: > http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Broker-is-ready-even-if-an-error-is-occuring-on-startup-and-failStartupWithEre-tp7668029.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7972) Virtual Host Node should be in error state if the underlying Virtual Host is in error state
[ https://issues.apache.org/jira/browse/QPID-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369342#comment-16369342 ] ASF GitHub Bot commented on QPID-7972: -- Github user adel-boutros commented on the issue: https://github.com/apache/qpid-broker-j/pull/4 Hello Olivier, It seems you are mixing in your pull request 2 different issues: One related to the Error state of the virtualHost and the other one about problems with different locales (I assume tests are failing on your machine because it is configured with the FR locale). In my opinion, it is better to split those into 2 different pull requests to have a better context > Virtual Host Node should be in error state if the underlying Virtual Host is > in error state > --- > > Key: QPID-7972 > URL: https://issues.apache.org/jira/browse/QPID-7972 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-6.1.4 >Reporter: Adel Boutros >Priority: Major > > All details can be found here: > http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Broker-is-ready-even-if-an-error-is-occuring-on-startup-and-failStartupWithEre-tp7668029.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7972) Virtual Host Node should be in error state if the underlying Virtual Host is in error state
[ https://issues.apache.org/jira/browse/QPID-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369308#comment-16369308 ] ASF GitHub Bot commented on QPID-7972: -- GitHub user overmeulen opened a pull request: https://github.com/apache/qpid-broker-j/pull/4 QPID-7972: [Broker-J] Put VirtualHostNode in ERRORed state if the underlying VirtualHost is You can merge this pull request into a Git repository by running: $ git pull https://github.com/overmeulen/qpid-broker-j feature/QPID-7972 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-broker-j/pull/4.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4 commit 39239f556844b83aa7bcb188e7f7ad579f20e0a1 Author: overmeulenDate: 2018-02-19T16:47:52Z QPID-7972: [Broker-J] Put VirtualHostNode in ERRORed state if the underlying VirtualHost is > Virtual Host Node should be in error state if the underlying Virtual Host is > in error state > --- > > Key: QPID-7972 > URL: https://issues.apache.org/jira/browse/QPID-7972 > Project: Qpid > Issue Type: Improvement > Components: Broker-J >Affects Versions: qpid-java-6.1.4 >Reporter: Adel Boutros >Priority: Major > > All details can be found here: > http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Broker-is-ready-even-if-an-error-is-occuring-on-startup-and-failStartupWithEre-tp7668029.html -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org