[jira] [Commented] (QPID-8084) QMF management client sends binary application property keys under Python 2
[
https://issues.apache.org/jira/browse/QPID-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350910#comment-16350910
]
Kim van der Riet commented on QPID-8084:
The above commit changes string literals only where they are used in
application property keys from:
{noformat}
props['key'] = 'value'{noformat}
to
{noformat}
props[u'key'] = u'value'{noformat}
for message properties only. Other maps using this pattern but were used in
message bodies were not changed.
> QMF management client sends binary application property keys under Python 2
> ---
>
> Key: QPID-8084
> URL: https://issues.apache.org/jira/browse/QPID-8084
> Project: Qpid
> Issue Type: Bug
> Components: Python Client
>Reporter: Kim van der Riet
>Assignee: Kim van der Riet
>Priority: Major
> Labels: interop
> Attachments: py2.pcapng
>
>
> The AMQP 1.0 spec states that message application property keys MUST be
> strings.
> Under Python 2.x, the QMF client communicates with the broker using binary
> strings as keys in the application properties to pass QMF commands.
> Two issues arise:
> # The Python client should not accept binary keys in application properties
> # The broker appears to accept this without warning or error. This could be
> considered undefined behavior, however.
> The reproducer can be found in QPID-8075. The attached Wireshark file shows
> the transfer in frame 18.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8084) QMF management client sends binary application property keys under Python 2
[ https://issues.apache.org/jira/browse/QPID-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350903#comment-16350903 ] ASF subversion and git services commented on QPID-8084: --- Commit 88f105c93150ca25ebe2f45fb92565d547063951 in qpid-cpp's branch refs/heads/master from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-cpp.git;h=88f105c ] QPID-8084: Change QMF client to use unicode string literals when encoding message application properties. Solves a Python 2 issue where the keys are encoded as binary rather as string types, which is contrarary to the AMQP 1.0 spec. > QMF management client sends binary application property keys under Python 2 > --- > > Key: QPID-8084 > URL: https://issues.apache.org/jira/browse/QPID-8084 > Project: Qpid > Issue Type: Bug > Components: Python Client >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Major > Labels: interop > Attachments: py2.pcapng > > > The AMQP 1.0 spec states that message application property keys MUST be > strings. > Under Python 2.x, the QMF client communicates with the broker using binary > strings as keys in the application properties to pass QMF commands. > Two issues arise: > # The Python client should not accept binary keys in application properties > # The broker appears to accept this without warning or error. This could be > considered undefined behavior, however. > The reproducer can be found in QPID-8075. The attached Wireshark file shows > the transfer in frame 18. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8084) QMF management client sends binary application property keys under Python 2
[ https://issues.apache.org/jira/browse/QPID-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350898#comment-16350898 ] Kim van der Riet commented on QPID-8084: See PROTON-1758 for the issue as it relates to the Python binding making a check of the message application property keys. > QMF management client sends binary application property keys under Python 2 > --- > > Key: QPID-8084 > URL: https://issues.apache.org/jira/browse/QPID-8084 > Project: Qpid > Issue Type: Bug > Components: Python Client >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Major > Labels: interop > Attachments: py2.pcapng > > > The AMQP 1.0 spec states that message application property keys MUST be > strings. > Under Python 2.x, the QMF client communicates with the broker using binary > strings as keys in the application properties to pass QMF commands. > Two issues arise: > # The Python client should not accept binary keys in application properties > # The broker appears to accept this without warning or error. This could be > considered undefined behavior, however. > The reproducer can be found in QPID-8075. The attached Wireshark file shows > the transfer in frame 18. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-8084) QMF management client sends binary application property keys under Python 2, Qpid-cpp broker accepts it.
[
https://issues.apache.org/jira/browse/QPID-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334792#comment-16334792
]
Kim van der Riet commented on QPID-8084:
Reproducer, copied from QPID-8075:
{noformat}
from qmf.client import BrokerAgent
conn_opts = {'url': 'amqp://localhost:5672'}
ba = BrokerAgent.connect(**conn_opts)
print(ba.getAllQueues())
{noformat}
> QMF management client sends binary application property keys under Python 2,
> Qpid-cpp broker accepts it.
>
>
> Key: QPID-8084
> URL: https://issues.apache.org/jira/browse/QPID-8084
> Project: Qpid
> Issue Type: Bug
> Components: Python Client
>Reporter: Kim van der Riet
>Priority: Major
> Labels: interop
> Attachments: py2.pcapng
>
>
> The AMQP 1.0 spec states that message application property keys MUST be
> strings.
> Under Python 2.x, the QMF client communicates with the broker using binary
> strings as keys in the application properties to pass QMF commands.
> Two issues arise:
> # The Python client should not accept binary keys in application properties
> # The broker appears to accept this without warning or error. This could be
> considered undefined behavior, however.
> The reproducer can be found in QPID-8075. The attached Wireshark file shows
> the transfer in frame 18.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
