Re: Review Request 61596: allow hostname to be set for sasl-init

2017-08-11 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61596/#review182734 --- Ship it! Ship It! - Andrew Stitcher On Aug. 11, 2017, 5:24

Re: Review Request 61596: allow hostname to be set for sasl-init

2017-08-11 Thread Gordon Sim
> On Aug. 11, 2017, 5:46 p.m., Andrew Stitcher wrote: > > This looks fine. > > > > Can you just confirm that adding this extra field to the frame is still > > amqp 1.0 protocol compliant (I dont have time to check that today). > > Gordon Sim wrote: > From spec: > >

Re: Review Request 61596: allow hostname to be set for sasl-init

2017-08-11 Thread Gordon Sim
> On Aug. 11, 2017, 5:46 p.m., Andrew Stitcher wrote: > > This looks fine. > > > > Can you just confirm that adding this extra field to the frame is still > > amqp 1.0 protocol compliant (I dont have time to check that today). >From spec: "This field can be used by AMQP proxies to

Re: Review Request 61596: allow hostname to be set for sasl-init

2017-08-11 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61596/#review182725 --- This looks fine. Can you just confirm that adding this extra