[GitHub] incubator-quickstep pull request #99: QUICKSTEP-36 Quickstep gives segmentat...

Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/99#discussion_r78439803 --- Diff: relational_operators/TextScanOperator.cpp --- @@ -18,6 +18,11 @@ **/ #include "relational_operators/TextScanOperator.hpp"

[GitHub] incubator-quickstep issue #90: Quickstep 28 29

Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/90 We can get rid of all the ``put*`` methods in the FastHashTable implementation, as they are not used elsewhere in the code. This would also simplify the concurrency related concerns

[GitHub] incubator-quickstep pull request #:

Github user navsan commented on the pull request: https://github.com/apache/incubator-quickstep/commit/cc479336efde3e576077d9a9821a161a2b1878a2#commitcomment-18992347 No there's a more recent one. Look for col_vec_opt or something. On Mon, Sep 12, 2016, 16:21 Marc S

[GitHub] incubator-quickstep pull request #:

Github user cramja commented on the pull request: https://github.com/apache/incubator-quickstep/commit/cc479336efde3e576077d9a9821a161a2b1878a2#commitcomment-18991876 @navsan this is the correct branch to work off of, correct? --- If your project is set up for it, you can reply to

compiler warnings- anyone seen this?

I get annoying compiler warnings upgraded to errors when building with clang 3.8, bison 3.0.4, flex 2.6.0: [3/170] Building CXX object parser/CMakeFiles/quickstep_parser_SqlLexer.dir/SqlLexer_gen.cpp.o FAILED: parser/CMakeFiles/quickstep_parser_SqlLexer.dir/SqlLexer_gen.cpp.o ccache

[GitHub] incubator-quickstep pull request #99: QUICKSTEP-36 Quickstep gives segmentat...

Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/99#discussion_r78439566 --- Diff: relational_operators/TextScanOperator.cpp --- @@ -18,6 +18,11 @@ **/ #include "relational_operators/TextScanOperator.hpp"

Missing report

Hi everyone, Quickstep didn’t file a report for the Board meeting this month. Can you please be sure to file one next month? Julian

[GitHub] incubator-quickstep pull request #99: QUICKSTEP-36 Quickstep gives segmentat...

Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/99#discussion_r78382304 --- Diff: relational_operators/RelationalConfig.h.in --- @@ -0,0 +1,20 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] incubator-quickstep issue #99: QUICKSTEP-36 Quickstep gives segmentation fau...

Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/99 Hi @tarunbansal I have given some comments. After you address them, I will merge this PR. Thanks. --- If your project is set up for it, you can reply to this email and