[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-18 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 Merged and closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-quickstep issue #115: Update travis to run only single thread whil...

2016-10-18 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/115 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-quickstep pull request #113: Optimizer changes for the LIPFilter f...

2016-10-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #111: Initiated query execution data struct...

2016-10-18 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/111#discussion_r83880693 --- Diff: query_execution/PolicyEnforcerBase.hpp --- @@ -163,6 +174,8 @@ class PolicyEnforcerBase { // Key = query ID, value =

[GitHub] incubator-quickstep pull request #111: Initiated query execution data struct...

2016-10-18 Thread hbdeshmukh
Github user hbdeshmukh commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/111#discussion_r83672097 --- Diff: query_execution/PolicyEnforcerBase.hpp --- @@ -163,6 +174,8 @@ class PolicyEnforcerBase { // Key = query ID, value =

[GitHub] incubator-quickstep pull request #117: Clean up the old BloomFilter implemen...

2016-10-18 Thread jianqiao
GitHub user jianqiao opened a pull request: https://github.com/apache/incubator-quickstep/pull/117 Clean up the old BloomFilter implementation where BloomFilters are attached to HashTables This PR cleans up the old BloomFilter implementation where BloomFilters are attached to

[GitHub] incubator-quickstep issue #117: Clean up the old BloomFilter implementation ...

2016-10-18 Thread hbdeshmukh
Github user hbdeshmukh commented on the issue: https://github.com/apache/incubator-quickstep/pull/117 Looks good, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-18 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 If that's what were waiting on, then yes, I can go test it. Of course that will be with a subset of working queries. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-18 Thread cramja
Github user cramja commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 @jianqiao Sure, that sounds good. @navsan and I talked about another alternative which is to call the BitVector constructor instead of `setMemory`. I made the `set` method because I

[GitHub] incubator-quickstep issue #109: Refactored SplitRowStore bulk insertion

2016-10-18 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/109 @cramja I'm not sure about the overhead for calling the constructor inside the accessor loop. We can first have this `setMemory()` version merged to have a reference for the

[GitHub] incubator-quickstep issue #114: QUICKSTEP-59 Convert setBitRegularVersion() ...

2016-10-18 Thread saketj
Github user saketj commented on the issue: https://github.com/apache/incubator-quickstep/pull/114 @cramja Thanks Marc for reviewing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have