Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/109
Merged and closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/115
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/113
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/111#discussion_r83880693
--- Diff: query_execution/PolicyEnforcerBase.hpp ---
@@ -163,6 +174,8 @@ class PolicyEnforcerBase {
// Key = query ID, value =
Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/111#discussion_r83672097
--- Diff: query_execution/PolicyEnforcerBase.hpp ---
@@ -163,6 +174,8 @@ class PolicyEnforcerBase {
// Key = query ID, value =
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/117
Clean up the old BloomFilter implementation where BloomFilters are attached
to HashTables
This PR cleans up the old BloomFilter implementation where BloomFilters are
attached to
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/117
Looks good, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/109
If that's what were waiting on, then yes, I can go test it. Of course that
will be with a subset of working queries.
---
If your project is set up for it, you can reply to this email
Github user cramja commented on the issue:
https://github.com/apache/incubator-quickstep/pull/109
@jianqiao Sure, that sounds good. @navsan and I talked about another
alternative which is to call the BitVector constructor instead of `setMemory`.
I made the `set` method because I
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/109
@cramja I'm not sure about the overhead for calling the constructor inside
the accessor loop. We can first have this `setMemory()` version merged to have
a reference for the
Github user saketj commented on the issue:
https://github.com/apache/incubator-quickstep/pull/114
@cramja Thanks Marc for reviewing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
11 matches
Mail list logo