[GitHub] incubator-quickstep issue #257: Added Partition Rule for HashJoin.

2017-06-15 Thread jianqiao
Github user jianqiao commented on the issue: https://github.com/apache/incubator-quickstep/pull/257 Good refactoring. LGTM! Except one place in `PhysicalGenerator.cpp`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-quickstep pull request #263: Added the execution support for LIP w...

2017-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-quickstep/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-quickstep pull request #257: Added Partition Rule for HashJoin.

2017-06-15 Thread jianqiao
Github user jianqiao commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/257#discussion_r122326409 --- Diff: query_optimizer/PhysicalGenerator.cpp --- @@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {

[GitHub] incubator-quickstep pull request #257: Added Partition Rule for HashJoin.

2017-06-15 Thread zuyu
Github user zuyu commented on a diff in the pull request: https://github.com/apache/incubator-quickstep/pull/257#discussion_r122334121 --- Diff: query_optimizer/PhysicalGenerator.cpp --- @@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan() {

[GitHub] incubator-quickstep pull request #263: Added the execution support for LIP w...

2017-06-15 Thread zuyu
GitHub user zuyu opened a pull request: https://github.com/apache/incubator-quickstep/pull/263 Added the execution support for LIP with partitions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zuyu/incubator-quickstep