Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/295#discussion_r138950122
--- Diff: query_optimizer/tests/logical_generator/Create.test ---
@@ -63,6 +67,15 @@ PARTITION BY HASH(attr1, attr2, attr3, attr4, attr5,
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/295
I have one minor comment, otherwise looks good.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/271
LGTM. Merging.
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/271
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/297
LGTM. Merging.
---
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/295#discussion_r138971636
--- Diff: query_optimizer/tests/logical_generator/Create.test ---
@@ -63,6 +67,15 @@ PARTITION BY HASH(attr1, attr2, attr3, attr4, attr5,
attr6)
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/295
Looks good.
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/297
---